From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f54.google.com (mail-it0-f54.google.com [209.85.214.54]) by dpdk.org (Postfix) with ESMTP id 970707CE1 for ; Thu, 26 Apr 2018 23:28:22 +0200 (CEST) Received: by mail-it0-f54.google.com with SMTP id c5-v6so817592itj.1 for ; Thu, 26 Apr 2018 14:28:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=oEymkYB+J/7YntUrvqv7UjGYD00MGQfmz4VkMe2c8kc=; b=PoSXJNTWsPDs3f3vYhZUltNLzC+eXvCr7ggNIoNAe1xC2NdbkfREDDjbQppBeF9jVf v3Q7iJnH6wtkikD5lssthDS3OtBRh5pbCNXB+HEw18ZtvUaPorTLUVNlsMOqIYjvd/Oy FaouoaiLBceFlZmOs6UogCknTFEevVRQRbXxSwobFjKOdy4FjKWRcFuCOMxuOdMEqqor Os6CTaYLbkkHfvT+d7GpA+oYhCgJTkwHpRfVJwHf4k487ECU8Ec52VD+qvVW7JDEbXSQ N+rkTZViIjoo54mzsaKpg2h6h5pTFxqEOL7OMqhLQ35XtMVQQIO55/z2MRUg+qzx/kww gQDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=oEymkYB+J/7YntUrvqv7UjGYD00MGQfmz4VkMe2c8kc=; b=cT28ryrBl0BvVdvaHjiwQY7Sh7yIrV7rgbSIAkaPQ9alRCKm9at8ogMBMNZifgWN+v iXUIGMxPDU4JAe/g1XWBEUGoblRLO6QxGIG24hgmvPip9C7h0ciz/vWEUvyDowK2PxiE bou2j6hbtSDGzjs1wW0U+MUOo2cAJV8YOplP37DmitYZxd7SXh8GQRmBXOkVWu4bvo7k Nv/2OBEZRwIZw7HP9QElMsJmug5Ctc9IFLoYdFLuz0aApJYKgBHZub8F2RRJ7zewC0Jd i5MyHK8Oobn53aoGe7wcRCOB7b8xNgXQr8SNaFe6M8Dcl8qrjAODGHSQwk89Zr2/x9wI dyfg== X-Gm-Message-State: ALQs6tCOnMG63FDpmt9nRWceIjk7FNI/yurQM/tTQ0fEgmFGN3s09e+o KnyVIzmSmRtxZ2la3/+itr4sV6EYkRrSQh6kKvqW8w== X-Google-Smtp-Source: AB8JxZr52RGPWs1UslW/X9IwAiSRv1ssAsLiI4NHpJmjiO3E3O9zwxAH96togQ2HpdcvDmJp6VzbOMkQepf/z39zYuM= X-Received: by 2002:a24:3c4c:: with SMTP id m73-v6mr159215ita.138.1524778101991; Thu, 26 Apr 2018 14:28:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Thu, 26 Apr 2018 14:28:21 -0700 (PDT) In-Reply-To: <07170182-8293-8347-b0ff-9a77885b637f@redhat.com> References: <1524608213-2080-1-git-send-email-arnon@qwilt.com> <1524608213-2080-2-git-send-email-arnon@qwilt.com> <07170182-8293-8347-b0ff-9a77885b637f@redhat.com> From: Arnon Warshavsky Date: Fri, 27 Apr 2018 00:28:21 +0300 Message-ID: To: Kevin Traynor Cc: Thomas Monjalon , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v7 01/11] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 21:28:22 -0000 > > - if (cryptodev->data->dev_private == NULL) > > - rte_panic("Cannot allocate memzone for private " > > - "device data"); > > + if (cryptodev->data->dev_private == NULL) { > > + DPAA_SEC_ERR("%s() Cannot allocate memzone for > private device data", > > + __func__); > > + return -ENOMEM; > > I'm not familiar with the code but there was a successful allocate > already, so it seems you should jump to the cleanup section at the end > of the function before returning. > > Hi Kevin, The purpose of this patchset is not to offer a recoverable alternative for panic, rather allow the process to abort in an orderly manner. It does not cover in this version all the panic instances on the init sequence. Other than in places where it seemed straight forward I tend not to perform in this patchset partial resource release where panic was before. Thanks /Arnon