From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arnon@qwilt.com>
Received: from mail-it0-f46.google.com (mail-it0-f46.google.com
 [209.85.214.46]) by dpdk.org (Postfix) with ESMTP id 577277CEB
 for <dev@dpdk.org>; Fri, 20 Apr 2018 15:23:49 +0200 (CEST)
Received: by mail-it0-f46.google.com with SMTP id 19-v6so2463386itw.3
 for <dev@dpdk.org>; Fri, 20 Apr 2018 06:23:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=qwilt-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=im/+1jKH9qKc3vKRDPSPnNxe0x+KOZJrCcz9YoreKfY=;
 b=s6S+RisDK0WkPWLFOh/wwOs1m7dUVLVHSX/IfYS4pFDppPnilREfE+EZHYXR2nvcF2
 1IECmc/6YUxb/UcWFUY8slNCMR8auojM0RqItwKGfykivX6qZdhn7EGdPm6nF+WELuki
 T/xisieG6EXmd6YfU8tIOzRZLPLylR4HqCsRmvM3UPzGP7xQVgK9nxMRz6ink989xp79
 YfV36tG8c9UDuQgSFQGzcBO10bokiR5M5cDZ0pnv+S7TevXnhVSbe8UbC6x1vzOjP/5O
 aFo1GOAD6lnvsYKN7PRI5EZ5B7Fpy1O2A5zIPCqVsFfZbqg6Inff/veutXKPTixd349w
 hM4g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=im/+1jKH9qKc3vKRDPSPnNxe0x+KOZJrCcz9YoreKfY=;
 b=BdGW2bG0Crc8g1Clh2s0v24iVA96M+AzOGwvayOHPyu8AmhsZul48YgtbGX1rtWex2
 xnTYPE4LRjqcj2WfZq386WnpaGuTIDw8WHPcZioerw8aJKGKDEp1QY6RbBqxfJA/0aqP
 YFIKbA7EQ0/TZdurA3mfASuwErzUmqxyIzGhZfeO6PFYkkmOWcKUGqcwoUqjdcPd5R+L
 cPx7eIegV9tCGCA58QdHiiQEgc0GwxoFa+yBfjDi7tYvB+Mx25YkJ+97RWYcrIJe3+wQ
 mtoKB0Qtwd3ASjr5e+IwfG1G+KGA9l5rw4mmMzmiivCvvWfq6ahAXeW3wj7pzPeOE4PU
 FNzQ==
X-Gm-Message-State: ALQs6tCUxRq53Pr4b3F7Uca4BVNwGqicvyS4VFQ8C6VFiEgp5qfv/8J7
 el0rFjF0w1yrIURBVgxxMDerRQfhCg7R0iUS+48GhA==
X-Google-Smtp-Source: AIpwx48e6D3fiTKoQhlSQfaNDUVicPJGy8cs9HV/auAhmCsUKR8oYapiQzCBppEspzDwrk9rITLE2BxJ2VX3wCbOYfg=
X-Received: by 2002:a24:86c4:: with SMTP id
 u187-v6mr3002446itd.138.1524230628694; 
 Fri, 20 Apr 2018 06:23:48 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.142.145 with HTTP; Fri, 20 Apr 2018 06:23:48 -0700 (PDT)
In-Reply-To: <f307c97a-58f2-9919-9e1b-5afde681444d@redhat.com>
References: <1524117669-25729-1-git-send-email-arnon@qwilt.com>
 <1524117669-25729-10-git-send-email-arnon@qwilt.com>
 <f307c97a-58f2-9919-9e1b-5afde681444d@redhat.com>
From: Arnon Warshavsky <arnon@qwilt.com>
Date: Fri, 20 Apr 2018 16:23:48 +0300
Message-ID: <CAKy9EB1p9tHdCON3JHkShBaduN=Y+_wuZdh2AVvaOgdREpRc4Q@mail.gmail.com>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, "Burakov,
 Anatoly" <anatoly.burakov@intel.com>, 
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Doherty,
 Declan" <declan.doherty@intel.com>, 
 jerin.jacob@caviumnetworks.com, Bruce Richardson <bruce.richardson@intel.com>, 
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v4 09/11] eal: replace rte_panic instances in
	ethdev
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2018 13:23:49 -0000

>
> Lots of "!= 0"'s - you might gather by now that I don't like them :-)
>

No way. Would have never guessed that :)
Sure. When in Rome..


>
> hmm, I'm wondering should void __rte_experimental
> rte_eth_dev_owner_delete change to return an int, now that there is a
> fail case and it is still experimental...?
>

Good point. Missed that
thanks
/Arnon