From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f50.google.com (mail-it0-f50.google.com [209.85.214.50]) by dpdk.org (Postfix) with ESMTP id A47A5AAD8 for ; Fri, 20 Apr 2018 15:11:27 +0200 (CEST) Received: by mail-it0-f50.google.com with SMTP id h143-v6so2476512ita.4 for ; Fri, 20 Apr 2018 06:11:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=F8Sf3Rsrc1OcV5I/YehIsv3wcKz9SHbV66MjiSbHqb4=; b=GSYGTOxlnRmxAQ48RyTXgk4ox9YIEcKbgI7eMgkYtd0YF8NotkEcu6+HJbAFbvz8Hq /er+kNAGZFnEpBKUvmIhoak/BinC/HCxvhn43lf8TuI0tLpRT9lucAiuMrYkN1/dCbGo mHwikzvUzVOHzf/fFVIfK70PzM49tf8QmNQ2t1oNy9CPWjSzOYkyyEhx/hd3ON1OF7j8 2t1mFam7hihSvajwo0MLv9FHMvNmB9MKgweRjWwy4zhIZZ1hS9ywyhMzXPaEnnIMwflr OcmJBZ4MfBwLy9cUYR2e0KbweSeKisA/ovWa0t592aNajfAPbtKFxH0mGqwq4Y+OU5yD bnjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=F8Sf3Rsrc1OcV5I/YehIsv3wcKz9SHbV66MjiSbHqb4=; b=WrBBDL274dwx1nMxutM37OJitpO+jU9sIQo3GEBBxKwLRNRkjWOLJZbQIUOe/jTm0L RCNW7ucok6V1JsIYVeeO8I9DQ+aqx1wtXMbpmOpnBV7IUzDNJArHuyDaIqcHOcdg93yQ n8adBDXXhS3ZNerTPHvR83/HS+77gSIVcZWDwxg9UkiE21wPyCv5cV8AQFbLfoCP5w8e X3xRDJgyiWA1kBqGv1sW6GaWjg7cug/GgYenGR8vpPZdDsJrIA1ZpS+mTucH0l5MT6tW tNa5FGEEKI1sGVepwVvP9aw8uAXaz7t5GppNTNaGdxgjhqGOqzHyJVq/wR7cH6ls3CGR H9og== X-Gm-Message-State: ALQs6tBWCeUtW002fCundKuxSiHDY9Goqk8dYr3MNYc8XLgzY3Lrai4u dzWM/YzeDzWuRgLSg85bXmdEgZUObc3AoZkb9L3qxw== X-Google-Smtp-Source: AIpwx48h1yeUhu7ZhZ8IFqCvfSxOjkV3qEqXUufy8c3FEM3BnIl8G33QaXpnP94CrU5xK5GlXePLxezMiJdITl98Du8= X-Received: by 2002:a24:24ce:: with SMTP id f197-v6mr3003884ita.25.1524229886989; Fri, 20 Apr 2018 06:11:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Fri, 20 Apr 2018 06:11:26 -0700 (PDT) In-Reply-To: References: <1524117669-25729-1-git-send-email-arnon@qwilt.com> <1524117669-25729-8-git-send-email-arnon@qwilt.com> <9d631c8a-5ec6-aae1-9f5d-0c890dfb1c19@intel.com> <3082a58f-46c9-d4c0-6c30-bb84a17bd6fe@intel.com> From: Arnon Warshavsky Date: Fri, 20 Apr 2018 16:11:26 +0300 Message-ID: To: "Burakov, Anatoly" Cc: Thomas Monjalon , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2018 13:11:27 -0000 Now clear.Thanks On Thu, Apr 19, 2018 at 5:50 PM, Burakov, Anatoly wrote: > On 19-Apr-18 3:45 PM, Burakov, Anatoly wrote: > >> On 19-Apr-18 3:09 PM, Arnon Warshavsky wrote: >> >>> Thanks Anatoly. Will fix that in v5. >>> Is it preferred to keep all version notes in the cover letter alone? >>> >>> >> Generally, cover letter should give general outline (i.e. "fixed 32 bit >> compile"), while notes for individual patches should be more specific about >> the changes between versions (but not too specific, i.e. don't do "change >> variable X on line 100 to be Y"). >> >> So, whatever you think gets your point across best. Not all changes >> deserve to be called out in the cover letter. >> >> Just to be clear: > > With my initial reply, i did not mean "patch notes should be in the cover > letter". What i meant was that you have put your version changes "e.g. v4 - > changed this to that" into the commit message. > > What you should have done is put your patch notes after the commit > message, like this: > > replace panic calls with log and retrun value. > > Signed-off-by: Arnon Warshavsky > --- > > v4 > static size calculation function changed to return success/fail code > in addition to filling the size result. > > > lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 32 > ++++++++++++++++--------- > 1 file changed, 21 insertions(+), 11 deletions(-) > > Note that the v4 comments are after the "---" - this is where the commit > message ends as far as git concerned, so you can put your notes there. > > -- > Thanks, > Anatoly > -- *Arnon Warshavsky* *Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon@qwilt.com *