From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f175.google.com (mail-io0-f175.google.com [209.85.223.175]) by dpdk.org (Postfix) with ESMTP id D5D3A4CC0 for ; Tue, 27 Mar 2018 16:06:25 +0200 (CEST) Received: by mail-io0-f175.google.com with SMTP id q80so16825897ioi.13 for ; Tue, 27 Mar 2018 07:06:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Ebzsza2M6IdNhhR7YWv05pIeuE2cWUqlHyTZHq1C+2s=; b=vODMBSykrvhedA+PwjLMyKa0//cIILOjZQYpPkZXKr6MciUnTjF7mIBeRiNpjiC/60 VbKo2WNEVStJwSWS+7e5cTqoLW1l2d6WpnlAK/6cKuBQmlU07LA8ihkvVEfBb1JwdwXH aqYr1SbeIWbICeyGT/G9PV9+/8NQPUgwsgFjdDZuKfjuEoPTCaO+vSZfzRGzrBS0cQY8 iFv4bz4aXjx23sUlkCXVryVK6dumxWmWjbgymJ4Z6V7Nx8B4X/4NJqaNZ4K3nyzjHZv/ 1ZNuQXpBw4K/szYFlYyIVba022GZOpIWi06j5ObrHsIxYRGD8CFvS+5zut9j+OjFGiQ8 FxwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Ebzsza2M6IdNhhR7YWv05pIeuE2cWUqlHyTZHq1C+2s=; b=D3TWmX3/5yc+fZvLOuWBUH5SFjtZ3ae65xmx7Vs/H9YyRCMXAtIR++FTDS+tUg62Np mknVvHL4iuLdv6X1kCoGKsW7ipEfGT85/Ha9xbxPHF3nl2WZnMwwJ9/HKrM3XL33ECb5 GKS784ri2RTOUPkcqGCaDXvZ01gKt0rUKTwGh725lTdlYm0dmfydWGshnaeuS+wpU9gr /bn9fM8iknuY/6+SXyGzHPAX1XEf5z5Mq08RQWUpJQAVMMp3hw0+RLk9oRA4OvUGti3Q jrrkogzC0q+lBn//ZgqAln2p2h0YBvHFg4C/sephIUxrJkqCFn7qFCg5Ms37f03hvfBb AbFg== X-Gm-Message-State: AElRT7H3Dt9029QveW5Mq85haVjRqqwhC7cd7OafDR4pXnvTecmsMO8c q1S35/dn9u3psBS9rn53uYwsTdoaOTnivyR5Dbr1Uw== X-Google-Smtp-Source: AG47ELuEKby2rNHIllRHM7w9P8Ay5nGxk4gOe2rWdwYGqqsY0vU22NXVQgjnZQRvTGCOAXhteI4HAqjjj12IqFil2Gw= X-Received: by 10.107.8.32 with SMTP id 32mr14555748ioi.136.1522159585058; Tue, 27 Mar 2018 07:06:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.202 with HTTP; Tue, 27 Mar 2018 07:06:24 -0700 (PDT) In-Reply-To: References: <1521582788-32364-1-git-send-email-arnon@qwilt.com> <20180321091153.GA17868@bricha3-MOBL.ger.corp.intel.com> From: Arnon Warshavsky Date: Tue, 27 Mar 2018 17:06:24 +0300 Message-ID: To: Bruce Richardson Cc: Thomas Monjalon , "Burakov, Anatoly" , wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, ferruh.yigit@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3] eal: replace rte_panic instances to return an error value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 14:06:26 -0000 I now have a set of several patches which pass the abi-validation , 1 patch of checkpatches.sh to prevent future panic instances and the set of abi-breaking changes which are included the init sequence. 1. I assume it is best to bundle all to a single patchset. Please correct me otherwise 2. Trying to work around the abi in this phase What is your take regarding adding a state to the init phase: int rte_get_legacy_panic_state(); void rte_move_to_legacy_panic_state(); This will allow preserving abi for these few functions, replacing for example the currently abi-breaking if (eal_thread_init_master()) return -1 with eal_thread_init_master() if ( rte_get_legacy_panic_state()) return -1 while calling rte_move_to_legacy_panic_state() from within these void functions where panic takes place today. This can also partially serve the cases where panic is called from within an interrupt handler, and have no applicative context to return to. thanks /Arnon