From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f182.google.com (mail-io0-f182.google.com [209.85.223.182]) by dpdk.org (Postfix) with ESMTP id 22BA8803B for ; Thu, 19 Apr 2018 15:50:00 +0200 (CEST) Received: by mail-io0-f182.google.com with SMTP id c26-v6so6660584iob.3 for ; Thu, 19 Apr 2018 06:50:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=bx9pAoVvvVGfa+/7IGbax7UtboJtcJVL3DLgroW0zJM=; b=UZnbfIXZGnF+6JstJJkUzu30y+wrPtdSZXYqpRij4pHzA2sQsFe9E0Bf/dfFJ2W7Dk z2PuH49r6wdNuTzzdKqfL8MNYRHkOAQQeDmQtgg0zD/dWoZgG7lzZxS7fgWoSNOLWNOa K6oIDSVm7lUEcB5H87eAIl0++RMTjr3l+QLmqIJ3bVBocNt5g0LvrIaYVhdyR2VODilI 517PYdO1AJ2K2aEtZGQ32rABn52/Luwjz+rJh61F/pdp5iv2RVND4mqj/hKAeZa0NX/7 Wmr+B3Qk43UREM3MvQKAz+vWIwdOXLdJOh9o7tkKm4Epqdlre10OObeDlp2ZGRZfy7we FT3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=bx9pAoVvvVGfa+/7IGbax7UtboJtcJVL3DLgroW0zJM=; b=tJpPhJ9RxbpLWFq8FSR9DMyBeJYTdN294Sc7rjNReONu1bxIU3td2Zf6bROZy+wdEs MNMumpq5hY5A+nV/DQmvD5ssag5yHF96OfsFQit/1bdP728wt5dJx7M0pdPX8h0uWozi HSU/c18XJGleAyafsECJvZvRcm7uEaTKSI2V3G//TxK8+T9gk+we1AJR0JTcoRgL0Nse UQME2w57aZrWkn8E+xdJlKGYjMPugCldaYFxMzRXrqWM0ZhQ+HWmsNy7WAxWcacsU71O cn5agSetmORnTb57yyzXrZOm5YbR/JB4tUQ+kLRO6sayushNRsE24AvMyAYqoOxN1TX4 hWHA== X-Gm-Message-State: ALQs6tDySh2HKmkdFxP+1lY+/uuMS5sDAu+0tQYl3XAMYYcX32ia9Im1 6cQ3Fns63rOZiZH6JLazVciZ5j1IxVauma7aTYyWbw== X-Google-Smtp-Source: AIpwx4/sI5UcPXg/drsGhT7DyESI2PGChEP2L59Y3l5CgAlUYCQ53p5Kmc5dgsf1Z4UjIPngpHSDAhBy8N6lknjIJqg= X-Received: by 2002:a6b:a89b:: with SMTP id e27-v6mr6096928ioj.180.1524145799481; Thu, 19 Apr 2018 06:49:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Thu, 19 Apr 2018 06:49:58 -0700 (PDT) In-Reply-To: <348A99DA5F5B7549AA880327E580B43589376D31@IRSMSX101.ger.corp.intel.com> References: <1524117669-25729-1-git-send-email-arnon@qwilt.com> <1524117669-25729-2-git-send-email-arnon@qwilt.com> <348A99DA5F5B7549AA880327E580B43589376D31@IRSMSX101.ger.corp.intel.com> From: Arnon Warshavsky Date: Thu, 19 Apr 2018 16:49:58 +0300 Message-ID: To: "Trahe, Fiona" Cc: "thomas@monjalon.net" , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , "jerin.jacob@caviumnetworks.com" , "Richardson, Bruce" , "Yigit, Ferruh" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 01/11] crypto: replace rte_panic instances in crypto driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 13:50:00 -0000 Sure.Will change that in v5 On Thu, Apr 19, 2018 at 1:53 PM, Trahe, Fiona wrote: > Hi Arnon, > Can you change subject to crypto/dpaa:... please as it's only affecting > that driver. > Fiona > > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Arnon Warshavsky > > Sent: Thursday, April 19, 2018 7:01 AM > > To: thomas@monjalon.net; Burakov, Anatoly ; > Lu, Wenzhuo > > ; Doherty, Declan ; > > jerin.jacob@caviumnetworks.com; Richardson, Bruce < > bruce.richardson@intel.com>; Yigit, Ferruh > > > > Cc: dev@dpdk.org; arnon@qwilt.com > > Subject: [dpdk-dev] [PATCH v4 01/11] crypto: replace rte_panic instances > in crypto driver > > > > replace panic calls with log and return value. > > > > -- > > v2: > > - reformat error message to include literal string in a single line > > v4: replace -1 return value with -ENOMEM > > > > Signed-off-by: Arnon Warshavsky > > --- > > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 8 +++++--- > > drivers/crypto/dpaa_sec/dpaa_sec.c | 8 +++++--- > > 2 files changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > > b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > > index 23012e3..d465a2d 100644 > > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > > @@ -2861,9 +2861,11 @@ struct rte_security_ops dpaa2_sec_security_ops = { > > RTE_CACHE_LINE_SIZE, > > rte_socket_id()); > > > > - if (cryptodev->data->dev_private == NULL) > > - rte_panic("Cannot allocate memzone for private " > > - "device data"); > > + if (cryptodev->data->dev_private == NULL) { > > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone > for private device data", > > + __func__); > > + return -ENOMEM; > > + } > > } > > > > dpaa2_dev->cryptodev = cryptodev; > > diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c > b/drivers/crypto/dpaa_sec/dpaa_sec.c > > index b685220..7b63650 100644 > > --- a/drivers/crypto/dpaa_sec/dpaa_sec.c > > +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c > > @@ -2356,9 +2356,11 @@ struct rte_security_ops dpaa_sec_security_ops = { > > RTE_CACHE_LINE_SIZE, > > rte_socket_id()); > > > > - if (cryptodev->data->dev_private == NULL) > > - rte_panic("Cannot allocate memzone for private " > > - "device data"); > > + if (cryptodev->data->dev_private == NULL) { > > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone > for private device data", > > + __func__); > > + return -ENOMEM; > > + } > > } > > > > dpaa_dev->crypto_dev = cryptodev; > > -- > > 1.8.3.1 > > -- *Arnon Warshavsky* *Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon@qwilt.com *