From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f173.google.com (mail-io0-f173.google.com [209.85.223.173]) by dpdk.org (Postfix) with ESMTP id 858C03DC for ; Sun, 29 Apr 2018 08:23:39 +0200 (CEST) Received: by mail-io0-f173.google.com with SMTP id e12-v6so6940768iob.8 for ; Sat, 28 Apr 2018 23:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Cm6BRVW7kmUmrq59H7u+EYAdfjUCag9+Bs9IkAAIHqU=; b=j5Ch3QSqKoLykz8OpKkiRT4nesljfAGb6p5xUWnqE+GEyr+CcKeXQbUVxgiLlSyx9g 7nheML8hgVEL0OG9rwGo8o67NfbVVNZWV2GERdV3mSUcjPT6Y1ATNxUnItQEhHj3UNUY 7Ow2V899RXO+J8zsr8WZBfaOKH22jo6XbXe02oLoWKOwyAd5spIsJpy/fruM+A1ErtaZ /WUGRGmUMPVrAH+qlVDqIiePtw2FrxMvf+F2BaqFZ6uVyI5QEkXMxdXgyPs6WN9Z8hni x11ZuDS0Ijype4g47GA/HjYjS8IRe571/n7FbSt9lWgZ/GO5kiOLlgtNqHQuEO2kpV3y A44A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Cm6BRVW7kmUmrq59H7u+EYAdfjUCag9+Bs9IkAAIHqU=; b=H9P+m/c6Kt98hodNufKJ1U36ZbBNwi8j4NwF09VZbR130O4UYyQK7vAOyvl3qG0fzz ITaM+4Sf+7xdXPO4380BRt9/GIDcVVn+7VWUmVslaYZIlpWYlzNPR4kdZ3wj6nJCRAEe 4yY8B0rAQPkuQhdEeFpDWjfpwdFyUbfZhW6GWXVcRy6/B0vg0kj1V84l8qsnAJvfrNgR BGPn0bqM3Db6QbEpr+dXSoOCIWt+vWvIQ6IGe8yWPSnzW8ALyMzzEy1GxK51gJaN4+y8 wWcl+vedVFVuKbFsigaTZTczT8t/EqoxZhjp9TpBaNL1gaFDr3VgO58W/cb7u2/wAZkv Jmxw== X-Gm-Message-State: ALQs6tCCRnifjAg67xejF/ZQCz4S8jfawcJwIbY2joMElBnGptnqKmzu ET8s1WRT1DYiLhyNx0JAzjmH18vxcuQIG9ZaLyMr+w== X-Google-Smtp-Source: AB8JxZpG/f5v3W8WPThG/hzZCGkQZFOnQG/SRU2Ke2LL3Q3JJbVR8t3axiZZa7huftqp2DraPlHEFeXL0EKWCcHDhnU= X-Received: by 2002:a6b:6918:: with SMTP id e24-v6mr8963968ioc.242.1524983018519; Sat, 28 Apr 2018 23:23:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Sat, 28 Apr 2018 23:23:37 -0700 (PDT) In-Reply-To: <3bc1745d-c294-4059-db60-b40387d89378@redhat.com> References: <1524663944-30376-11-git-send-email-arnon@qwilt.com> <1524723664-30510-1-git-send-email-arnon@qwilt.com> <1524723664-30510-11-git-send-email-arnon@qwilt.com> <22f61f91-9755-520c-9ba1-d93a312a43e3@redhat.com> <3bc1745d-c294-4059-db60-b40387d89378@redhat.com> From: Arnon Warshavsky Date: Sun, 29 Apr 2018 09:23:37 +0300 Message-ID: To: Kevin Traynor Cc: Thomas Monjalon , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Apr 2018 06:23:39 -0000 So will it fail checkpatch in patchwork? I agree with Aaron and Anatoly > that patches with rte_panic/exit should flag some warning message, but > the maintainer should have final say. I don't think failing checkpatch > is the solution for that. > Ok. will leave that to the maintainers and change that not to fail > > I would rather keep the word 'prevents' as an intention declaration that > > puts the fact that a panic is undesired first, and the technical ability > > of a maintainer to allow it second. > > It's only words, but to me 'prevents' does not indicate that it is > undesirable - it indicates it is not allowed. > They say words create reality, but since we agreed on reality, I'll reword :) > > > Not sure I understand what you meant here. Can you please elaborate? > > > > Sure, I made a patch with an rte_panic and ran checkpatch on a bunch of > patches. It gave me the name of all the patches except the one with the > rte_panic. > > Got it now. I wasn't using -v .Will fix Thanks /Arnon --