From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f173.google.com (mail-io0-f173.google.com [209.85.223.173]) by dpdk.org (Postfix) with ESMTP id 2EEE84C76 for ; Tue, 20 Mar 2018 23:42:18 +0100 (CET) Received: by mail-io0-f173.google.com with SMTP id e7so4340831iof.2 for ; Tue, 20 Mar 2018 15:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WTwmdOskgcRVENrUHsdMGB+botYGK6QJRD72DfM3WcA=; b=hpu2/f/BN6lRmbtuzLyECjzy6jwQ9CkLZo6+FMd3/j/Lrey2bmzC5/boETcCQEsOHc rEsnow/1e0CTPSAANbt/UhMYI83n3kRdt1N2YJsupGjS/p5JEHvVUCeN3sotWpKako40 r8r/wAhkFN2Z3bR+EQuD1y6ikHE7jwMKRnaC9BWxERCMO9vBtGYJMSTxC3hiVm4qchfX +IpGF1lCU5HTjItXqUW7+e+oA7SROGu6H+nMPU0hmzckgS/VjuDCkNZTn1kMYp7PhtXl rHHYxCl+JpicPzfRe70u0S95ivdXXjBz5+4mQZddyI7S/QUZf+Aq6Bpriru3z9/XM4DG 0Dng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WTwmdOskgcRVENrUHsdMGB+botYGK6QJRD72DfM3WcA=; b=Dk9/fePNnFuLEHd7TTBjtr/7PkScWM0CZPUwCrd65qPdtU8uMkZS5euL7WkdVrXZHg vK3WFsbesKl9CSgXNTuPZrKLUzWHPo1AzygYsti1RjMFQdLPmh5l4fSzHOEvbcr6NOIT b1F0axvC5ORrVc5x0kITmRvOdolhpv53oNK//gUExMxQP8I77QqKFuphX4JZTmJrbRg1 FW/D7JCufbF+hZWuEn51AEYR0zEo6U8NI0WP/rQYvDPx5fOCCYhctbjio0fOiNR+/rtI K4UaxLpwovCG2RivwAkDxuSxfTRtcv7IU/CS0h7Cn3hHovEYFt6w7UvUV5fhGvXD8e7+ Dreg== X-Gm-Message-State: AElRT7FqKcJDW+q8CFpT1TdnIsXnn/lPHAf5EuEEYchQcVCA46VFIxe1 WK6uivQRj7TfSY0Z3D47HYxJtVPq4qQhMka+jZEKdA== X-Google-Smtp-Source: AG47ELvHnPZ4BTT3L1yRK2x5ecch8dR2gLOy3137jgbPgoGeqek35oKCQ0pEL8QZV3cUJUp2M8aQYzlnEA3nFS4hUOc= X-Received: by 10.107.52.146 with SMTP id b140mr17231124ioa.8.1521585737412; Tue, 20 Mar 2018 15:42:17 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.202 with HTTP; Tue, 20 Mar 2018 15:42:16 -0700 (PDT) In-Reply-To: <6503395.k68LoKUDuZ@xps> References: <1521581285-4709-1-git-send-email-arnon@qwilt.com> <6503395.k68LoKUDuZ@xps> From: Arnon Warshavsky Date: Wed, 21 Mar 2018 00:42:16 +0200 Message-ID: To: Thomas Monjalon Cc: "Burakov, Anatoly" , wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, Bruce Richardson , ferruh.yigit@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] eal: replace rte_panic instances to return an error value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Mar 2018 22:42:18 -0000 > Thanks for working on this important topic. > With pleasure :) > ... > My feeling is that we could replace most of them by a log + return. > I did not think you would add a new macro. Why you chose this way? > This was meant to keep the code shorter, and imply to the reader that this > return is actually meant to be fatal > ... > > I would like to define a device health state that can be monitored from > > the side,and this will be an independant patch. > > You mean when a device become unusable? > Yes. Obviously not a simple issue, but essential for refraining from panic in the interrupt/data-path context, while allowing to detect and execute on the slow/management path. > > .. > > - Some previously panicing void functions where changed to return a > value, > > with callers modified accordingly. > > If the function is exposed to the application, I think it is an ABI change > and should follow the deprecation process. > In this case I thought there would be no actual change for the user as the transition is from returning void to int, and existing calls should continue to behave as before (except for not crashing) Following references to these functions, they all seem to comply to this rule, but I guess that's what reviews are for :) > > > /Arnon