From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f43.google.com (mail-it0-f43.google.com [209.85.214.43]) by dpdk.org (Postfix) with ESMTP id B41077D30 for ; Thu, 26 Apr 2018 23:38:39 +0200 (CEST) Received: by mail-it0-f43.google.com with SMTP id u62-v6so219899ita.5 for ; Thu, 26 Apr 2018 14:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xURMSZvR8+FceRYL2Vpl+/ySjLKyeSYuQ8/YT6cPeDs=; b=027Wc0iWSGUv702SU8idP2PhB+MZOpfZi3psiints5avKJXBT3g7uITZtlZBw/pQgR 4GtUoPR+7pySqOgMfneVr+eUVVudR2zbkfSVcFO0dTeUnlXR+ALx96OwUDQ8BF19DC4v L09dDNmwYAuT9QcZkfSvCZPF3bHtlZXAF2hrDsnEXpyLHTNe88h8xEm6P0ixfmWPeE46 RVOIL1NtYYt4dTlyU5aFyl0NGtXGrYXUOqjwVBc+QSJya1Bvbu+m2FHdNjNC15RTt6z4 orYmXF22QwAxrFe5BDxwSZzlLZKHK2+p6LdYEbehcWJWbQ1si/DlEB0WcCYBkYIhHrLk wTvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xURMSZvR8+FceRYL2Vpl+/ySjLKyeSYuQ8/YT6cPeDs=; b=YfCHpTqXGc4Pl4S0q1Ek0N6xo0RLkkCzTZUiEsN5x/7nvz5D7hkPEUqyQUjrW+PF57 esCRdyFjs62qjnb9wEN6Mp2PtWcCyzX61QEu5PHMcQnrwY3u97RWwBgKglJJKRCuCoX7 ZaRFH1hWa7oJ+Ruu0JRqD4pjrEUZCM3iit6nMt551kfeFyDB7AAz3B/e3FMVczILSunZ fhPXIfpf4MzoCQMdrhNuRpZMtGxqR2BHKeJxhyt18YEarmJKXe1fc8VWveAI4Eme4Pqv Wy8gYFeBqz9WFDLOS6dbHh2fLWO9RzpMdofOLPk2257aOBQscFixc5NQrhNnaPbB/k7D iPGQ== X-Gm-Message-State: ALQs6tBOD/4wHkpoepoCluJLV7CQzUT3BrKDHEaNaizIeVf1XwVZPNe5 Z2g8Y92T+kBDI5PM3B0SA8v5IIQHlmxrsJnwc85ERA== X-Google-Smtp-Source: AB8JxZqvXhhQoyJ/ZVrNStfe6FzJtDp8h8u4DE9XqtCehuKOYyyfQhwqJtWrZ0LvTENaRm3JRyHlRdgm+XmR0Vf/uIU= X-Received: by 2002:a24:7dcc:: with SMTP id b195-v6mr156534itc.149.1524778719094; Thu, 26 Apr 2018 14:38:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Thu, 26 Apr 2018 14:38:38 -0700 (PDT) In-Reply-To: <5d5955c2-dfa3-b795-9ae9-9359454adc7e@redhat.com> References: <1524663944-30376-11-git-send-email-arnon@qwilt.com> <1524723664-30510-1-git-send-email-arnon@qwilt.com> <1524723664-30510-9-git-send-email-arnon@qwilt.com> <5d5955c2-dfa3-b795-9ae9-9359454adc7e@redhat.com> From: Arnon Warshavsky Date: Fri, 27 Apr 2018 00:38:38 +0300 Message-ID: To: Kevin Traynor Cc: Thomas Monjalon , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v9 08/10] eal: replace rte_panic instances in ethdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 21:38:40 -0000 > > -void __rte_experimental > > +int __rte_experimental > > rte_eth_dev_owner_delete(const uint64_t owner_id) > > { > > uint16_t port_id; > > + int error; > > it's inconsistent that this function returns the error code from > rte_eth_dev_shared_data_prepare() and all these other functions return -1 > > > > > - rte_eth_dev_shared_data_prepare(); > > + error = rte_eth_dev_shared_data_prepare(); > > + if (error != 0) > > + return error; > > > Thanks Kevin, that's a valid point. Since the function itself returns either 0 or -1 I will align this one instance with the rest of the calls. thanks /Arnon