From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f53.google.com (mail-it0-f53.google.com [209.85.214.53]) by dpdk.org (Postfix) with ESMTP id A94ED8E74 for ; Fri, 27 Apr 2018 18:31:58 +0200 (CEST) Received: by mail-it0-f53.google.com with SMTP id 186-v6so2540101itu.0 for ; Fri, 27 Apr 2018 09:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=455xc+GOeU7OTkSjJJlaxh0nKyypeY1rP1Fy2BK7KDE=; b=gb2Lip8nhU4NPW3OHVtVjeu6Yf6u3ExGw1KX5XwcPOoECXKPaAUEVkMXZMYIH2HayI qKufnetgHalPR7j1HfFvcTgElbTMEYWA7QywQ0liJrsQK6kX/dO1RAaudYgBp9b3FI6j SJRj1TmLxxiD+nNdKiVXMUWkz7tPDObItxA+3PKUZub/AlktNB6ckO+0mNNz9h5k4ytO JJs7WExy7TpWqeR3oxyoOTFTEv/tmXimxAZoMVgO1ugHAv8kn/7iK+RrRpJx0t4jSSrv nI3beo46N1+oawmOdFppbX/AyKI7uBu40hEAHMzX6byT53XYOpL4S3H7SD1DC1UVGRhS ie+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=455xc+GOeU7OTkSjJJlaxh0nKyypeY1rP1Fy2BK7KDE=; b=aCoaVDDKDdsFxZ4OI2qkd9zTaX/jGmfFzzf60BDi6rAa1Dyuc5dmVL8Zv5IwM/meX0 E/+TO5KRnwYKF9UYa7YFj+upF9rY4gZROVMdejL2s2B66dKF9Z3LoORnFniarVR3hHnV KS3Me6Ucp3IUarBr67eWNqLHzAlpt7TsjEIexqdLSzIh78EsTxMcvnL+JXlx1JXz/OhO by+dctKgrUf6TZ2Mti18MYCnwMGqHee7osv3LcxoV0ErFbjBh6HUv7xYMXeVa8Wig1S2 PMiOU3GtrTivnskBmOtB35b3Q82uJCkAR5upGpsqjmyihi1EFyUqKpB6+BKMf1omGEYl YTug== X-Gm-Message-State: ALQs6tC3IVXifoJ8X/wYsd3APkOOwVdIby5Zdq/hyvpp4aFc41bfpo5G GtAage4YydbWsRnEzemjH6uq4v0cKrtDRfE3oU1zEg== X-Google-Smtp-Source: AB8JxZp/eiH0OnceEmwTSFfA96n2BQdXLn8wWL+iIgXqQdOgzJB8CEZ5y/ucLzI0a+yfPWB7K3GQtwfUsE2oDZ4V/3I= X-Received: by 2002:a24:8d85:: with SMTP id w127-v6mr2548088itd.22.1524846717975; Fri, 27 Apr 2018 09:31:57 -0700 (PDT) MIME-Version: 1.0 References: <1524663944-30376-11-git-send-email-arnon@qwilt.com> <1524723664-30510-1-git-send-email-arnon@qwilt.com> <2992884.f5kbt66Nfe@xps> In-Reply-To: <2992884.f5kbt66Nfe@xps> From: Arnon Warshavsky Date: Fri, 27 Apr 2018 16:31:47 +0000 Message-ID: To: Thomas Monjalon Cc: anatoly.burakov@intel.com, bruce.richardson@intel.com, declan.doherty@intel.com, dev@dpdk.org, ferruh.yigit@intel.com, jerin.jacob@caviumnetworks.com, wenzhuo.lu@intel.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v9 00/10] eal: replace calls to rte_panic and refrain from new instances X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 16:31:59 -0000 On Fri, Apr 27, 2018, 17:22 Thomas Monjalon wrote: > 26/04/2018 08:20, Arnon Warshavsky: > > The purpose of this patch series is to cleanup the library code > > from paths that end up aborting the process, > > and move to checking error values, in order to allow the running process > > perform an orderly teardown or other mitigation of the event. > > > > This patch modifies the majority of rte_panic calls > > under lib and drivers, and replaces them with a log message > > and an error return code according to context, > > that can be propagated up the call stack. > > > > - Focus was given to the dpdk initialization path > > - Some of the panic calls within drivers were left in place where > > the call is from within an interrupt or calls that are > > on the data path,where there is no simple applicative > > route to propagate the error to temination. > > These should be handled by the driver maintainers.. > > - local void functions with no api were changed to retrun a value > > where needed > > - No change took place in example and test files > > - No change took place for debug assertions calling panic > > - A new function was added to devtools/checkpatches.sh > > in order to prevent new additions of calls to rte_panic > > under lib and drivers. > > > > Keep calm and don't panic > > What is the status of this patchset? > It seems not ready for RC1 (today). > I don't want to push it in RC2 because it changes too many things. > So it's today or wait for 18.08. What do you think? > > The last patch for check tooling can be separated and pushed at anytime. > Yes,unfortunately its 18.08.I am away the entire weekend from any means of getting the code fixed, so only on Sunday I will split the last patch from the rest. Should I put the tooling patch as a new set and refer both patchsets to the current v9? > > >