From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f172.google.com (mail-io0-f172.google.com [209.85.223.172]) by dpdk.org (Postfix) with ESMTP id 9C27A8D3A for ; Fri, 20 Apr 2018 16:01:52 +0200 (CEST) Received: by mail-io0-f172.google.com with SMTP id s25-v6so4673944ioa.0 for ; Fri, 20 Apr 2018 07:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AeWyQMwTi5vdP5z6lUUB2YbJSDaCouBm1sgCEef7AtM=; b=wHyUx2JmKohzRa7QKuedPJlvCJ1Y851t5bqpiuJAmSjN9SFhriPF2/KmmdA0taY6sW lszShBafM7qmHaXJjZ+BPYEaaKZGpYqkz3hdnwpngA3Fk2lUxsUgV/r/5/KWJ0rBmeEH 8VVm7sYD4TI8BF2nf6/dkVJh4RrCOL5XlGMLcn3MrHEVuYdyzSzF9qkKz5ui+/KXjALX qtbFjQf/1M0Ewc9uU4oQOdcRMutLAapTgvc9e6IPoBieKayy+Bx0cj8ea75KqRtw6zQb iP/Dy70bPj53uFdlwfEu4ERTLK2DxxvtDoRcg9j5lfmRH0K59Vi7Yo/G9yOZ0UdG2qIn urLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AeWyQMwTi5vdP5z6lUUB2YbJSDaCouBm1sgCEef7AtM=; b=ZZpTwqN2LRoRlpJDi5kaD2I7vA3rbOV5yBe6TUNdjLXmusiosZcG0sgQq97QWdvRXE XfwW7P9R6bxhdCNjLVL+QyY98ECRs4qbjnBWM1b8wPMjFtnmK8BslTnq4SW5GYlUrLnp T7OFuV6u6EicI3ciempNGrMYBWobPyyMwKB5bvaRgBpvXbjXeOYClIJBRYKMkLzCPyJB ii9PDWIlXAp3LagkKsa3wgjNy++nemw8ROrZHu583nf30+lEUBwLQXW8YQDwmyzfoXfu 43DqsuWIfnzQAGDc/aMHK4cMLh8jnQf9TwGATr66lIVzZ51wFmUy7To9vtqLtaXKTUew 4JpA== X-Gm-Message-State: ALQs6tDAK7fAoday8sz4P17SP6p9eLYbv5MfjozlAMdAHAd354oiz39S cU/BdL1P7Ah5pOej+BSLoAONdA89J5VxTdt4IKpTTAw5 X-Google-Smtp-Source: AIpwx4+OHMEnOHQ6vPThaKxin4agiPZcOVvY71h28FrR8uu8AwF4n9uSSl3iwM1Y7m7gkyRoUtsjsBtPXW0ZbOX9174= X-Received: by 2002:a6b:a89b:: with SMTP id e27-v6mr10250190ioj.180.1524232910836; Fri, 20 Apr 2018 07:01:50 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Fri, 20 Apr 2018 07:01:50 -0700 (PDT) In-Reply-To: References: <1524117669-25729-1-git-send-email-arnon@qwilt.com> <1524117669-25729-12-git-send-email-arnon@qwilt.com> From: Arnon Warshavsky Date: Fri, 20 Apr 2018 17:01:50 +0300 Message-ID: To: Aaron Conole Cc: Thomas Monjalon , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 11/11] devtools: prevent new instances of rte_panic and rte_exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2018 14:01:52 -0000 > > I don't think rte_panic should be considered forbidden. Rather their > use should be flagged (as this patch does). However, the 'exit 1' > (which will return a failure for the automatic checkpatch script bot) > might end up problematic as maintainers might consider it a patch that > is not ready. > > I wouldn't object to this patch, but just think you might want to change > the print to something like: > > WARN: Are you sure you meant to use "$expression"? > I can definitely change the warning text , but I think the whole point is actually to prevent future panic calls. If it were a recommendation, one can never converge with the attempt to get rid of them, as not throwing a panic is a lot harder. Thanks Arnon