From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arnon@qwilt.com>
Received: from mail-it0-f48.google.com (mail-it0-f48.google.com
 [209.85.214.48]) by dpdk.org (Postfix) with ESMTP id EDAEF8E59
 for <dev@dpdk.org>; Fri, 20 Apr 2018 15:16:44 +0200 (CEST)
Received: by mail-it0-f48.google.com with SMTP id 85-v6so2438115iti.4
 for <dev@dpdk.org>; Fri, 20 Apr 2018 06:16:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=qwilt-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=4AOj0mY1zPFuEaXx6COvpW5Ut1m1usRxO32MxqKo2Vk=;
 b=HV0Ov89Ve9ZwxSFr/I1cCX9iEzpZxnDVnVbY1m0ryIHTTChHnqJDcZBMUAFJoF5AHa
 +gqXaC/s8eFF3JQGc1FWmvSxtDeWTC8v3giWZQrK8w3DcCozmfLB9qGAbdIKej6gMH1g
 8rCUj9JJxegFX6b85e2pu6R1/dj480XJihq9kv1Rny0olgY8UUGlvzqxgdq5OvUCUHPE
 ZRKlQS2W/CUxq/a6eTwfQ1fFR6kKy7zDbsHmRx/Pc3pJOgK8O59xZaYye0iGmxnG5xFM
 CuVSuzP1sV1beCXpagDAGb7i8/zwBT5m60hlVtGoWawAYb53IkdMQwfgFnKD7mpy8qAB
 GmGQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=4AOj0mY1zPFuEaXx6COvpW5Ut1m1usRxO32MxqKo2Vk=;
 b=OWhs7tDgs/LpLaxK7RkPhkC7SNe7NRz8wKcXroZVSI34haSKHZdeExidj56qR31ZQ6
 NhKTPdG56cLtxrNON0Fz/XScjw6JwCX6BjNGRUZ9X8J67IhtzZ5BA3LhDLpTKTaR7wxV
 XUCYqcNI0C45w7QdvZ2qmc79/XOwOUiDsURf5CAw2zmsFSKWeNHotLuKYKx4LjgUUwKF
 IvlyQwAlwpHyMrKghJ7N3rL8fLPI5vf1oxCqdu2MJUOnk/s4kgY/UbOq883EOG2GddhP
 eIILdXEpNZ1p1iD5hmbYQojJHtZBZfrmScQbFLUQuD/vgAeVxIVr3t+tLVpOESNbvsgP
 8sDQ==
X-Gm-Message-State: ALQs6tDd2t9o9PZ36TN2RIpYdSoXag2K8GPGUcnQZX6igtfvLHwSPww5
 9czCGAjVZAasp8UQpVYivhzXDWuuJSdpmy15NpPA/rub
X-Google-Smtp-Source: AIpwx4/dvXZr4KC+TWjfvVQYDqp8alIJETXfRknK4bA7FxOnHSAADpPJpPfkqwDWuyvVt7DN4m26wwKFdiy1tCDTDiY=
X-Received: by 2002:a24:8d85:: with SMTP id
 w127-v6mr1238286itd.22.1524230204100; 
 Fri, 20 Apr 2018 06:16:44 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.142.145 with HTTP; Fri, 20 Apr 2018 06:16:43 -0700 (PDT)
In-Reply-To: <9150e0ac-5ec5-e40d-1304-124644d67d67@redhat.com>
References: <1524117669-25729-1-git-send-email-arnon@qwilt.com>
 <1524117669-25729-5-git-send-email-arnon@qwilt.com>
 <9150e0ac-5ec5-e40d-1304-124644d67d67@redhat.com>
From: Arnon Warshavsky <arnon@qwilt.com>
Date: Fri, 20 Apr 2018 16:16:43 +0300
Message-ID: <CAKy9EB2W5SSS=3V36upAJH0dC8ft_zbhaNru0iqaW0FgOAvBVA@mail.gmail.com>
To: Kevin Traynor <ktraynor@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, "Burakov,
 Anatoly" <anatoly.burakov@intel.com>, 
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Doherty,
 Declan" <declan.doherty@intel.com>, 
 jerin.jacob@caviumnetworks.com, Bruce Richardson <bruce.richardson@intel.com>, 
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, dev@dpdk.org
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v4 04/11] ixgbe: replace rte_panic instances
 in ixgbe driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2018 13:16:45 -0000

> On 04/19/2018 07:01 AM, Arnon Warshavsky wrote:
> > replace panic calls with log and retrun value.
>
> typo return, seems to be in a few commit msgs
>

Yup. They were not even copy pasted so at least I am consistent :)


> +             return -1;
>
> similar comment as previous patch about using an appropriate return value
>

And those

Thanks