From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f176.google.com (mail-io0-f176.google.com [209.85.223.176]) by dpdk.org (Postfix) with ESMTP id 78B7F325F for ; Wed, 7 Mar 2018 12:02:31 +0100 (CET) Received: by mail-io0-f176.google.com with SMTP id d71so2586470iog.4 for ; Wed, 07 Mar 2018 03:02:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GiYsnPXUvElVl7L6VJVN6rcZ4ow1r3DC2VTAdaU7C10=; b=gY64TwSinn4cwqdBuX29YES8bJ3cz0R2nEbyAKcOOqbKLC7zeCHPd2qMcZqLHzypgk 9TAdsvsfSIF9NBNiLtaLObfgu+18NaKWvKjtKmVEJlBghKfp7UX/BzhzBhQP4Vn21k8T gDWoAAldu0PrZ5Gu2jL65OuFjP/ugkuQ8I2o9aLjusmPmLBuDfreSH7PzsBpuKJVOJx1 uuTsDvIF/8MBZ2INCsd5DaQQX3Do3JTqbr1NZynJs+vT/EKgmDf5Lyw8RmMcNSPX1K5+ j0rYK67aZElA3KCiGR4g6elr+HiUvtY3wOcaQrKmnq+/LnoFMmbI/TFYmd684Nr9YAuz UcSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GiYsnPXUvElVl7L6VJVN6rcZ4ow1r3DC2VTAdaU7C10=; b=aTc0GESrcf0kUSagHmjisyEt6zvB4ZvKm750TAlrUkd+uXEYdstJ4RAJCf7BBI72tn cX393hHYM1QOgGrEgVI/1GaKGgCx29qwgempXTOVDwNXN60uL1wC+7V2b+a8BRIOdyIR +LORk6nMMFDWNkZ4w0kvTdqKD9Fuc9Wt4nzZYdzmrbKsSOKqXLYyvgEzgZgQrn3cAYmR 4EVJgfXJDmn2oML3UP+wTsmkXqE2hVT3lbsaGlluZvhL9MCeVRSuaZde6fJwCiDdrdZ5 BCW0QfkDxo9Si5n3xceyCmomn9vqoM5/sLfaLrj1I2zohFTiUndf9+6PQpPrtNLobJN9 CWaQ== X-Gm-Message-State: AElRT7Gb2S6in05vY0HuL/ISvPUD1mZ2FwnZD3z5JKzkq8v1ro0OaLt/ hgHLvUo8jbA4iMItLVcuVEV1jN6vi7ATozx4gCEcdA== X-Google-Smtp-Source: AG47ELuq/MuLBLxC64jEkwqYdSZj4Gguwj3qDT4v9Hps1w2ryyTLaqo3b2I4OZax6jva0VxZbSNt9BZGu/9QD4k/75c= X-Received: by 10.107.52.146 with SMTP id b140mr16182827ioa.8.1520420550746; Wed, 07 Mar 2018 03:02:30 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.20 with HTTP; Wed, 7 Mar 2018 03:02:30 -0800 (PST) In-Reply-To: <4197355.YAsZy1EAlL@xps> References: <1520360928-9375-1-git-send-email-arnon@qwilt.com> <304114136.g7uiPYdxRp@xps> <4197355.YAsZy1EAlL@xps> From: Arnon Warshavsky Date: Wed, 7 Mar 2018 13:02:30 +0200 Message-ID: To: Thomas Monjalon Cc: "Burakov, Anatoly" , Bruce Richardson , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] eal: register rte_panic user callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 11:02:31 -0000 > > Can this really go into current release without deprecation notices? > > If such an exception is done, it must be approved by the technical board. > We need to check few criterias: > - which functions need to be changed > - how the application is impacted > - what is the urgency > > If a panic is removed and the application is not already checking some > error code, the execution will continue without considering the error. > > Some rte_panic could be probably removed without any impact on > applications. > Some rte_panic could wait for 18.08 with a notice in 18.05. > If some rte_panic cannot wait, it must be discussed specifically. > Every panic removal must be handled all the way up in all call paths. If not all instances can be removed at once in 18.05 (which seems to be the case) maybe we should keep the callback patch until all the remains are gone.