From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f52.google.com (mail-it0-f52.google.com [209.85.214.52]) by dpdk.org (Postfix) with ESMTP id EBC1ED148 for ; Fri, 20 Apr 2018 15:32:37 +0200 (CEST) Received: by mail-it0-f52.google.com with SMTP id 71-v6so2496074ith.2 for ; Fri, 20 Apr 2018 06:32:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=sfpxWsTwn31GYztdO8XmoNV8v8cFB5B8Zoxe5Ud+J5o=; b=t0kXbS8KWsC0fMu9LSShQPKVSxLkEJHz3kk8YEzofk+KjmWwXGFKjXqtj0bMyeLtxz qvx2aoBYQJ8YseQ9f3dp5BxygTOnH30l77ZBykpBotMNAj1YhMb+HSdmkG7Pa0KnZ8Ou Q77wqWx3l/vVHcfUpnZJts+Te99iiVRH5f+UKslOpwf3BzLsU2X0BVzCyO2lXLtYa+Vf ui/xzkhOzJhEj+b29Ya/AIdaEdu+4e7TUfW/qFigz/yLcglf3bxuPHM9kPH9NwAMxD1j L70U7ON99ZDgcsOyWUhgRakSP1h/96ijbqJaIU8yyR1GouF4w1HWfdcISNX6Izwe1sgZ CQOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=sfpxWsTwn31GYztdO8XmoNV8v8cFB5B8Zoxe5Ud+J5o=; b=aL/zgQOdMEe1zOV8xYoUQiuNDXQkoPFtMJzDoZr96/f6h7P2JoqhFMcdpmY5S6xMJy vUJsyroII857zGqsYNGg96K4dHVj/p6xOKf72lOZR/Uri9gNt5V2KLU+RTvR3m8muB80 ctRSdIazDf3Zpuz4Ztoi2FwxRQLt0oei9qqnSlO22efuFNm6jt/NTglAdSr46HmBVsvn 7QVTYzBAA4xaWF0y0dOffsuthW66J1bdwtoleFsg+jnBg0mdDwAQmoqcpCHTKE04j5RI LoGkdFGti5BVFCLaghUFguNlRttBLuXu8V+CU7ojBh70ckzs+uP2knef0k7B9WMmiuvl Uq9A== X-Gm-Message-State: ALQs6tDvNdGOlIaNxDfC9J7dG1I0+1tXZszPKfiAg9BSWY45KXx5L+TX DjRFwpgku3zgBgYcK3JjIIxiSyANJdFwEbVyOmAGMg== X-Google-Smtp-Source: AIpwx487p84DT43V7+1WmDwv6FCTW3qQTFsfllcQ3KI4EYzJB12hCf4VQMnDCntXirh1o0IJeo70ueJ5Nyoq2Cva4Uk= X-Received: by 2002:a24:24ce:: with SMTP id f197-v6mr3099383ita.25.1524231157025; Fri, 20 Apr 2018 06:32:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Fri, 20 Apr 2018 06:32:36 -0700 (PDT) In-Reply-To: References: <1524117669-25729-1-git-send-email-arnon@qwilt.com> <1524117669-25729-11-git-send-email-arnon@qwilt.com> <93afdd1b-b108-9986-5fbe-7d3aacc92ca3@intel.com> From: Arnon Warshavsky Date: Fri, 20 Apr 2018 16:32:36 +0300 Message-ID: To: Kevin Traynor Cc: "Burakov, Anatoly" , Thomas Monjalon , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 10/11] eal: replace rte_panic instances in init sequence X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Apr 2018 13:32:38 -0000 Agree. As I wrote below - I will put this instance back in place for this patchset and handle it on a different one On Thu, Apr 19, 2018 at 8:31 PM, Kevin Traynor wrote: > On 04/19/2018 03:57 PM, Burakov, Anatoly wrote: > > On 19-Apr-18 3:48 PM, Arnon Warshavsky wrote: > >> Copy on the commit message and volatile. > >> > >> Regarding the new function defunct_and_remain_in_endless_loop () > >> I don't think I can put that in a separate patch without breaking the > >> current patch independence. > > > > How so? > > > > Just leave some panic instances in there for thread-related stuff and > > fix them up in the next patch. > > > > Also, i'm not sure sending threads into an infinite loop on panic is > > such a good idea. You might want to look at Olivier's approach [1] to > > creating threads, using pthread_barriers and pthread_kill/cancel. > > > > I haven't reviewed this one yet, but going into an infinite loop doesn't > seem like the right thing to do. > > > This does warrant a separate patch now :) > > > > -- *Arnon Warshavsky* *Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon@qwilt.com *