From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f47.google.com (mail-it0-f47.google.com [209.85.214.47]) by dpdk.org (Postfix) with ESMTP id D18247EE0 for ; Thu, 26 Apr 2018 23:57:57 +0200 (CEST) Received: by mail-it0-f47.google.com with SMTP id m134-v6so267833itb.3 for ; Thu, 26 Apr 2018 14:57:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=F4YBJR8BvV7eEGNLFWuCr9vPGFMu6oe1axr9zEkOy4Y=; b=kTz0gEGOBfu6vgvJqF80z2H/SIO73fVEqID2lgzCgVaHvvKxBLwQAFgoyu+qqpRQxE UXwZeIF9yBcTnLVH8G/sT7XnkMcZIHlujEwp4vxg3AcMIyP5FXkVl5Dau4UEYOPx7Mt3 32/flu9jnmOpXPrt4thuQAxZ7I/1vKfbq5m3/rQ438SgZWXtwiKyhS2c0GeLWF/uYR4I T52Osvlnsngb3FDbCutytHtmtnLHpXl4DM04KvChqpoBtvdXW0qaOC5z0dTydWyjqtxi Z4igL/4Fl/MsVJhnnrExDLBFBn0s6szyuFj+XtDAaIgK/WJvKMNFGeRANoZA596trrf5 glOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=F4YBJR8BvV7eEGNLFWuCr9vPGFMu6oe1axr9zEkOy4Y=; b=QG25IKGWsufeEJsNvps8WwPAiFtbAxfavUXjz+/sN3pa0gWXzTv8ZuSnVidClSoZdP a9b7KEQQGiSFnGki08O2PRn+GwBtOnqV10mw4WFbHyMipCxNwn9FYV7xEZC/dj5VVLtm BbldPmpz98Gkq8M7rMiSI2keIaqBk/7uc+AIk82DShIsfiV2vyL6kX0dxNrxVZnqIoaw RZIOXzg/f5gdG0QJknPFQeXIrdo/EflflnAd/3aYq32OvyK9Gg5/B+61O0A7XrJ1FyqP tmC+7FLh3bB0dKTJVNqK7fIYmM+/bcKQ76svguxTqs9nbARwoWK8rWj2qyLySrAUQ7o+ DZJw== X-Gm-Message-State: ALQs6tAunCjUeuZ0CLyr0UPOelrUlei1dDsRBcJ0WraFMzs4hk5iWkjn 7om6ANB7V840gXNN52QfYtxH4VQg9vmHKcNsPPibvA== X-Google-Smtp-Source: AB8JxZpjkbeVFE3wzZM9VsfNJBdF9uwnKkks9Sm9HN4Air37Tkd97VfeDTEZunuc1Gglx6rXRZPiNS1KAyLpiPRRIfA= X-Received: by 2002:a24:8d85:: with SMTP id w127-v6mr240641itd.22.1524779877178; Thu, 26 Apr 2018 14:57:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Thu, 26 Apr 2018 14:57:56 -0700 (PDT) In-Reply-To: <22f61f91-9755-520c-9ba1-d93a312a43e3@redhat.com> References: <1524663944-30376-11-git-send-email-arnon@qwilt.com> <1524723664-30510-1-git-send-email-arnon@qwilt.com> <1524723664-30510-11-git-send-email-arnon@qwilt.com> <22f61f91-9755-520c-9ba1-d93a312a43e3@redhat.com> From: Arnon Warshavsky Date: Fri, 27 Apr 2018 00:57:56 +0300 Message-ID: To: Kevin Traynor Cc: Thomas Monjalon , "Burakov, Anatoly" , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v9 10/10] devtools: prevent new instances of rte_panic and rte_exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Apr 2018 21:57:58 -0000 On Thu, Apr 26, 2018 at 7:08 PM, Kevin Traynor wrote: > I think the first line of the commit msg ^^^ should change as it no > longer prevents but just warns > > Actually the return value did not change, only the warning text did. I would rather keep the word 'prevents' as an intention declaration that puts the fact that a panic is undesired first, and the technical ability of a maintainer to allow it second. This is just in terms of how one positions the usage of panic. > > > > Seems to drop the patch name if it finds a match Not sure I understand what you meant here. Can you please elaborate? Thanks /Arnon