From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f48.google.com (mail-it0-f48.google.com [209.85.214.48]) by dpdk.org (Postfix) with ESMTP id 2AC997CEE for ; Thu, 19 Apr 2018 16:09:05 +0200 (CEST) Received: by mail-it0-f48.google.com with SMTP id h143-v6so7173334ita.4 for ; Thu, 19 Apr 2018 07:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qwilt-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zCsjwKHIV8hfx4iXFqoqtBRqJ9hniAbg7i7xc7vjF3A=; b=IzoutJRlnLD8MrgN/TCDDdG9k8a/666YGrVl8M+MwBzGIX5EfNAv5wyf/rdLqxVoMk PxTnNLuK2M2thPOcJ3mD9nj2QqVjyneFiGtgD2AyaWAJkPdX6E83fbhGh5PEbMkab1s/ 6+ghWd4l/EyCqez3qwD3DrXS6bYL1YIe0Gg1sY4eWYL3PqKi4e52fMzj3whJQ0+BsOvG csAQWAnF1GQGbazfBINKULZn8TwxBZs4RnZDId5o33/Q8sLIQQVMgNdLj25DM99flgjL Mou/qRAimusBbmAV/DglZg+ueCAl/rlJfsJ3ikdfdv+Gpn56aRBxGeVGxx8hPxkUlVQ1 Iccw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zCsjwKHIV8hfx4iXFqoqtBRqJ9hniAbg7i7xc7vjF3A=; b=Aew1WcHKZvgqan5FDmujt6b7/1bFW07heZEtB+bUsuEjoaV7ZqnQ0RMwK3+nZMT0xB U5i05SLEon/kZCeXIjCwJeKsNz3WwYib1Aait2pfwPIVM72XrTnIwduugJmZsfpYl24g J4egjbIFqWb3UMqF9X708Hx7/F8e86EhnYM8SniNa0wy2xhpq5ylnlDC+33f0aWE6XIW uCcl3V3A19jSEdgnzgsbBIV+ZE3wMcWTaw3MzDmwU0mLu0ql+t9jZvUKMTCr/ycK2/dt XabG1dChaDs57cEKLgPHt3e8y3Qucg322GneEw1W4myOwGK0uE/C8qppYPhmN3qwIaAp +rJg== X-Gm-Message-State: ALQs6tB2C0yPloqeMqXQKqfJac/wsvpBVRbTFrEqEtyL4jwxk4ogPbQH 4+uZ8PW9/yLMHQjrxWzy/UExlEQ8Ln1SJNzmj0ZDmg== X-Google-Smtp-Source: AIpwx4/Sos8rSfaaGN0vnpp3hbU8tJsXRtQirY+i4Znr1dxPRQ60EWV64hZLfIGsXe6RemTLARdpSlhIVyqT/XmFoTg= X-Received: by 2002:a24:86c4:: with SMTP id u187-v6mr6743781itd.138.1524146944298; Thu, 19 Apr 2018 07:09:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.142.145 with HTTP; Thu, 19 Apr 2018 07:09:03 -0700 (PDT) In-Reply-To: <9d631c8a-5ec6-aae1-9f5d-0c890dfb1c19@intel.com> References: <1524117669-25729-1-git-send-email-arnon@qwilt.com> <1524117669-25729-8-git-send-email-arnon@qwilt.com> <9d631c8a-5ec6-aae1-9f5d-0c890dfb1c19@intel.com> From: Arnon Warshavsky Date: Thu, 19 Apr 2018 17:09:03 +0300 Message-ID: To: "Burakov, Anatoly" Cc: Thomas Monjalon , "Lu, Wenzhuo" , "Doherty, Declan" , jerin.jacob@caviumnetworks.com, Bruce Richardson , "Yigit, Ferruh" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 07/11] eal: replace rte_panic instances in hugepage_info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 14:09:05 -0000 Thanks Anatoly. Will fix that in v5. Is it preferred to keep all version notes in the cover letter alone? On Thu, Apr 19, 2018 at 5:03 PM, Burakov, Anatoly wrote: > On 19-Apr-18 7:01 AM, Arnon Warshavsky wrote: > >> replace panic calls with log and retrun value. >> > > typo: return > > >> v4 >> static size calculation function changed to return success/fail code >> in addition to filling the size result. >> >> Signed-off-by: Arnon Warshavsky >> --- >> > > Please do not add version notes to commit message. You might want to use > "git notes add" for this, or manually edit the patch and add notes after > "---" before sending. > > On patch contents, > > Acked-by: Anatoly Burakov > > -- > Thanks, > Anatoly > -- *Arnon Warshavsky* *Qwilt | work: +972-72-2221634 | mobile: +972-50-8583058 | arnon@qwilt.com *