From: Nikolay Nikolaev <nicknickolaev@gmail.com>
To: maxime.coquelin@redhat.com, Ilya Maximets <i.maximets@samsung.com>
Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 0/5] vhost_user.c code cleanup
Date: Wed, 12 Sep 2018 18:34:27 +0300 [thread overview]
Message-ID: <CAL7hd5KjpXYZTfUSqgG0bs3eQGiDiKrrmVAQ6f3CyUAzgHC6sg@mail.gmail.com> (raw)
In-Reply-To: <952f7763-205c-12d8-10c9-c24ddd57dfbf@redhat.com>
Hello Maxime,
I'll rebase and fix Ilya's comments. Thanks for the reviews.
regards,
Nikolay Nikolaev
On Tue, Sep 11, 2018 at 12:38 PM Maxime Coquelin <maxime.coquelin@redhat.com>
wrote:
> Hi Nikolay,
>
> On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote:
> > vhost: vhost_user.c code cleanup
> >
> > This patchesries introduce a set of code redesigns in vhost_user.c.
> >
> > The goal is to unify and simplify vhost-user message handling. The
> > patches do not intend to introduce any functional changes.
> >
> > v2 changes:
> > - Fix the comments by Tiwei Bie
> > - Keep the old behavior
> > - Fall through when the callback returns VH_RESULT_ERR
> > - Fall through if the request is out of range
> >
> > ---
> >
> > Nikolay Nikolaev (5):
> > vhost: unify VhostUserMsg usage
> > vhost: make message handling functions prepare the reply
> > vhost: handle unsupported message types in functions
> > vhost: unify message handling function signature
> > vhost: message handling implemented as a callback array
> >
> >
> > lib/librte_vhost/vhost_user.c | 392
> ++++++++++++++++++++++-------------------
> > 1 file changed, 208 insertions(+), 184 deletions(-)
> >
> > --
> > Signature
> >
>
> Could you please rebase and fix the series (see Iliya comments) on top
> of git://dpdk.org/next/dpdk-next-virtio master branch?
>
> Thanks,
> Maxime
>
prev parent reply other threads:[~2018-09-12 15:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 19:13 Nikolay Nikolaev
2018-07-19 19:13 ` [dpdk-dev] [PATCH v2 1/5] vhost: unify VhostUserMsg usage Nikolay Nikolaev
2018-09-10 15:04 ` Maxime Coquelin
2018-07-19 19:13 ` [dpdk-dev] [PATCH v2 2/5] vhost: make message handling functions prepare the reply Nikolay Nikolaev
2018-09-10 15:08 ` Maxime Coquelin
2018-07-19 19:13 ` [dpdk-dev] [PATCH v2 3/5] vhost: handle unsupported message types in functions Nikolay Nikolaev
2018-09-10 15:15 ` Maxime Coquelin
2018-07-19 19:13 ` [dpdk-dev] [PATCH v2 4/5] vhost: unify message handling function signature Nikolay Nikolaev
2018-09-10 15:24 ` Maxime Coquelin
2018-07-19 19:13 ` [dpdk-dev] [PATCH v2 5/5] vhost: message handling implemented as a callback array Nikolay Nikolaev
2018-09-10 15:32 ` Maxime Coquelin
2018-09-10 16:09 ` Ilya Maximets
2018-09-10 16:43 ` Maxime Coquelin
2018-09-11 1:51 ` Tiwei Bie
2018-09-11 9:38 ` [dpdk-dev] [PATCH v2 0/5] vhost_user.c code cleanup Maxime Coquelin
2018-09-12 15:34 ` Nikolay Nikolaev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL7hd5KjpXYZTfUSqgG0bs3eQGiDiKrrmVAQ6f3CyUAzgHC6sg@mail.gmail.com \
--to=nicknickolaev@gmail.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).