From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by dpdk.org (Postfix) with ESMTP id B7F274C95 for ; Wed, 12 Sep 2018 17:35:04 +0200 (CEST) Received: by mail-io1-f52.google.com with SMTP id y10-v6so520822ioa.10 for ; Wed, 12 Sep 2018 08:35:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=07FRncT6yHV0hkquLsg1d+JpMlkV0iHiBFxWsYad49M=; b=uP+3frDjShll+TiBbdeBPaQFwrSa1WSoQvyvkAl71CJxSzk9cj5p/mu5m762z0N+yS r8yPJiSk8e6QQtHJzWqsql8E+c7IBCZBi4BWDBbXYQdkbaJHRlfQkoP3vWSe6JFmY7f0 5gFFHVI64mE4e2q1+YMfgpyK6QnXh4OxoIfuLj/stgKBOVfGnqt/fHwGAczHo0Z2dPWO nS6wHxNgj9ZM5F1tzDghsqucwrshrZYW2UMctVQOIlnqMeMzoY/ei13WM4BM3q7k76/7 1h9IQOPSHm0E9hz0ufZUWO/wSmUrvQ5B4uptmgTBmAMMfHCN25WBCZ1F6juP8L7p4Sk9 mFcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=07FRncT6yHV0hkquLsg1d+JpMlkV0iHiBFxWsYad49M=; b=XMv+EIUwbYhWFOPKpZn72H8I1K9cCpYan9h8p7k5JvqkHoTFTVAmosHaaybVkrRWpj prOYR9PXa3hNxOSitXPeA2K0K13AMqa+xXfpemhwMkSSuSUCncGGUDPbnjO/hEnkvmYC Uzyi/5D4fOPJpdvkRAkUD9qOHheRJpd+evVGCapGY5z5CH4D2bzWRjHgLSW/dqPa+8v3 kcrlx6ANXG6GvmKimkns3g7KE5Odrur7OOvTFUOHUIRNdJkQ4yEmPwK7FSrnAxLdJ4Wb sf2DI2P8uKiK9LM0txRqGznpgH6giiNEl4AugPqNS8OKvYZhH/kEBnEheEl1Xm3Ynr/l djkQ== X-Gm-Message-State: APzg51AP16nEosivjduJyIhmeY8u9NZUoxKej7Y8Z60sCwUaZy7JQd1z POWePR9YSw4J+2i48ui91kklJHaxTDcT9u9QVv4= X-Google-Smtp-Source: ANB0Vdb+RIexnf72jQA0ZSFNf7Dr4uNZ+Fwng7yD6X125JJP2fhg82y7hew50evBre1OJOZoOD6QiWzI+J8PBZxx8Tk= X-Received: by 2002:a6b:6209:: with SMTP id f9-v6mr2207636iog.11.1536766503983; Wed, 12 Sep 2018 08:35:03 -0700 (PDT) MIME-Version: 1.0 References: <153202755842.21481.1772155561595981441.stgit@T460> <952f7763-205c-12d8-10c9-c24ddd57dfbf@redhat.com> In-Reply-To: <952f7763-205c-12d8-10c9-c24ddd57dfbf@redhat.com> From: Nikolay Nikolaev Date: Wed, 12 Sep 2018 18:34:27 +0300 Message-ID: To: maxime.coquelin@redhat.com, Ilya Maximets Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 0/5] vhost_user.c code cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2018 15:35:05 -0000 Hello Maxime, I'll rebase and fix Ilya's comments. Thanks for the reviews. regards, Nikolay Nikolaev On Tue, Sep 11, 2018 at 12:38 PM Maxime Coquelin wrote: > Hi Nikolay, > > On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: > > vhost: vhost_user.c code cleanup > > > > This patchesries introduce a set of code redesigns in vhost_user.c. > > > > The goal is to unify and simplify vhost-user message handling. The > > patches do not intend to introduce any functional changes. > > > > v2 changes: > > - Fix the comments by Tiwei Bie > > - Keep the old behavior > > - Fall through when the callback returns VH_RESULT_ERR > > - Fall through if the request is out of range > > > > --- > > > > Nikolay Nikolaev (5): > > vhost: unify VhostUserMsg usage > > vhost: make message handling functions prepare the reply > > vhost: handle unsupported message types in functions > > vhost: unify message handling function signature > > vhost: message handling implemented as a callback array > > > > > > lib/librte_vhost/vhost_user.c | 392 > ++++++++++++++++++++++------------------- > > 1 file changed, 208 insertions(+), 184 deletions(-) > > > > -- > > Signature > > > > Could you please rebase and fix the series (see Iliya comments) on top > of git://dpdk.org/next/dpdk-next-virtio master branch? > > Thanks, > Maxime >