From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41751A00C3; Mon, 19 Sep 2022 18:56:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D594640E0F; Mon, 19 Sep 2022 18:56:42 +0200 (CEST) Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by mails.dpdk.org (Postfix) with ESMTP id 3923640141 for ; Mon, 19 Sep 2022 18:56:41 +0200 (CEST) Received: by mail-qt1-f171.google.com with SMTP id b23so16109604qtr.13 for ; Mon, 19 Sep 2022 09:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=9wX6CCwJZcdihLQ9WX7v9akV2Y5pICyRvtA6Aqm0xxA=; b=gzQqWHLc86qt+in8tqw1cAuLHpAhZbPgArnfnUprZ2wCo0TR0JOrWQeaAy5o12aVj9 Kxh7/gGGMD9fLILnXEcJr2ri9HggB2N0gUBDfYDUCeDNsjoe/GKczwt7i3/cIT21aKTs hpOYJ5VDrtuIGfOEFG8Lc0xaln74GMkcr1FU4QM+gqSHxOZJ6G7VYaGQV6PvJCwmEUnJ JrV0aDvfEum+NIz2Ip1xHy3TrvU+8hYJRmMPKACTmkXyXP5JDS8FFN6r5qnKrRsbVB6P GHeJt4kg+i4Xb8RNZ5O+ucQlrbW7/YcUuNVI//L8F/ho0qyCuRL+RwO8FzSKLi0786gV 2ubw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=9wX6CCwJZcdihLQ9WX7v9akV2Y5pICyRvtA6Aqm0xxA=; b=F3ibeyUAO+v2bs0MT9FGbH9mBJHCJdp0fwVeN/wNUPnAcM+pnlvoR8+JkHv4b7HmBj 8XQ6bY4/lJAx3qLEbvf5ju9ggC6OMlLEJQdPYALTEHfD4QC1Aa3nPA8z6XBp/Mv4opKK FXTyu5TL8442VUUp9OcrnGzyrwb8ip3V6itPLCRVagEakJDoQZOdFHTKjTXBlPAY8oxN jhnIFs+Qfgvf09if+kF7OcH0bqoB7Y96u/mrXUk5uNBPA9fZ1fB23yywY66ZA21WbF7H WbUdhnOMYYxP5wQphXsezM56i0luVXm4lMisyylgsfNu09ZS6TvEKvqaogHd0dScVHIW dJ1A== X-Gm-Message-State: ACrzQf0KUM3NG2IYj0EDoGIm1V98b/ZXLdAxZ31qb04w7tmGd2dOtE/w yxP6bQ1IH6J6KDZ6Ne/axYHkmPJ0xCYjucOVH6Dt/d9KS2mdwQ== X-Google-Smtp-Source: AMsMyM7yCQ2cILQ8cB1V1zH71dP5yMPy2um1CqLATYQ4j24zWWitG1+Xp/gq5h8aMJiXuFofxc0teGyLQWB2lVWSVOs= X-Received: by 2002:ac8:5ccd:0:b0:35c:e18b:2be3 with SMTP id s13-20020ac85ccd000000b0035ce18b2be3mr7813390qta.502.1663606600477; Mon, 19 Sep 2022 09:56:40 -0700 (PDT) MIME-Version: 1.0 References: <20220901061606.2507989-1-hpothula@marvell.com> In-Reply-To: <20220901061606.2507989-1-hpothula@marvell.com> From: Jerin Jacob Date: Mon, 19 Sep 2022 22:26:14 +0530 Message-ID: Subject: Re: [PATCH v1 1/1] net/cnxk: resolve fail to set large Rx/Tx queues To: Hanumanth Pothula Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dev@dpdk.org, jerinj@marvell.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 1, 2022 at 11:46 AM Hanumanth Pothula wrote: > > While configuring NIX, local variables 'nb_rxq' and 'nb_txq' > are declared as 8bit variables, leading to an integer overflow > when an application sends Rxq/Txq value greater than 255. > > Hence, declare local variables, 'nb_rxq' and 'nb_txq' as 16bit > variable. > Also, during the cleanup, make sure PFC tree is not created. > > Signed-off-by: Hanumanth Pothula Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/net/cnxk/cnxk_ethdev.c | 2 +- > drivers/net/cnxk/cnxk_ethdev_ops.c | 6 ++++-- > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c > index cfcc4df916..c0a8e901a3 100644 > --- a/drivers/net/cnxk/cnxk_ethdev.c > +++ b/drivers/net/cnxk/cnxk_ethdev.c > @@ -1074,7 +1074,7 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev) > struct roc_nix_fc_cfg fc_cfg = {0}; > struct roc_nix *nix = &dev->nix; > struct rte_ether_addr *ea; > - uint8_t nb_rxq, nb_txq; > + uint16_t nb_rxq, nb_txq; > uint64_t rx_cfg; > void *qs; > int rc; > diff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_ethdev_ops.c > index 1592971073..b417d61771 100644 > --- a/drivers/net/cnxk/cnxk_ethdev_ops.c > +++ b/drivers/net/cnxk/cnxk_ethdev_ops.c > @@ -1142,8 +1142,10 @@ nix_priority_flow_ctrl_sq_conf(struct rte_eth_dev *eth_dev, uint16_t qid, > if (qid >= eth_dev->data->nb_tx_queues) > return -ENOTSUP; > > - /* Check if RX pause frame is enabled or not */ > - if (!pfc->rx_pause_en) { > + /* Check if RX pause frame is enabled or not and > + * confirm user requested for PFC. > + */ > + if (!pfc->rx_pause_en && rx_pause) { > if ((roc_nix_tm_tree_type_get(nix) == ROC_NIX_TM_DEFAULT) && > eth_dev->data->nb_tx_queues > 1) { > /* > -- > 2.25.1 >