Re: [PATCH] common/cnxk: show more detailed info on model mismatch

[Jerin Jacob <jerinjacobk@gmail.com>]

On Thu, Feb 24, 2022 at 4:04 PM Tomasz Duszynski <tduszynski@marvell.com> wrote:
>
> Model is uniquely identified by 4 numbers. Print them all in case
> model being populated is not on a list of known models. This makes
> debugging a bit easier.
>
> Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
> Reviewed-by: Jakub Palider <jpalider@marvell.com>
> Reviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>


Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks

    common/cnxk: show more detailed info on model mismatch

    Model is uniquely identified by 4 numbers. Print them all in case
    model being populated is not on a list of known models. This makes
    debugging a bit easier.

    Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
    Reviewed-by: Jakub Palider <jpalider@marvell.com>
    Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  drivers/common/cnxk/roc_model.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_model.c b/drivers/common/cnxk/roc_model.c
> index 447dc6e8bc..49617c02b7 100644
> --- a/drivers/common/cnxk/roc_model.c
> +++ b/drivers/common/cnxk/roc_model.c
> @@ -132,7 +132,8 @@ populate_model(struct roc_model *model, uint32_t midr)
>         if (!found) {
>                 model->flag = 0;
>                 strncpy(model->name, "unknown", ROC_MODEL_STR_LEN_MAX - 1);
> -               plt_err("Invalid RoC model (impl=0x%x, part=0x%x)", impl, part);
> +               plt_err("Invalid RoC model (impl=0x%x, part=0x%x, major=0x%x, minor=0x%x)",
> +                       impl, part, major, minor);
>         }
>
>         return found;
> --
> 2.25.1
>