From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B19E0A034C; Thu, 24 Feb 2022 21:36:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90DB941143; Thu, 24 Feb 2022 21:36:56 +0100 (CET) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by mails.dpdk.org (Postfix) with ESMTP id A900E4113D for ; Thu, 24 Feb 2022 21:36:55 +0100 (CET) Received: by mail-io1-f45.google.com with SMTP id d19so4184309ioc.8 for ; Thu, 24 Feb 2022 12:36:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9Z0+6jp06+J4eCdQJiDyqLO3vNLxSDHuH1MzfPquQMs=; b=NvlGJSFmWWPOBabvoeaSy2v7TUwldhqAtNhz7J9ukpb3ageLRfQ3XiPg/h211HZZnZ Iq7Y+ivaEc52Jm8rWAKODUHHNr22X8LHBIckVXhq1IyUgZKmapkuV/YlurQUr6aRJC5D p6eLqi8+mW1SZJLcujTBKt9rGZAEYsGijWV1Yox1u8jb/z3Ki22lN1bXxYaxBHWYAHQY JkzmzYigj3MxnFt/o6jGBNoz0YNBOGOnOvXhRtHzagtbaFJvkmd+/RmDxmcqXgLile1Y i7Zlu/x1vrkMhxnVBqREapWc7E99X6y2wSRBF2UqZtuYlJG3p+fUjc5uxkKmP0SCo5cQ 7QtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9Z0+6jp06+J4eCdQJiDyqLO3vNLxSDHuH1MzfPquQMs=; b=caVYtn/EiabwmBL1kZFQ8246O427V7TlwjF/9sJlPPVUweZobqDbEg0mexavdeaG2g tvmyWuk1puym5P1aGR8LCWxrBQC0JZyawZIrvKmO8nDkybWugB2AHsZyNRfddYEQ7zAZ 3zIC4GzAk6f2JflOkZsE8z9FirQRHrPPhL7W9u42J//oUDAfM/eO+SmrjkEP77Hm2uCS yeEn9Ndy8hdO4ywb8WlV+QqSq/0T8nAXlj0siB3yaiH/7pqU9wB7rg/IbR1sw4ES32kk Xb0oNlplNKwpbrTgem/ocnfbEOWXFYaOZVRzWyb7YhIkS+FO+xLV6SfBFtJRPLw+4RJP f0iA== X-Gm-Message-State: AOAM531wrUxyEl0kAMyyfGQu8UpuHB7Fhi79cG3s0PS/ndIAzi58BXE0 nzDnvMi3OSe4ib54YKLr08B+CHzuL8RLgAJFFU5mKWzZ+6SnXw== X-Google-Smtp-Source: ABdhPJxErLbP7OgFj9HZ2KlivX7N5kAZsJKu2bVPZFTyc3L7Tl76Akct1SZlVWN10GJM/DLR61vxQCYEzGGDK4FjxU4= X-Received: by 2002:a6b:ce01:0:b0:610:8f2:3b7 with SMTP id p1-20020a6bce01000000b0061008f203b7mr3230200iob.25.1645735015030; Thu, 24 Feb 2022 12:36:55 -0800 (PST) MIME-Version: 1.0 References: <20220224103422.1425044-1-tduszynski@marvell.com> In-Reply-To: <20220224103422.1425044-1-tduszynski@marvell.com> From: Jerin Jacob Date: Fri, 25 Feb 2022 02:06:29 +0530 Message-ID: Subject: Re: [PATCH] common/cnxk: show more detailed info on model mismatch To: Tomasz Duszynski Cc: dpdk-dev , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Thomas Monjalon , Jerin Jacob , Jakub Palider Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 24, 2022 at 4:04 PM Tomasz Duszynski wrote: > > Model is uniquely identified by 4 numbers. Print them all in case > model being populated is not on a list of known models. This makes > debugging a bit easier. > > Signed-off-by: Tomasz Duszynski > Reviewed-by: Jakub Palider > Reviewed-by: Jerin Jacob Kollanukkaran Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: show more detailed info on model mismatch Model is uniquely identified by 4 numbers. Print them all in case model being populated is not on a list of known models. This makes debugging a bit easier. Signed-off-by: Tomasz Duszynski Reviewed-by: Jakub Palider Reviewed-by: Jerin Jacob > --- > drivers/common/cnxk/roc_model.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/common/cnxk/roc_model.c b/drivers/common/cnxk/roc_model.c > index 447dc6e8bc..49617c02b7 100644 > --- a/drivers/common/cnxk/roc_model.c > +++ b/drivers/common/cnxk/roc_model.c > @@ -132,7 +132,8 @@ populate_model(struct roc_model *model, uint32_t midr) > if (!found) { > model->flag = 0; > strncpy(model->name, "unknown", ROC_MODEL_STR_LEN_MAX - 1); > - plt_err("Invalid RoC model (impl=0x%x, part=0x%x)", impl, part); > + plt_err("Invalid RoC model (impl=0x%x, part=0x%x, major=0x%x, minor=0x%x)", > + impl, part, major, minor); > } > > return found; > -- > 2.25.1 >