* [PATCH] common/cnxk: show more detailed info on model mismatch
@ 2022-02-24 10:34 Tomasz Duszynski
2022-02-24 20:36 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: Tomasz Duszynski @ 2022-02-24 10:34 UTC (permalink / raw)
To: dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: thomas, jerinj, Tomasz Duszynski, Jakub Palider
Model is uniquely identified by 4 numbers. Print them all in case
model being populated is not on a list of known models. This makes
debugging a bit easier.
Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
Reviewed-by: Jakub Palider <jpalider@marvell.com>
Reviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
---
drivers/common/cnxk/roc_model.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/common/cnxk/roc_model.c b/drivers/common/cnxk/roc_model.c
index 447dc6e8bc..49617c02b7 100644
--- a/drivers/common/cnxk/roc_model.c
+++ b/drivers/common/cnxk/roc_model.c
@@ -132,7 +132,8 @@ populate_model(struct roc_model *model, uint32_t midr)
if (!found) {
model->flag = 0;
strncpy(model->name, "unknown", ROC_MODEL_STR_LEN_MAX - 1);
- plt_err("Invalid RoC model (impl=0x%x, part=0x%x)", impl, part);
+ plt_err("Invalid RoC model (impl=0x%x, part=0x%x, major=0x%x, minor=0x%x)",
+ impl, part, major, minor);
}
return found;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] common/cnxk: show more detailed info on model mismatch
2022-02-24 10:34 [PATCH] common/cnxk: show more detailed info on model mismatch Tomasz Duszynski
@ 2022-02-24 20:36 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2022-02-24 20:36 UTC (permalink / raw)
To: Tomasz Duszynski
Cc: dpdk-dev, Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori,
Satha Rao, Thomas Monjalon, Jerin Jacob, Jakub Palider
On Thu, Feb 24, 2022 at 4:04 PM Tomasz Duszynski <tduszynski@marvell.com> wrote:
>
> Model is uniquely identified by 4 numbers. Print them all in case
> model being populated is not on a list of known models. This makes
> debugging a bit easier.
>
> Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
> Reviewed-by: Jakub Palider <jpalider@marvell.com>
> Reviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Updated the git commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks
common/cnxk: show more detailed info on model mismatch
Model is uniquely identified by 4 numbers. Print them all in case
model being populated is not on a list of known models. This makes
debugging a bit easier.
Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
Reviewed-by: Jakub Palider <jpalider@marvell.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> ---
> drivers/common/cnxk/roc_model.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_model.c b/drivers/common/cnxk/roc_model.c
> index 447dc6e8bc..49617c02b7 100644
> --- a/drivers/common/cnxk/roc_model.c
> +++ b/drivers/common/cnxk/roc_model.c
> @@ -132,7 +132,8 @@ populate_model(struct roc_model *model, uint32_t midr)
> if (!found) {
> model->flag = 0;
> strncpy(model->name, "unknown", ROC_MODEL_STR_LEN_MAX - 1);
> - plt_err("Invalid RoC model (impl=0x%x, part=0x%x)", impl, part);
> + plt_err("Invalid RoC model (impl=0x%x, part=0x%x, major=0x%x, minor=0x%x)",
> + impl, part, major, minor);
> }
>
> return found;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-24 20:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-24 10:34 [PATCH] common/cnxk: show more detailed info on model mismatch Tomasz Duszynski
2022-02-24 20:36 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).