From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A37FDA0524; Wed, 14 Apr 2021 08:52:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 25E5916173B; Wed, 14 Apr 2021 08:52:25 +0200 (CEST) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mails.dpdk.org (Postfix) with ESMTP id AE75A161739 for ; Wed, 14 Apr 2021 08:52:23 +0200 (CEST) Received: by mail-il1-f179.google.com with SMTP id j12so2339516ils.4 for ; Tue, 13 Apr 2021 23:52:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ecLiaSIQJYELbWIZLjZ4qVAjZfMP9UnTi0eH0xN1SGU=; b=s4tM6QjtDVhq15GiyCW1Copg65G7pEgXnhpJWonuj9vmzIyuQy9Ia1Ts0hFlSxAJ9r OghL3dXhg7E8PpKVGhSA9R4pDjTJ5i61Eeh1KYWP6xEmLrnCN+sa6O826LF2grqoKg6+ AUFi+Ezt/cfKAoBr4zD4iKGKFtflrRine9VqFdRopU+2cRzDw4HRR9HHEpsoLOJ5bQyk uPslD2mDc9dAbq76TF7NmFcqNR1Vwil6BjuKqiU5c6x/8WVZbSdHH4aMz0YRupXgqoc4 a9Nb61fDeGtnAtBAUDQgJeACV3t5atuklv5LIrA/A7Uhz8xrPvjMTg3OozlJMtsKJ0EE w0FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ecLiaSIQJYELbWIZLjZ4qVAjZfMP9UnTi0eH0xN1SGU=; b=qCpe/xo1q0zhVDvfHm3KfhkZW2+khc/iR2CHOQt9XRTZQxUk+WhvmASnZlwq7vmymq wV+HEbbhXIRrePlVehp0XaxCQkyvlrhNacth72+tO4+W8sR5bnVS2ay80OUcfS/zQQ2B nZ7wcjjKbRKra1jwyonEqPPOlIPMEZxWCx7h5vhKgrYnTqxWTe05fVVrxOps04HX32ao xC1dWtOVrEMOJxQsdcs5cJEMXDTBN0/VefBKPzYeYBI+CXNa7ZAsyAhXbFD1/irB9MtP 21rGEUhl1SQbGS/5JoGexAvMuA+kVDP9jRlzkDG9vs6gHB5CIOUvYpgYCYBSMSypgFVk rPrg== X-Gm-Message-State: AOAM532EKdoqFC0UsjcDDlxo4LnEEuB/7/ptdpNG4gUOYEk8NvPbDBz4 gAJgdR2B+fWDiRi+BAJTA8UjP6awuVbaeV8JZss= X-Google-Smtp-Source: ABdhPJySASWo3rTlhzz2kHkFNx5ttpNWVKm6SkVidmBhMBkZ7CeNdmTb4HheVJnvB+9QDiEaaIUCl1hKrmONAJar1yA= X-Received: by 2002:a92:c26a:: with SMTP id h10mr11050812ild.294.1618383142912; Tue, 13 Apr 2021 23:52:22 -0700 (PDT) MIME-Version: 1.0 References: <20210413221613.2062-1-pbhagavatula@marvell.com> In-Reply-To: From: Jerin Jacob Date: Wed, 14 Apr 2021 12:22:07 +0530 Message-ID: To: David Marchand Cc: Pavan Nikhilesh , Jerin Jacob Kollanukkaran , Jay Jayatheerthan , dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eventdev: fix signed comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Apr 14, 2021 at 11:56 AM David Marchand wrote: > > On Wed, Apr 14, 2021 at 12:16 AM wrote: > > > > From: Pavan Nikhilesh > > > > Since queue identifier is passed as signed integer, a compilation error > > is generated: > > rte_event_eth_rx_adapter.c:1810:57: error: signed and unsigned type > > in conditional expression [-Werror=sign-compare] > > Make queue identifier as unsigned when adding it to vector data. > > > > Bugzilla ID: 672 > > > Fixes: d7c428e557ba ("eventdev: support Rx adapter event vector") > > > > Signed-off-by: Pavan Nikhilesh > > LGTM and fixes compilation for RHEL7. > > Acked-by: David Marchand Acked-by: Jerin Jacob > > Jerin, do you mind if I take it directly in main? Yes . Please > > > -- > David Marchand >