From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B6B9A09FF; Mon, 11 Jan 2021 15:57:19 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD554140E7C; Mon, 11 Jan 2021 15:57:18 +0100 (CET) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by mails.dpdk.org (Postfix) with ESMTP id 64D69140E71 for ; Mon, 11 Jan 2021 15:57:17 +0100 (CET) Received: by mail-il1-f172.google.com with SMTP id e7so18687436ile.7 for ; Mon, 11 Jan 2021 06:57:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XN6ew443WYBKndVtM+806mpQW+eIKtwdjJcZkmMZ0tM=; b=X3m3BoULJgMtdzJOc/UgT2VzirFrzDjVxIoddGlea45tczmQVrRhoOChPspKnpryWp wtocQnZWvR3sArXDqYK05NxPGfAsl+QoA/djnaN7h88Y0PlSNVEKdTKFIDBJAn29MMwp vgpx61wbTzHDDf4e6jcTqMHOxO6FGUKHxKZ+R4RxA88lwmK/DiX4YmG51PH7nNr/rR5V rLLET68r4sDhXgcX7Ap7zXDATH/lCXym1JRUnZbvD/JULfVu9mu5+NV3+PoyB9tJCoku h/UeldiMY6TEFn9FGC7Bt5aMRPSxA1lOPhM1fuS6BH+q4smCmexAIeCHLeGsJ66z0TrY C9mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XN6ew443WYBKndVtM+806mpQW+eIKtwdjJcZkmMZ0tM=; b=WrfKUPkrqX4jPctICWjBCbsIWjf/1ZpHFUiBMeJoDO2W8YcotviS+iwCKhjaLzN/fw F5LCyxrlnQcIpFQQjrjs8SCjAsDxcJNZkSW8mybtAMH3wd07ZM2jJr9GHqiUUwKhb+Iv TZYIGBcZSuKQdcxppKDPUPyy8q9wVqlwtkWvUfT+g9s2gIZhtajocpy9bwm5aEaqjmE6 ikBqx7NPEfSJRKqaaf8s+dhxaQS+eJRlENNSwKiYUCseTt8hZVbNhuof3u3BALxt+r0L qRkHJFmwI/hnStXjw/SRB8b8Wg1RLpj+qg5xFfo05+stKyJl5xMgHAmVkyat1lOEjeRN y78A== X-Gm-Message-State: AOAM5309KV8ojZY+u5odySqTeWfk+sVK5S64xLF7dj41AQtKnCeSHdHc cetK7eO5GA5Gpew2adxbNAyMnTRoirhDNFnhwds= X-Google-Smtp-Source: ABdhPJzYGMdFlab1knkmGCNkQbX83dYR/Dn+kUXXB09WjnvktEdsMr6TGZ9//22nTVjYlihOwPXJou940WEuOrDwSdw= X-Received: by 2002:a05:6e02:92f:: with SMTP id o15mr15271339ilt.130.1610377036838; Mon, 11 Jan 2021 06:57:16 -0800 (PST) MIME-Version: 1.0 References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-12-lironh@marvell.com> In-Reply-To: <20201202101212.4717-12-lironh@marvell.com> From: Jerin Jacob Date: Mon, 11 Jan 2021 20:27:00 +0530 Message-ID: To: Liron Himi Cc: Jerin Jacob , dpdk-dev , Yuri Chipchev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1 11/38] net/mvpp2: align checking order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 2, 2020 at 3:46 PM wrote: > > From: Yuri Chipchev > > first check for 'isolated' and then for '!ppio' > > Signed-off-by: Yuri Chipchev > Reviewed-by: Liron Himi > --- > drivers/net/mvpp2/mrvl_ethdev.c | 30 ++++++++++++++++++------------ > 1 file changed, 18 insertions(+), 12 deletions(-) > > diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c > index 130f5221d..76847b303 100644 > --- a/drivers/net/mvpp2/mrvl_ethdev.c > +++ b/drivers/net/mvpp2/mrvl_ethdev.c > @@ -1007,10 +1007,10 @@ mrvl_promiscuous_enable(struct rte_eth_dev *dev) > struct mrvl_priv *priv = dev->data->dev_private; > int ret; > > - if (!priv->ppio) > + if (priv->isolated) > return 0; Rather than duplicating these checks in every function. Please move sanity check to a function and reuse it. > > - if (priv->isolated) > + if (!priv->ppio) > return 0; > > ret = pp2_ppio_set_promisc(priv->ppio, 1); > @@ -1037,10 +1037,10 @@ mrvl_allmulticast_enable(struct rte_eth_dev *dev) > struct mrvl_priv *priv = dev->data->dev_private; > int ret; > > - if (!priv->ppio) > + if (priv->isolated) > return 0; > > - if (priv->isolated) > + if (!priv->ppio) > return 0; > > ret = pp2_ppio_set_mc_promisc(priv->ppio, 1); > @@ -1067,6 +1067,9 @@ mrvl_promiscuous_disable(struct rte_eth_dev *dev) > struct mrvl_priv *priv = dev->data->dev_private; > int ret; > > + if (priv->isolated) > + return 0; > + > if (!priv->ppio) > return 0; > > @@ -1094,6 +1097,9 @@ mrvl_allmulticast_disable(struct rte_eth_dev *dev) > struct mrvl_priv *priv = dev->data->dev_private; > int ret; > > + if (priv->isolated) > + return 0; > + > if (!priv->ppio) > return 0; > > @@ -1121,10 +1127,10 @@ mrvl_mac_addr_remove(struct rte_eth_dev *dev, uint32_t index) > char buf[RTE_ETHER_ADDR_FMT_SIZE]; > int ret; > > - if (!priv->ppio) > + if (priv->isolated) > return; > > - if (priv->isolated) > + if (!priv->ppio) > return; > > ret = pp2_ppio_remove_mac_addr(priv->ppio, > @@ -1209,12 +1215,12 @@ mrvl_mac_addr_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr) > struct mrvl_priv *priv = dev->data->dev_private; > int ret; > > - if (!priv->ppio) > - return 0; > - > if (priv->isolated) > return -ENOTSUP; > > + if (!priv->ppio) > + return 0; > + > ret = pp2_ppio_set_mac_addr(priv->ppio, mac_addr->addr_bytes); > if (ret) { > char buf[RTE_ETHER_ADDR_FMT_SIZE]; > @@ -1590,12 +1596,12 @@ mrvl_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) > { > struct mrvl_priv *priv = dev->data->dev_private; > > - if (!priv->ppio) > - return -EPERM; > - > if (priv->isolated) > return -ENOTSUP; > > + if (!priv->ppio) > + return 0; > + > return on ? pp2_ppio_add_vlan(priv->ppio, vlan_id) : > pp2_ppio_remove_vlan(priv->ppio, vlan_id); > } > -- > 2.28.0 >