From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D746A0547; Fri, 30 Jul 2021 13:18:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B33740042; Fri, 30 Jul 2021 13:18:11 +0200 (CEST) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by mails.dpdk.org (Postfix) with ESMTP id EA6D14003F for ; Fri, 30 Jul 2021 13:18:09 +0200 (CEST) Received: by mail-il1-f172.google.com with SMTP id c3so9018156ilh.3 for ; Fri, 30 Jul 2021 04:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=J/1pR2o/dooE5MONl1qiqWCUz3Nn2CNZH0a2x2luy8k=; b=fS+NTm44spfv77kPxX17IjqEn1aiiwVa6dBgWE1yKSGyvNtMGl6raz3AM89RsImIEe dJnVKcr3bxX0Fgocig+6W93uYk3fGDYmiicgz7QJ4HZGrOZeOkfrHljfWHCHKgRDxbBy 5eDH45kEXQGRGeIL5x4b4MQD9sQ3LTZ2mo1jJoArsOAaGOcNFGvY5TNZlrHA9HcIcaVf palEnge3AlYZ3n3jrePM88DHuCYqrCEpg3GImn1Lryrnpu/aAkJrHp5i9ZYLRw6FjKU6 cL8rCa2Gc0DnMNa3226igT9M8JG3Pj0gLDjxhHiv50UU6+QMUiISga+qitM2b9eCF0r0 gDvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J/1pR2o/dooE5MONl1qiqWCUz3Nn2CNZH0a2x2luy8k=; b=dnFIsvnfrhmfZqZfYXJdQ2WDFh3wkimD/49Eyny4F9e9f0vT4KGgYnAtX34ulkbg/H /hlTAnA0EskVOe4RrXmh0q13JlZGWhj7IMJm2mWTDtG7To4i58V+Uh56KqdbXLtVr1qG j+yeAVyi2ekB9+ZYaSgL8yfob8h7y2bJ23l3qJWoDIBoQeitSzG5PZKgah+07B6NnqDc iRmATAK07cHAstKq1aFYr8ULYWuL0EZcS4lswBHqSCEFI1P85RHEbmMgkjd4caK3np3/ 2EWXtB+u0SlfR9KU6ncVSnpyh0T2GyodthB1Nfzr33WySTuyNYj1e0Sx9gGXyKbC/EXT DbCQ== X-Gm-Message-State: AOAM533/CVewmJqApyDbyiGixi4OeLqGgfNPvV2ssT1p/kaKXqY0hLsb JDpj5Yp8Vb99tynvZYbCCyM9q4Jusj/tt8btJ7s= X-Google-Smtp-Source: ABdhPJwFQ+Q7QEq8pSDnBohFk2mNhAQADFv0KtgSN9EF1tPFPjHLFRw5tdxoxpQElJ983wkWQ5JoDxLD1Xei6WG2xig= X-Received: by 2002:a92:c5c5:: with SMTP id s5mr1457648ilt.271.1627643889349; Fri, 30 Jul 2021 04:18:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Fri, 30 Jul 2021 16:47:43 +0530 Message-ID: To: "Kundapura, Ganapati" Cc: dpdk-dev , "Jayatheerthan, Jay" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] RFC: Enahancements to Rx adapter for DPDK 21.11 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 28, 2021 at 11:53 AM Kundapura, Ganapati wrote: > > Comments inlined Please fix your email client for adding proper > > > -----Original Message----- > From: Jerin Jacob > Sent: 28 July 2021 11:38 > To: Kundapura, Ganapati > Cc: dpdk-dev ; Jayatheerthan, Jay > Subject: Re: RFC: Enahancements to Rx adapter for DPDK 21.11 > > On Mon, Jul 26, 2021 at 6:37 PM Kundapura, Ganapati wrote: > > > > A gentle ping for comments. > > > > -----Original Message----- > > From: dev On Behalf Of Kundapura, Ganapati > > Sent: 23 July 2021 12:33 > > To: dpdk-dev ; Jerin Jacob ; > > Jayatheerthan, Jay > > Subject: [dpdk-dev] RFC: Enahancements to Rx adapter for DPDK 21.11 > > > > Hi dpdk-dev, > > > > We would like to submit series of patches to Rx adapters that will enhance the configuration and performance. > > Please find the details below. > > > > (1) Configure Rx event buffer at run time > > Add new api to configure the size of the Rx event buffer at run time. > > This api allows setting the size of the event buffer at adapter level. > > Since we can change ABI for 21.11, Not prefer to add a new API instead add a param to config structure. > Please send the deprecation notice for ABI change. > > Config structure passed to rte_event_eth_rx_adapter_create() is of type rte_event_port_conf which > comes from event framework(rte_eventdev.h). > Does it make sense to pass adapter event buffer size in rte_event_port_conf structure? I see. Then new API is better to set the buffer is OK. > > > > > (2) Change packet enqueue buffer in Rx adapter to circular buffer > > Rx adapter uses memmove() to move unprocessed events to the begining > > of packet enqueue buffer which consumes good amount of CPU cycles. > > Looks good. > > > > > > (3) Add API to retrieve the Rx queue info > > Rx queue info containinin flags for handling received packets, > > event queue identifier, schedular type, event priority, > > polling frequence of the receive queue and flow identifier > > Looks good. Please implement it as adaptor ops so that it can be adapter specific to support HW implementations. > > > > > > > (4) Add adapter_stats cli to retrive Rx/Tx adapter stats and rxq info > > This cli displays Rx and Tx adapter stats containing recieved packet count, > > eventdev enqueue count, enqueue retry count, event buffer size, queue poll count, > > transmitted packet count, packet dropped count, transmit fail count etc and rx queue info. > > Generally, we don't entertain CLI in the library. You can add command-line arguments to app/test-eventdev to test this. > > Adapter_stats is standalone application not part of library and it'll be in app/adapter_stats. No need for a new app. Please add stats as telemetry, then it can be pull through usertools/dpdk-telemetry.py > > > > (5) Update Rx timestamp in mbuf using mbuf dynamic field > > Add support to register timestamp dynamic field in mbuf > > Update the timestamp in mbuf for each packet before eventdev > > enqueue > > Cool. > > > > > We look forward to feedback on this proposal. Once we have initial feedback, patches will be submitted for review. > > > > Thanks, > > Ganapati