From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11220A04DD; Tue, 10 Nov 2020 19:07:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DCF6B2B93; Tue, 10 Nov 2020 19:07:11 +0100 (CET) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 30296F90 for ; Tue, 10 Nov 2020 19:07:10 +0100 (CET) Received: by mail-il1-f196.google.com with SMTP id q1so13067216ilt.6 for ; Tue, 10 Nov 2020 10:07:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gUd5zbxFQqMNdyHhnPiW37Vo46igP6xZHl3KymbLHiQ=; b=g+ZRaz7JEQN620rHU83p76afjS3AXTBz62aJZHpHonG6Vl/VOTTkBzqHH0GLaJh5ce 65uaC7fEAfsyGedst/lz5MbD4SK+LWWiJ2qlf6WpumPgz3KdLbnjugkAFs+5AwcQZi5i lJgjbabt0zmQbaPOetMgYWA1rua0EjilHJxh/gaHdDT14PiiFoCl97Jyqcvlo9zK6mov 24JdBrn4LVdAHLGxzw4z9asZ1QV19iEweOcG2e7D/ZN9INxAfTbN9IfiupEMk18pZT1H wad8VsIUsTlTe5ConnK/ZAHYogB5T/Ii76DAFTuzA8jDBLaSp7c6Q7Gvv17H4QPV2T65 Zy4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gUd5zbxFQqMNdyHhnPiW37Vo46igP6xZHl3KymbLHiQ=; b=tSp21oJVxwsOz4MRhhNd/FKEmPz8op6/OTEiQllotKSc0ptXwuDs8e78Zn7M63qoMz 0n1YVJul9/BvFwIzFVTD0j1R0awwWk9Hnuzy9n1tCZiloBmawxIEMdSJomj9mrn/qAjM jZ/rSvMiDThC9CM1XESdudmE+whZKVJ4tupsxi78/qFeCAw/OA5aTvKpBtckbuvWjXzf 9aHD5X75A9mKuzQwxbtfcTNtd9kG0hmsXCymDvDdi9RXhBMvA2fhsVK1ScmlHSM98tX2 XGrdfkXhOkq6Bjfv/Jaq9wgxDSwL0jXeGGqW2pPQwVvsA8ZjmkcSkJy7CI2Sn9EK+2E3 FqSw== X-Gm-Message-State: AOAM533u8RdhHzuikAyUjekMowcjafsgba46MRcb12t60R4gOdhIqfJE TMiUh+dw8ZZLswcZLyBYUSWsfVfHbHWyx97DTys= X-Google-Smtp-Source: ABdhPJwhLc1RGAJjyol91GqLrJ/P+F2eaAbAsxNDHfzj9kayQkoJYmLWnGjLk6RmuzCwcoQ4bLfJa4NdE4EgnU72kIo= X-Received: by 2002:a05:6e02:52f:: with SMTP id h15mr14268798ils.60.1605031628576; Tue, 10 Nov 2020 10:07:08 -0800 (PST) MIME-Version: 1.0 References: <20201107155306.463148-1-thomas@monjalon.net> <20201109212937.989954-1-thomas@monjalon.net> <20201109212937.989954-3-thomas@monjalon.net> <20201110162509.GN1898@platinum> In-Reply-To: <20201110162509.GN1898@platinum> From: Jerin Jacob Date: Tue, 10 Nov 2020 23:36:52 +0530 Message-ID: To: Olivier Matz Cc: Thomas Monjalon , dpdk-dev , David Marchand , Ferruh Yigit , =?UTF-8?Q?Morten_Br=C3=B8rup?= , "Ananyev, Konstantin" , Andrew Rybchenko , Viacheslav Ovsiienko , Ajit Khaparde , Jerin Jacob , Hemant Agrawal , Ray Kinsella , Neil Horman Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 2/2] mbuf: move pool pointer in first half X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 10, 2020 at 9:55 PM Olivier Matz wrote: > > On Mon, Nov 09, 2020 at 10:29:37PM +0100, Thomas Monjalon wrote: > > According to the Technical Board decision > > (http://mails.dpdk.org/archives/dev/2020-November/191859.html), > > the mempool pointer in the mbuf struct is moved > > from the second to the first half. > > It may increase performance in some cases > > on systems having 64-byte cache line, i.e. mbuf split in two cache lines. > > > > Due to this change, tx_offload is moved. > > Hopefully no vector data path is impacted. > > > > Moving this field gives more space to dynfield1 > > while dropping the temporary dynfield0. > > > > This is how the mbuf layout looks like (pahole-style): > > > > word type name byte size > > 0 void * buf_addr; /* 0 + 8 */ > > 1 rte_iova_t buf_iova /* 8 + 8 */ > > /* --- RTE_MARKER64 rearm_data; */ > > 2 uint16_t data_off; /* 16 + 2 */ > > uint16_t refcnt; /* 18 + 2 */ > > uint16_t nb_segs; /* 20 + 2 */ > > uint16_t port; /* 22 + 2 */ > > 3 uint64_t ol_flags; /* 24 + 8 */ > > /* --- RTE_MARKER rx_descriptor_fields1; */ > > 4 uint32_t union packet_type; /* 32 + 4 */ > > uint32_t pkt_len; /* 36 + 4 */ > > 5 uint16_t data_len; /* 40 + 2 */ > > uint16_t vlan_tci; /* 42 + 2 */ > > 5.5 uint64_t union hash; /* 44 + 8 */ > > 6.5 uint16_t vlan_tci_outer; /* 52 + 2 */ > > uint16_t buf_len; /* 54 + 2 */ > > 7 struct rte_mempool * pool; /* 56 + 8 */ > > /* --- RTE_MARKER cacheline1; */ > > 8 struct rte_mbuf * next; /* 64 + 8 */ > > 9 uint64_t union tx_offload; /* 72 + 8 */ > > 10 struct rte_mbuf_ext_shared_info * shinfo; /* 80 + 8 */ > > 11 uint16_t priv_size; /* 88 + 2 */ > > uint16_t timesync; /* 90 + 2 */ > > 11.5 uint32_t dynfield1[9]; /* 92 + 36 */ > > 16 /* --- END 128 */ > > > > Signed-off-by: Thomas Monjalon > > Acked-by: Olivier Matz Acked-by: Jerin Jacob