From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C866A04DB; Thu, 15 Oct 2020 20:49:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9B0DD1DE1C; Thu, 15 Oct 2020 20:49:32 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 5FDCE1DC37 for ; Thu, 15 Oct 2020 20:49:29 +0200 (CEST) Received: by mail-il1-f196.google.com with SMTP id j17so2855540ilr.2 for ; Thu, 15 Oct 2020 11:49:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tvixO/xrYP3Zuc5ON99OGhPkInL+b7kWe4bXfdd19gU=; b=osR2iKBc6WbLj/UDCon3r5bLJTipNd+IR3U6GIFwpsWKUW5Qj3l3YfsMEikUa2RSLO Fz5dmeoNSJiBVeNmJvMW3BKAyrg4fWgfzMLEbhjvM2KBQ9OF4IcOJdiIXIgCGqqWhHxr +6iw/GQrxfP1m+izFHQeSyzNRYhinQbB9GKQiV1r0xBTjMB4F8BS6s9sJMHr8XndaQUF 1qhKbppPMzYbznJVAgl3YGGTU0tb+Kd77cgXrsOtPAMOjwmogp97rIsnAFjHULG4JZBM kZetW910vszmbr8I5kgp2ZXJvoyilC6b7HA3rdQG9Gx/+7TYZClR5Pb9iYATn4d0EkCP 4F1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tvixO/xrYP3Zuc5ON99OGhPkInL+b7kWe4bXfdd19gU=; b=QgtEjOh+AgkKYWq1UUuxYa09cjLXhvt0IIri0tDDi2ZxoCdOpeVUQK6xUb1OAzBZ/o Lx9a2OeCIOklxtJgGnzXGJipozQF8wBRfI98C/u948eJ2v41shpsTgvlK7QphXKXiJJ6 DQMndtBnc6QWeu+oraUQpWUIOVm3hH0B/MIMXjv10yCnq4gBctQ0jnsRkjX1lvpeJmaR YlGQXlPqQbv4UBlKcluB1HK/4hS53smvEJk5JsJVjLc2ZYF4szV0+u2xzDygG03FEXsz mqstuS6hwyPrIXF8TS4OjAUqW0scYBhHbVkEdH2WL5K8NfFT5ChxZhmyfWesRHZCbc+r ZHWA== X-Gm-Message-State: AOAM533OAvzhPgE7TQsFq4kUHLbKGIxK745EhY6CYLSX3b4t/cHdodvs pVBWzB+G3kBXYR94LtWJlaFrhcmNY4kNRUO6eNU= X-Google-Smtp-Source: ABdhPJwunRTvwiKx7ay01XZNJzdHCB5/yCGpKMbQZIfxHHGWSckdymsbmgPQzEUBokQJLb6tdkBbAg9gVKWVJTCd15s= X-Received: by 2002:a92:1e02:: with SMTP id e2mr4279030ile.294.1602787768140; Thu, 15 Oct 2020 11:49:28 -0700 (PDT) MIME-Version: 1.0 References: <1599843867-28048-1-git-send-email-timothy.mcdaniel@intel.com> <1602771406-25220-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1602771406-25220-1-git-send-email-timothy.mcdaniel@intel.com> From: Jerin Jacob Date: Fri, 16 Oct 2020 00:19:11 +0530 Message-ID: To: Timothy McDaniel Cc: Jerin Jacob , Ray Kinsella , Neil Horman , dpdk-dev , Erik Gabriel Carrillo , Gage Eads , "Van Haaren, Harry" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6] eventdev: add PCI probe named convenience function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 15, 2020 at 7:45 PM Timothy McDaniel wrote: > > Add new internal wrapper function for use by pci drivers as a > .probe function to attach to an event interface. Same as > rte_event_pmd_pci_probe, except the caller can specify the name. > > Updated rte_event_pmd_pci_probe so as to not duplicate > code. > > Signed-off-by: Timothy McDaniel > Reviewed-by: Gage Eads Applied to dpdk-next-eventdev/for-main. Thanks. > --- > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 45 ++++++++++++++++++++-------- > lib/librte_eventdev/rte_eventdev_version.map | 3 ++ > 2 files changed, 35 insertions(+), 13 deletions(-) > > diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > index 443cd38..5f238bf 100644 > --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h > +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > @@ -32,28 +32,25 @@ typedef int (*eventdev_pmd_pci_callback_t)(struct rte_eventdev *dev); > > /** > * @internal > - * Wrapper for use by pci drivers as a .probe function to attach to a event > - * interface. > + * Wrapper for use by pci drivers as a .probe function to attach to an event > + * interface. Same as rte_event_pmd_pci_probe, except caller can specify > + * the name. > */ > +__rte_experimental > static inline int > -rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, > - struct rte_pci_device *pci_dev, > - size_t private_data_size, > - eventdev_pmd_pci_callback_t devinit) > +rte_event_pmd_pci_probe_named(struct rte_pci_driver *pci_drv, > + struct rte_pci_device *pci_dev, > + size_t private_data_size, > + eventdev_pmd_pci_callback_t devinit, > + const char *name) > { > struct rte_eventdev *eventdev; > - > - char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN]; > - > int retval; > > if (devinit == NULL) > return -EINVAL; > > - rte_pci_device_name(&pci_dev->addr, eventdev_name, > - sizeof(eventdev_name)); > - > - eventdev = rte_event_pmd_allocate(eventdev_name, > + eventdev = rte_event_pmd_allocate(name, > pci_dev->device.numa_node); > if (eventdev == NULL) > return -ENOMEM; > @@ -88,6 +85,28 @@ rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, > return -ENXIO; > } > > +/** > + * @internal > + * Wrapper for use by pci drivers as a .probe function to attach to a event > + * interface. > + */ > +static inline int > +rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, > + struct rte_pci_device *pci_dev, > + size_t private_data_size, > + eventdev_pmd_pci_callback_t devinit) > +{ > + char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN]; > + > + rte_pci_device_name(&pci_dev->addr, eventdev_name, > + sizeof(eventdev_name)); > + > + return rte_event_pmd_pci_probe_named(pci_drv, > + pci_dev, > + private_data_size, > + devinit, > + eventdev_name); > +} > > /** > * @internal > diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map > index 3d9d0ca..88a3b6c 100644 > --- a/lib/librte_eventdev/rte_eventdev_version.map > +++ b/lib/librte_eventdev/rte_eventdev_version.map > @@ -134,4 +134,7 @@ EXPERIMENTAL { > __rte_eventdev_trace_crypto_adapter_queue_pair_del; > __rte_eventdev_trace_crypto_adapter_start; > __rte_eventdev_trace_crypto_adapter_stop; > + > + # added in 20.11 > + rte_event_pmd_pci_probe_named; > }; > -- > 2.6.4 >