* [PATCH 1/2] event/cnxk: fix incorrect mask length
@ 2022-03-01 22:53 pbhagavatula
2022-03-01 22:53 ` [PATCH 2/2] event/cnxk: fix incorrect Rx adapter config checks pbhagavatula
2022-03-03 6:50 ` [PATCH 1/2] event/cnxk: fix incorrect mask length Jerin Jacob
0 siblings, 2 replies; 3+ messages in thread
From: pbhagavatula @ 2022-03-01 22:53 UTC (permalink / raw)
To: jerinj, Pavan Nikhilesh, Shijith Thotton; +Cc: dev
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
Fix incorrect mask used when clearing subevent type masking out
useful data.
Fixes: e239e0d3faf7 ("event/cnxk: add SSO HW device operations")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
drivers/event/cnxk/cnxk_eventdev.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/event/cnxk/cnxk_eventdev.h b/drivers/event/cnxk/cnxk_eventdev.h
index b157fef096..5564746e6d 100644
--- a/drivers/event/cnxk/cnxk_eventdev.h
+++ b/drivers/event/cnxk/cnxk_eventdev.h
@@ -43,7 +43,7 @@
#define CNXK_TT_FROM_EVENT(x) (((x) >> 38) & SSO_TT_EMPTY)
#define CNXK_EVENT_TYPE_FROM_TAG(x) (((x) >> 28) & 0xf)
#define CNXK_SUB_EVENT_FROM_TAG(x) (((x) >> 20) & 0xff)
-#define CNXK_CLR_SUB_EVENT(x) (~(0xffu << 20) & x)
+#define CNXK_CLR_SUB_EVENT(x) (~(0xffull << 20) & x)
#define CNXK_GRP_FROM_TAG(x) (((x) >> 36) & 0x3ff)
#define CNXK_SWTAG_PEND(x) (BIT_ULL(62) & x)
#define CNXK_TAG_IS_HEAD(x) (BIT_ULL(35) & x)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 2/2] event/cnxk: fix incorrect Rx adapter config checks
2022-03-01 22:53 [PATCH 1/2] event/cnxk: fix incorrect mask length pbhagavatula
@ 2022-03-01 22:53 ` pbhagavatula
2022-03-03 6:50 ` [PATCH 1/2] event/cnxk: fix incorrect mask length Jerin Jacob
1 sibling, 0 replies; 3+ messages in thread
From: pbhagavatula @ 2022-03-01 22:53 UTC (permalink / raw)
To: jerinj, Pavan Nikhilesh, Shijith Thotton; +Cc: dev
From: Pavan Nikhilesh <pbhagavatula@marvell.com>
The rx_queue_flags should be checked against
RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID flag.
Fixes: cb4bfd6e7bdf ("event/cnxk: support Rx adapter")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
drivers/event/cnxk/cnxk_eventdev_adptr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/event/cnxk/cnxk_eventdev_adptr.c b/drivers/event/cnxk/cnxk_eventdev_adptr.c
index 7b580ca98f..bfc89a1368 100644
--- a/drivers/event/cnxk/cnxk_eventdev_adptr.c
+++ b/drivers/event/cnxk/cnxk_eventdev_adptr.c
@@ -230,7 +230,7 @@ cnxk_sso_rx_adapter_queue_add(
cnxk_eth_dev, (uint16_t)rx_queue_id, port,
&queue_conf->ev,
!!(queue_conf->rx_queue_flags &
- RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID));
+ RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID));
if (queue_conf->rx_queue_flags &
RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR) {
cnxk_sso_updt_xae_cnt(dev, queue_conf->vector_mp,
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] event/cnxk: fix incorrect mask length
2022-03-01 22:53 [PATCH 1/2] event/cnxk: fix incorrect mask length pbhagavatula
2022-03-01 22:53 ` [PATCH 2/2] event/cnxk: fix incorrect Rx adapter config checks pbhagavatula
@ 2022-03-03 6:50 ` Jerin Jacob
1 sibling, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2022-03-03 6:50 UTC (permalink / raw)
To: Pavan Nikhilesh; +Cc: Jerin Jacob, Shijith Thotton, dpdk-dev
On Wed, Mar 2, 2022 at 4:23 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Fix incorrect mask used when clearing subevent type masking out
> useful data.
>
> Fixes: e239e0d3faf7 ("event/cnxk: add SSO HW device operations")
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Series applied to dpdk-next-net-eventdev/for-main. Thanks
> ---
> drivers/event/cnxk/cnxk_eventdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/event/cnxk/cnxk_eventdev.h b/drivers/event/cnxk/cnxk_eventdev.h
> index b157fef096..5564746e6d 100644
> --- a/drivers/event/cnxk/cnxk_eventdev.h
> +++ b/drivers/event/cnxk/cnxk_eventdev.h
> @@ -43,7 +43,7 @@
> #define CNXK_TT_FROM_EVENT(x) (((x) >> 38) & SSO_TT_EMPTY)
> #define CNXK_EVENT_TYPE_FROM_TAG(x) (((x) >> 28) & 0xf)
> #define CNXK_SUB_EVENT_FROM_TAG(x) (((x) >> 20) & 0xff)
> -#define CNXK_CLR_SUB_EVENT(x) (~(0xffu << 20) & x)
> +#define CNXK_CLR_SUB_EVENT(x) (~(0xffull << 20) & x)
> #define CNXK_GRP_FROM_TAG(x) (((x) >> 36) & 0x3ff)
> #define CNXK_SWTAG_PEND(x) (BIT_ULL(62) & x)
> #define CNXK_TAG_IS_HEAD(x) (BIT_ULL(35) & x)
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-03 6:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-01 22:53 [PATCH 1/2] event/cnxk: fix incorrect mask length pbhagavatula
2022-03-01 22:53 ` [PATCH 2/2] event/cnxk: fix incorrect Rx adapter config checks pbhagavatula
2022-03-03 6:50 ` [PATCH 1/2] event/cnxk: fix incorrect mask length Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).