From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC190425B7; Wed, 4 Oct 2023 09:47:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B5960402CC; Wed, 4 Oct 2023 09:47:53 +0200 (CEST) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by mails.dpdk.org (Postfix) with ESMTP id 14FB64029A; Wed, 4 Oct 2023 09:47:52 +0200 (CEST) Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7741109bdeeso125409185a.2; Wed, 04 Oct 2023 00:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696405671; x=1697010471; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YbE48SD+l2YD+Hj6fRPhvBSGUCnKIHGZRlji2k+M/lA=; b=ftk5Lk7wEtGPsKIuLbyIsXKyDo9AgAbg7urk5CMUBtxCPFMkAKzHMaXrZRh2R2CIeC 4oljRFrx/zOEH+tdtyw+csBynxoI0MDIBsvpjPPm/LKG7yJVAPa/oWLLdAE66m/WpjI8 Rr77jd+Lw5v+wqcSrFL+YDZUvyKGPqU7N31B8L06NyhIMwmpmrTVf8NhuTp/bKOPDHcI bzlHkvKU2nkoIlBsPP5KB+48DN/DXtKz6c75EhxslenDtaUAyjVjIRuP8OKVdQmRbgPi 8xR6GUPBgDgDhY8homyY5Dmk6rNT6bLrvDycyOKZWkT9+EfeOcQXi4Pv7AmGg5CccnaV PoHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696405671; x=1697010471; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YbE48SD+l2YD+Hj6fRPhvBSGUCnKIHGZRlji2k+M/lA=; b=Tj41EvPjKTLJiSCLS1Tlao0MZ2zz6WxLVkPMzZ4cuijduzdBp++4v10WJ2sFs5BnZh f2wTDn497CS9ZRicCjvOMPbPUzmCI41ScweGlPpXKrwCsJTvlrNWwADmy2eMY0+GNTSY YGN/JbCMF7pPyZnwYQloxYrEN52lwBiUUsy7aMwgJPn9RNRq2ckHX5+ANPQM0cfQHST5 GVket3AqRKKSaEfM0ZEE4OfH9LQ7QlHme9MpSjlbzRJ/u2CJdIEsJpsZgDcHSj3EC7ij Z1NY0q58QKgk/ZV3VnJlqpk61IoeKNaL33JG6T6aPWNHzhAhh42INs9l+JoaVzkylTOJ qjuw== X-Gm-Message-State: AOJu0YxLlZXhmsbT37Vb2OCxeuaQDtTnh6xTSzp3v2UL7N2RjHXMDRG+ 4VJ9l8CWcm/BalqMQ+kdS3fWKuoaRIohIcjlGe8= X-Google-Smtp-Source: AGHT+IGfR40cTufoEZ7af9Cald54mdzgcpvPjY0B/CIlUHiwYluNm8w+EcNnsDRNFAe/Tl0TO77MuSzKfzD5zcggVmo= X-Received: by 2002:ac8:7d0e:0:b0:418:804:340d with SMTP id g14-20020ac87d0e000000b004180804340dmr1884240qtb.48.1696405671409; Wed, 04 Oct 2023 00:47:51 -0700 (PDT) MIME-Version: 1.0 References: <20231003183956.1270510-1-jerinj@marvell.com> In-Reply-To: From: Jerin Jacob Date: Wed, 4 Oct 2023 13:17:25 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH] common/cnxk: fix direct rte symbol usage To: David Marchand Cc: Thomas Monjalon , jerinj@marvell.com, dev@dpdk.org, Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Long Li , Tyler Retzlaff , Konstantin Ananyev , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Andrew Rybchenko , Liron Himi , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 4, 2023 at 1:06=E2=80=AFPM David Marchand wrote: > > On Wed, Oct 4, 2023 at 8:43=E2=80=AFAM Jerin Jacob wrote: > > > > diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c b/drivers/common= /cnxk/roc_nix_inl_dev.c > > > > index 6aa191410b..614d0858e5 100644 > > > > --- a/drivers/common/cnxk/roc_nix_inl_dev.c > > > > +++ b/drivers/common/cnxk/roc_nix_inl_dev.c > > > > @@ -826,7 +826,7 @@ nix_inl_outb_poll_thread_setup(struct nix_inl_d= ev *inl_dev) > > > > soft_exp_consumer_cnt =3D 0; > > > > soft_exp_poll_thread_exit =3D false; > > > > rc =3D plt_thread_create_control(&inl_dev->soft_exp_poll_th= read, > > > > - "outb-poll", nix_inl_outb_poll_thread, inl_= dev); > > > > + "outb-soft-exp-poll", nix_inl_outb_poll_thr= ead, inl_dev); > > > > > > Such a thread name is too long. > > > This is reverting Thomas change. > > > > > > Is this intentional? > > > > Yes, as mentioned in git commit log. Are 19 characters OK, right? If > > The commitlog was ambiguous. > > > not, I will reduce it, "outb-poll" too generic. > > The thread name max length in pthread API is 16 bytes (including the > trailing \0). > > Besides, looking again at this driver, I suspect Thomas missed it > because of the plt_ prefix, when doing ce703c47de95 ("eal: force > prefix for internal threads"). > Converting to the internal API would restrict the name down to 11 > bytes (including \0). Ack and Thanks. I will remove name change from my patch then. > > > -- > David Marchand >