From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10D53A0540; Mon, 4 Jul 2022 15:00:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01C68410E5; Mon, 4 Jul 2022 15:00:06 +0200 (CEST) Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by mails.dpdk.org (Postfix) with ESMTP id F1AA840E09 for ; Mon, 4 Jul 2022 15:00:04 +0200 (CEST) Received: by mail-qt1-f171.google.com with SMTP id q16so9752072qtn.5 for ; Mon, 04 Jul 2022 06:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d0WS8gWqnrHwm46rDMu8eadzecYNXNnES3YqTuvYryU=; b=hLAmMl6tDnopoN+y2XV3wEsVUC+iHicT9ApEDXNkFo0g7Vf9GOGNXaS4ROL7WuAvs5 WE8CrGtFwgBGzj26VRLgKz8WZY2zSur2iJREOUwWLeJ0boALDSy8rgiEx/NcvjIWbWkl 0LROS/IAV2tEdbZGhluPYvaolN4DbqKbItq5ENHkxrqFaQFMvKRNbnGrQOik4xV4w/vP fkjLb8BMDhPtKslVMe58cIQOyZAU69qgMrymmPXOx0TScuAzDhDRdaIUE1A6AC1TsXo4 LsbObO2SQwiP17l9V1sw490VjNmH8IGeVM/fC40ZL0JvM0PQjExlgudITARw6PDhES4B se+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d0WS8gWqnrHwm46rDMu8eadzecYNXNnES3YqTuvYryU=; b=J+DaUL94nQr3UzNB8myACZvKRCZUfkQyEDl6tjg9NsnTC4KZiHKS0TXvYVGtQPwW4j g6796qq2fPHl0MS8Jf6kq3iCWSxuEvF7mJJcH5kuXDsywCCXC6lso1RgiCEqAOfJzFaz +u31DeLDAvlye8vfM5t8x7Da9NffD+CnR2ybG4GLyIKmvjqgtrBV39YZQs+RVoTaBSUU XMj5GPQ2Q2CFHSzVg09Cpz47fvdn7jkbfKYDNrMrHyr+3ZbIPmMqKORwlHu7+1yQrayC yGmXdJqMX7eOe6+mAuHRsiDN85m7uyAmJPo6nP2VaNHbE9UGi+k0DWiW3KSOzqm03Ltd QqfA== X-Gm-Message-State: AJIora8pRM5ytZbmwLPKo1D2UWtim+02je/zZpPqL2CylgAmBGbKPWC3 FYcAoXdK7Nec5lnx2Ighux30sAC5m+I6QZ0GdfXKItRpEqDGQw== X-Google-Smtp-Source: AGRyM1sVbgzUprVNTOk/ryNKGR+N5iM57ZZNW6CA0Y+YV80Qv8bxAEgJ4vWXERaua07sz1ORgYdo3MlMc2XBrdvE8C4= X-Received: by 2002:ac8:5b06:0:b0:31d:3b22:c8dd with SMTP id m6-20020ac85b06000000b0031d3b22c8ddmr12731039qtw.410.1656939604321; Mon, 04 Jul 2022 06:00:04 -0700 (PDT) MIME-Version: 1.0 References: <20220701125110.512275-1-rkudurumalla@marvell.com> In-Reply-To: <20220701125110.512275-1-rkudurumalla@marvell.com> From: Jerin Jacob Date: Mon, 4 Jul 2022 18:29:38 +0530 Message-ID: Subject: Re: [PATCH] net/cnxk: fix to display extended stats To: Rakesh Kudurumalla Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dpdk-dev , Jerin Jacob Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 1, 2022 at 6:21 PM Rakesh Kudurumalla wrote: > > This fix replaces the usage of roc_nix_num_xstats_get() > which is compile time api with runtime api > roc_nix_xstats_names_get() resolving xstat count > difference for cn9k and cn10k while displaying xstats > for dpdk ports > > Fixes: 825bd1d9d8e6 ("common/cnxk: update extra stats for inline device") > > Signed-off-by: Rakesh Kudurumalla Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks net/cnxk: fix to display extended stats This fix replaces the usage of roc_nix_num_xstats_get() which is compile time RoC API with runtime RoC roc_nix_xstats_names_get() API resolving xstat count difference for cn9k and cn10k while displaying xstats for ethdev ports Fixes: 825bd1d9d8e6 ("common/cnxk: update extra stats for inline device") Cc: stable@dpdk.org Signed-off-by: Rakesh Kudurumalla > --- > drivers/net/cnxk/cnxk_stats.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/cnxk/cnxk_stats.c b/drivers/net/cnxk/cnxk_stats.c > index 4b0deac05e..f2f2222c89 100644 > --- a/drivers/net/cnxk/cnxk_stats.c > +++ b/drivers/net/cnxk/cnxk_stats.c > @@ -172,7 +172,7 @@ cnxk_nix_xstats_get_names(struct rte_eth_dev *eth_dev, > struct roc_nix *nix = &dev->nix; > int roc_size, size, i, q; > > - roc_size = roc_nix_num_xstats_get(nix); > + roc_size = roc_nix_xstats_names_get(nix, NULL, 0); > /* Per Queue statistics also returned as part of xstats */ > size = roc_size + (dev->nb_rxq * CNXK_NB_RXQ_STATS) + > (dev->nb_txq * CNXK_NB_TXQ_STATS); > @@ -232,7 +232,7 @@ cnxk_nix_xstats_get_names_by_id(struct rte_eth_dev *eth_dev, > unsigned int limit) > { > struct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev); > - uint32_t nix_cnt = roc_nix_num_xstats_get(&dev->nix); > + uint32_t nix_cnt = roc_nix_xstats_names_get(&dev->nix, NULL, 0); > uint32_t stat_cnt = nix_cnt + (dev->nb_rxq * CNXK_NB_RXQ_STATS) + > (dev->nb_txq * CNXK_NB_TXQ_STATS); > struct rte_eth_xstat_name xnames[stat_cnt]; > @@ -265,7 +265,7 @@ cnxk_nix_xstats_get_by_id(struct rte_eth_dev *eth_dev, const uint64_t *ids, > uint64_t *values, unsigned int n) > { > struct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev); > - uint32_t nix_cnt = roc_nix_num_xstats_get(&dev->nix); > + uint32_t nix_cnt = roc_nix_xstats_names_get(&dev->nix, NULL, 0); > uint32_t stat_cnt = nix_cnt + (dev->nb_rxq * CNXK_NB_RXQ_STATS) + > (dev->nb_txq * CNXK_NB_TXQ_STATS); > struct rte_eth_xstat xstats[stat_cnt]; > -- > 2.25.1 >