From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E994A0C51; Thu, 10 Jun 2021 08:54:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F41914067C; Thu, 10 Jun 2021 08:54:20 +0200 (CEST) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mails.dpdk.org (Postfix) with ESMTP id 606FC4003C for ; Thu, 10 Jun 2021 08:54:19 +0200 (CEST) Received: by mail-io1-f54.google.com with SMTP id a6so25697537ioe.0 for ; Wed, 09 Jun 2021 23:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZIk1nxDS8osKnI10jYOHEpPLjPYpCJeLPJuk9zE3lwg=; b=O/34UnofXMH+vISeWNyFYbcgeY4RVSFxidOXySEzKcJ9HD+vwd9TBmtxo6LU2r6trg AUpCr8fLWBqjxqaCNxjutrfYmE8+wzhCbVTFpvDEu2cR8KQjIgElb+0tOGVuy/0qHnBg bPnqZGXliqNvFKVKS+SOym40gzFZ4EXIoiVd5j/53X562MS0Imh00lTiTuuctvPFgOCy THu1Hxc5zKf/OmRKCRgfPk7hWm2mwVP2bS07L5IaKq5L3NjBe8ruWdQYeeBGhnrooYbd O8tsCl/KaER+coXrOQOc2b3vsIw4gjmfo3D1xAlwWq1edP80UP6kP8RZui/7kd0kiTIU fSMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZIk1nxDS8osKnI10jYOHEpPLjPYpCJeLPJuk9zE3lwg=; b=s+tBLY6h2i7Ip4sZ/IIHbZipJtpiISfFdA4LcYT2z91HesQn4hxVZUmPYrQ11xYrAd HXo4fWz+Oh0eK/IpO8IqytX+ory0CCEuoiC2u30lrQIbWRx0zsUqPUFwJbzzy2EQdVf0 zHtnqWmEYaIO18P4YUeHnMmNQixgXnxgtLay3V0l25QoHRT2jxrsRproiYY22A9xTcEy wtPqGJLVddRo749rGECyZ3z5fUNRHGFrZdu1MyU17CNV34OyFge3rvkVVBzEKvd8mKQV qSRRE2YQQXqU1lmgzoiOw36uiOIzZlUBf/hM/j5YJJAlDYi55uRya/hn6VYhYZWXOqnv Du7A== X-Gm-Message-State: AOAM5303JjDQL3ja0uPriIoRMN8OJ2XQIRsB4ZGe8/1oBLlwUpzBbO4P Ch5hHII4mzUchOFqIydpeeFOcyu6dUyr14Egcxw= X-Google-Smtp-Source: ABdhPJyMzFxBGGCsva6BYv1H1Qr7FvTEj8mnfJ8I6sxcuaCtfOfS0gpcO6WVJD4ElB51RGEIex+nwb6QeFsjlPNy1Fg= X-Received: by 2002:a05:6638:2190:: with SMTP id s16mr3176816jaj.133.1623308058667; Wed, 09 Jun 2021 23:54:18 -0700 (PDT) MIME-Version: 1.0 References: <20210531214142.30167-1-tduszynski@marvell.com> In-Reply-To: <20210531214142.30167-1-tduszynski@marvell.com> From: Jerin Jacob Date: Thu, 10 Jun 2021 12:24:02 +0530 Message-ID: To: Tomasz Duszynski Cc: dpdk-dev , jpalider@marvell.com, Jerin Jacob Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 00/28] add support for baseband phy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 1, 2021 at 3:11 AM Tomasz Duszynski wrote: > > This series adds initial support for baseband PHY available on SOCs > belonging to Fusion family. BPHY is a hardware block comprising > accelerators and DSPs specifically tailored for 5G/LTE usecases. 5G/LTE inline use cases. > > This series introduces two rawdev PMDs along with low level common code. > > CGX/RPM PMD allows one to configure Ethernet I/O interfaces attached to > BPHY via standard enqueue/dequeue operations. > > BPHY PMD provides an out-of-band access to PCI device BARs and a set of > experimental APIs allowing one to setup custom IRQs handlers. This > functionality is backed by kernel module using ioctl() mechanism. Also, you can mention that This patch adds support for exposing the IO and system aspects of the device and not anything related to 5G/LTE baseband protocol processing. Other than the minor review comments which I sent earlier. I think, We need improvement in the documentation area Where 1) Need to share the API usage model as it is raw dev API. See example as http://doc.dpdk.org/guides/rawdevs/ioat.html#using-ioat-rawdev-devices 2) Move usage doc update move to specific patch where it adding the code. > > Tomasz Duszynski (28): > common/cnxk: add bphy cgx/rpm initialization and cleanup > common/cnxk: add support for communication with atf > common/cnxk: add support for getting link information > common/cnxk: add support for changing internal loopback > common/cnxk: add support for changing ptp mode > common/cnxk: add support for setting link mode > common/cnxk: add support for changing link state > common/cnxk: add support for lmac start/stop > raw/cnxk_bphy: add bphy cgx/rpm skeleton driver > raw/cnxk_bphy: add support for reading queue configuration > raw/cnxk_bphy: add support for reading queue count > raw/cnxk_bphy: add support for enqueue operation > raw/cnxk_bphy: add support for dequeue operation > raw/cnxk_bphy: add support for performing selftest > common/cnxk: add support for device init and fini > common/cnxk: add support for baseband phy irq setup > common/cnxk: add support for checking irq availability > common/cnxk: add support for retrieving irq stack > common/cnxk: add support for removing irq stack > common/cnxk: add support for setting bphy irq handler > common/cnxk: add support for clearing bphy irq handler > common/cnxk: add support for registering bphy irq > raw/cnxk_bphy: add baseband phy skeleton driver > raw/cnxk_bphy: add support for interrupt init and cleanup > raw/cnxk_bphy: add support for reading number of irqs > raw/cnxk_bphy: add support for retrieving device memory > raw/cnxk_bphy: add support for registering irq handlers > raw/cnxk_bphy: add support for selftest > > MAINTAINERS | 5 + > doc/guides/rawdevs/cnxk_bphy.rst | 62 +++ > doc/guides/rawdevs/index.rst | 1 + > drivers/common/cnxk/meson.build | 3 + > drivers/common/cnxk/roc_api.h | 7 + > drivers/common/cnxk/roc_bphy.c | 40 ++ > drivers/common/cnxk/roc_bphy.h | 17 + > drivers/common/cnxk/roc_bphy_cgx.c | 396 +++++++++++++++++++ > drivers/common/cnxk/roc_bphy_cgx.h | 120 ++++++ > drivers/common/cnxk/roc_bphy_cgx_priv.h | 131 +++++++ > drivers/common/cnxk/roc_bphy_irq.c | 422 +++++++++++++++++++++ > drivers/common/cnxk/roc_bphy_irq.h | 49 +++ > drivers/common/cnxk/roc_idev.c | 1 + > drivers/common/cnxk/roc_idev_priv.h | 2 + > drivers/common/cnxk/roc_io.h | 9 + > drivers/common/cnxk/roc_io_generic.h | 5 + > drivers/common/cnxk/roc_priv.h | 3 + > drivers/common/cnxk/version.map | 22 ++ > drivers/raw/cnxk_bphy/cnxk_bphy.c | 250 ++++++++++++ > drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c | 321 ++++++++++++++++ > drivers/raw/cnxk_bphy/cnxk_bphy_cgx.h | 10 + > drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c | 206 ++++++++++ > drivers/raw/cnxk_bphy/cnxk_bphy_irq.c | 100 +++++ > drivers/raw/cnxk_bphy/cnxk_bphy_irq.h | 40 ++ > drivers/raw/cnxk_bphy/meson.build | 12 + > drivers/raw/cnxk_bphy/rte_pmd_bphy.h | 121 ++++++ > drivers/raw/cnxk_bphy/version.map | 22 ++ > drivers/raw/meson.build | 1 + > usertools/dpdk-devbind.py | 6 +- > 29 files changed, 2383 insertions(+), 1 deletion(-) > create mode 100644 doc/guides/rawdevs/cnxk_bphy.rst > create mode 100644 drivers/common/cnxk/roc_bphy.c > create mode 100644 drivers/common/cnxk/roc_bphy.h > create mode 100644 drivers/common/cnxk/roc_bphy_cgx.c > create mode 100644 drivers/common/cnxk/roc_bphy_cgx.h > create mode 100644 drivers/common/cnxk/roc_bphy_cgx_priv.h > create mode 100644 drivers/common/cnxk/roc_bphy_irq.c > create mode 100644 drivers/common/cnxk/roc_bphy_irq.h > create mode 100644 drivers/raw/cnxk_bphy/cnxk_bphy.c > create mode 100644 drivers/raw/cnxk_bphy/cnxk_bphy_cgx.c > create mode 100644 drivers/raw/cnxk_bphy/cnxk_bphy_cgx.h > create mode 100644 drivers/raw/cnxk_bphy/cnxk_bphy_cgx_test.c > create mode 100644 drivers/raw/cnxk_bphy/cnxk_bphy_irq.c > create mode 100644 drivers/raw/cnxk_bphy/cnxk_bphy_irq.h > create mode 100644 drivers/raw/cnxk_bphy/meson.build > create mode 100644 drivers/raw/cnxk_bphy/rte_pmd_bphy.h > create mode 100644 drivers/raw/cnxk_bphy/version.map > > -- > 2.25.1 >