From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1896841C49; Thu, 9 Feb 2023 08:31:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9D2B40DDA; Thu, 9 Feb 2023 08:31:44 +0100 (CET) Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) by mails.dpdk.org (Postfix) with ESMTP id A5D284067B for ; Thu, 9 Feb 2023 08:31:43 +0100 (CET) Received: by mail-vk1-f172.google.com with SMTP id i38so531317vkd.0 for ; Wed, 08 Feb 2023 23:31:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i7lDmG3PLD1GAwptwdhMNA2CwLFOnDsfKvpg1uikrTw=; b=kD5tiSbFmrtUomONpOdjtj3QxP0bA8gmlT6F9D2m1moKN2RKxkRyuMpgZyr8mJTl6m IZFASDL8U8ywB8hTp0ZaAKza5+1dO7i0nGYoJ89WkqvMm8uPH6JvzsETb8//VNbMX0o/ Dpil4sZpIEPgJRYpLkf28h9vgg9IRCVYSSkS1dKe2MwrbMXsVrG12OVEvQRMJOZvpiCe GYWEmDonHFKCB2joP0uNA4Z099ANnqZa8unoDZUzrFed6SschfN1woF5G/qWT70xNItT wUnArpMfB88yFCbyRxPqHpmAM8ApThP/du1Ktu3Gb8hEtirn4AdxE5jN/4gEPbwl/BeK N73Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i7lDmG3PLD1GAwptwdhMNA2CwLFOnDsfKvpg1uikrTw=; b=DHnBhKrfv0Fap3moG+7Pz43TEVuT5vdDEedvTRY6HSTiHn4k0QHDDk5GCTKNU2Qe5E 88p4PO6X0IBn9qmlGsOGGyEbxOjzOs9Kh0oZs+h48UOG7k20FCZ8iJhrh8bmgV+4XFVk meaDJzGzLFM0lNhKxHfGit5NpPqq13HtEe5YIE8DhYThidz0fFkd+6wUk0QdU3WBXUc6 ttjN1kI4G4fsrEtFdi7jZGsmhyQC6i6lgqaeoT8NlJxd85whflSp4X3yUN5UZRFJyJ1R ecZSZC1IWBO07lnfUAJBxCaAi5jV8gYeLjrXb9KfIWrEjmGux/suq3YBNpLeJ6Gp1O6g fA8w== X-Gm-Message-State: AO0yUKUU6YeDvhfl9jPkYAdbYTq2Ju2bW+G515wJfFrJY9jUBdAaIDLM UxVsKfFeRwfFiowqO5I0woJ4HXRwU4JzHUyqbCk= X-Google-Smtp-Source: AK7set8YOISedtGwwOrlT91TWFSLqxjU50SghTTTq6+u6tWJQaFR022AuldNEiHEG+0cQ64bVftKbjORzgUyKAlTDwk= X-Received: by 2002:a05:6122:1461:b0:3d5:d30f:81c2 with SMTP id r1-20020a056122146100b003d5d30f81c2mr2085734vkp.14.1675927902923; Wed, 08 Feb 2023 23:31:42 -0800 (PST) MIME-Version: 1.0 References: <20230125073231.4007078-1-rkudurumalla@marvell.com> <20230209072402.957747-1-rkudurumalla@marvell.com> In-Reply-To: <20230209072402.957747-1-rkudurumalla@marvell.com> From: Jerin Jacob Date: Thu, 9 Feb 2023 13:01:16 +0530 Message-ID: Subject: Re: [PATCH v3 1/3] lib: skip congestion management configuration To: Rakesh Kudurumalla Cc: Ori Kam , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , jerinj@marvell.com, ndabilpuram@marvell.com, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 9, 2023 at 12:54 PM Rakesh Kudurumalla wrote: > > Skip the congestion management configuration applied using > rte_eth_cman_config_set() API on the given ethdev Rx queue. > > Signed-off-by: Rakesh Kudurumalla > --- > v3: Updated comments and programmers guide regrading > new action > doc/guides/prog_guide/rte_flow.rst | 22 ++++++++++++++++++++++ > lib/ethdev/rte_flow.h | 20 ++++++++++++++++++++ > 2 files changed, 42 insertions(+) > > diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst > index 3e6242803d..0737b877da 100644 > --- a/doc/guides/prog_guide/rte_flow.rst > +++ b/doc/guides/prog_guide/rte_flow.rst > @@ -1840,6 +1840,28 @@ Drop packets. > | no properties | > +---------------+ > > + > +Action: ``SKIP_CMAN`` > +^^^^^^^^^^^^^^^^^^^ > + > +Skip congestion management on received packets > + > +- Using ``rte_eth_cman_config_set()``, application can configure ethdev Rx > + queue's congestion mechanism.Once applied packets congestion configuration > + is bypassed on that particular ethdev Rx queue for all packets directed > + to that receive queue > + > +.. _table_rte_flow_action_skip_cman: > + > +.. table:: SKIP_CMAN > + > + +---------------+ > + | Field | > + +===============+ > + | no properties | > + +---------------+ > + > + > Action: ``COUNT`` > ^^^^^^^^^^^^^^^^^ > > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index b60987db4b..5ae00e2245 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -2203,6 +2203,26 @@ enum rte_flow_action_type { > */ > RTE_FLOW_ACTION_TYPE_DROP, > > + /** > + * Skip congestion management configuration > + * > + * ethdev: introduce flow action to skip congestion > + * management configuration This supposes to be git commit heading. > + * > + * Using rte_eth_cman_config_set() API the application > + * can configure ethdev Rx queue's congestion mechanism. > + * Introducing RTE_FLOW_ACTION_TYPE_SKIP_CMAN flow action to skip the > + * congestion configuration applied to the given ethdev Rx queue. This paragraph is OK here. > + * > + * This feature helps to skip the congestion management processing > + * based on per flow or the packet color identified by > + * rte_flow meter object. For example, If one Rx queue configured as > + * RED congestion and application wants tobypass the RED congestion > + * processing for all GREEN color packet can be expressed though > + * RTE_FLOW_ACTION_TYPE_SKIP_CMAN flow action Move this to git commit log > + */ > + RTE_FLOW_ACTION_TYPE_SKIP_CMAN, > + > /** > * Enables counters for this flow rule. > * > -- > 2.25.1 >