DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Akhil Goyal <gakhil@marvell.com>
Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,
	 hemant.agrawal@nxp.com, jerinj@marvell.com, hkalra@marvell.com
Subject: Re: [PATCH 2/9] drivers/raw: introduce cnxk rvu lf device driver
Date: Mon, 23 Sep 2024 20:58:12 +0530	[thread overview]
Message-ID: <CALBAE1M=pRe-wzEcGmTinh+YgxOuuEmnPsxUcM7yXCTUv1E=mg@mail.gmail.com> (raw)
In-Reply-To: <20240907193311.1342310-3-gakhil@marvell.com>

On Sun, Sep 8, 2024 at 1:28 AM Akhil Goyal <gakhil@marvell.com> wrote:
>
> CNXK product families can have a use case to allow PF and VF
> applications to communicate using mailboxes and also get notified
> of any interrupt that may occur on the device.
> Hence, a new raw device driver is added for such RVU LF devices.
> These devices can map to a PF or a VF which can send mailboxes to
> each other.
>
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>

> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(C) 2024 Marvell.
> +#
> +
> +deps += ['bus_pci', 'common_cnxk', 'rawdev']
> +sources = files(
> +        'cnxk_rvu_lf.c',
> +)
> +require_iova_in_mbuf = false
> diff --git a/drivers/raw/cnxk_rvu_lf/rte_pmd_rvu_lf.h b/drivers/raw/cnxk_rvu_lf/rte_pmd_rvu_lf.h
> new file mode 100644
> index 0000000000..2d3cd032b7
> --- /dev/null
> +++ b/drivers/raw/cnxk_rvu_lf/rte_pmd_rvu_lf.h
> @@ -0,0 +1,39 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(C) 2024 Marvell.
> + */
> +
> +#ifndef _CNXK_RVU_LF_H_
> +#define _CNXK_RVU_LF_H_
> +
> +#include <stdint.h>
> +
> +#include <rte_common.h>
> +#include <rte_dev.h>
> +#include <rte_malloc.h>
> +#include <rte_memcpy.h>
> +#include <rte_rawdev.h>


Missing update to doc/api/doxy-api-index.md

> +
> +/**
> + * @file rte_pmd_rvu_lf.h
> + *
> + * Marvell RVU LF raw PMD specific structures and interface
> + *
> + * This API allows applications to manage RVU LF device in user space along with
> + * installing interrupt handlers for low latency signal processing.
> + */
> +
> +#ifdef __cplusplus
> +extern "C" {
> +#endif


> +extern int cnxk_logtype_rvu_lf;

Public symbol. Please add Doxygen symbol

> +
> +#define CNXK_RVU_LF_LOG(level, fmt, args...)   \

Public symbol. Please add Doxygen symbol

> +       rte_log(RTE_LOG_ ## level, cnxk_logtype_rvu_lf, \
> +               "%s(): " fmt "\n", __func__, ## args)
> +

Do we need to make this public symbols?

  reply	other threads:[~2024-09-23 15:28 UTC|newest]

Thread overview: 96+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-07 19:33 [PATCH 0/9] " Akhil Goyal
2024-09-07 19:33 ` [PATCH 1/9] rawdev: add API to get device from index Akhil Goyal
2024-09-23 15:23   ` Jerin Jacob
2024-10-08  7:40   ` [PATCH v2] " Akhil Goyal
2024-10-08 11:59     ` David Marchand
2024-10-08 12:00       ` [EXTERNAL] " Akhil Goyal
2024-10-09 21:13         ` Akhil Goyal
2024-10-21 10:48           ` Akhil Goyal
2024-10-09  6:11     ` Hemant Agrawal
2024-10-22 19:12     ` David Marchand
2024-09-07 19:33 ` [PATCH 2/9] drivers/raw: introduce cnxk rvu lf device driver Akhil Goyal
2024-09-23 15:28   ` Jerin Jacob [this message]
2024-10-08 10:54   ` [PATCH v2 0/9] " Akhil Goyal
2024-10-08 10:54     ` [PATCH v2 1/9] " Akhil Goyal
2024-10-08 10:54     ` [PATCH v2 2/9] raw/cnxk_rvu_lf: add PMD API to get npa/sso pffunc Akhil Goyal
2024-10-08 10:54     ` [PATCH v2 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses Akhil Goyal
2024-10-08 10:54     ` [PATCH v2 4/9] raw/cnxk_rvu_lf: register/unregister interrupt handler Akhil Goyal
2024-10-08 10:54     ` [PATCH v2 5/9] raw/cnxk_rvu_lf: register/unregister msg handler Akhil Goyal
2024-10-08 10:54     ` [PATCH v2 6/9] raw/cnxk_rvu_lf: set message ID range Akhil Goyal
2024-10-08 10:54     ` [PATCH v2 7/9] raw/cnxk_rvu_lf: process mailbox message Akhil Goyal
2024-10-08 10:54     ` [PATCH v2 8/9] raw/cnxk_rvu_lf: add selftest Akhil Goyal
2024-10-08 10:54     ` [PATCH v2 9/9] raw/cnxk_rvu_lf: add PMD API to get device pffunc Akhil Goyal
2024-10-08 11:52     ` [PATCH v2 0/9] drivers/raw: introduce cnxk rvu lf device driver David Marchand
2024-10-08 12:10       ` [EXTERNAL] " Akhil Goyal
2024-10-08 18:49     ` [PATCH v3 " Akhil Goyal
2024-10-08 18:49       ` [PATCH v3 1/9] " Akhil Goyal
2024-10-08 20:44         ` Stephen Hemminger
2024-10-09 18:09         ` Stephen Hemminger
2024-10-09 18:14           ` [EXTERNAL] " Akhil Goyal
2024-10-23 14:01         ` David Marchand
2024-10-08 18:49       ` [PATCH v3 2/9] raw/cnxk_rvu_lf: add PMD API to get npa/sso pffunc Akhil Goyal
2024-10-23 14:13         ` David Marchand
2024-10-08 18:49       ` [PATCH v3 3/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses Akhil Goyal
2024-10-21 21:30         ` Thomas Monjalon
2024-10-22  2:46           ` Jerin Jacob
2024-10-22  6:05             ` [EXTERNAL] " Akhil Goyal
2024-10-22  9:27               ` Thomas Monjalon
2024-10-22 10:08               ` David Marchand
2024-10-22 12:06                 ` Akhil Goyal
2024-10-23 16:00                   ` Thomas Monjalon
2024-10-23 19:14                     ` Akhil Goyal
2024-10-23 19:29                       ` Thomas Monjalon
2024-10-24 13:03                         ` Akhil Goyal
2024-10-22 15:30                 ` Stephen Hemminger
2024-10-22 17:06                   ` Jerin Jacob
2024-10-08 18:49       ` [PATCH v3 4/9] raw/cnxk_rvu_lf: register/unregister interrupt handler Akhil Goyal
2024-10-08 18:49       ` [PATCH v3 5/9] raw/cnxk_rvu_lf: register/unregister msg handler Akhil Goyal
2024-10-08 18:49       ` [PATCH v3 6/9] raw/cnxk_rvu_lf: set message ID range Akhil Goyal
2024-10-08 18:49       ` [PATCH v3 7/9] raw/cnxk_rvu_lf: process mailbox message Akhil Goyal
2024-10-08 18:49       ` [PATCH v3 8/9] raw/cnxk_rvu_lf: add selftest Akhil Goyal
2024-10-23 14:16         ` David Marchand
2024-10-08 18:49       ` [PATCH v3 9/9] raw/cnxk_rvu_lf: add PMD API to get device pffunc Akhil Goyal
2024-10-24 13:01       ` [PATCH v4 0/9] drivers/raw: introduce cnxk rvu lf device driver Akhil Goyal
2024-10-24 13:01         ` [PATCH v4 1/9] " Akhil Goyal
2024-10-24 13:01         ` [PATCH v4 2/9] raw/cnxk_rvu_lf: add API to get NPA/SSO pffunc Akhil Goyal
2024-10-24 13:01         ` [PATCH v4 3/9] raw/cnxk_rvu_lf: register/unregister interrupt handler Akhil Goyal
2024-10-24 13:01         ` [PATCH v4 4/9] raw/cnxk_rvu_lf: register/unregister msg handler Akhil Goyal
2024-10-24 13:01         ` [PATCH v4 5/9] raw/cnxk_rvu_lf: set message ID range Akhil Goyal
2024-10-24 13:01         ` [PATCH v4 6/9] raw/cnxk_rvu_lf: process mailbox message Akhil Goyal
2024-10-24 13:01         ` [PATCH v4 7/9] raw/cnxk_rvu_lf: add API to get device pffunc Akhil Goyal
2024-10-24 13:01         ` [PATCH v4 8/9] raw/cnxk_rvu_lf: add API to get BAR addresses Akhil Goyal
2024-10-24 13:01         ` [PATCH v4 9/9] raw/cnxk_rvu_lf: add selftest Akhil Goyal
2024-10-24 13:17         ` [PATCH v5 0/9] drivers/raw: introduce cnxk rvu lf device driver Akhil Goyal
2024-10-24 13:17           ` [PATCH v5 1/9] " Akhil Goyal
2024-10-24 15:59             ` Jerin Jacob
2024-10-24 13:17           ` [PATCH v5 2/9] raw/cnxk_rvu_lf: add API to get NPA/SSO pffunc Akhil Goyal
2024-10-25  6:52             ` Jerin Jacob
2024-10-25 15:38             ` Stephen Hemminger
2024-10-25 19:48               ` [EXTERNAL] " Akhil Goyal
2024-10-24 13:17           ` [PATCH v5 3/9] raw/cnxk_rvu_lf: register/unregister interrupt handler Akhil Goyal
2024-10-24 13:17           ` [PATCH v5 4/9] raw/cnxk_rvu_lf: register/unregister msg handler Akhil Goyal
2024-10-24 13:17           ` [PATCH v5 5/9] raw/cnxk_rvu_lf: set message ID range Akhil Goyal
2024-10-24 13:17           ` [PATCH v5 6/9] raw/cnxk_rvu_lf: process mailbox message Akhil Goyal
2024-10-24 13:17           ` [PATCH v5 7/9] raw/cnxk_rvu_lf: add API to get device pffunc Akhil Goyal
2024-10-24 13:17           ` [PATCH v5 8/9] raw/cnxk_rvu_lf: add API to get BAR addresses Akhil Goyal
2024-10-24 13:17           ` [PATCH v5 9/9] raw/cnxk_rvu_lf: add selftest Akhil Goyal
2024-10-24 16:26             ` Stephen Hemminger
2024-10-28 11:01           ` [PATCH v6 0/9] drivers/raw: introduce cnxk rvu lf device driver Akhil Goyal
2024-10-28 11:01             ` [PATCH v6 1/9] drivers/raw: introduce cnxk RVU LF " Akhil Goyal
2024-10-28 11:01             ` [PATCH v6 2/9] raw/cnxk_rvu_lf: support NPA/SSO pffunc get Akhil Goyal
2024-10-29 16:10               ` Jerin Jacob
2024-11-04 11:27                 ` Jerin Jacob
2024-10-28 11:01             ` [PATCH v6 3/9] raw/cnxk_rvu_lf: support interrupt callback registration Akhil Goyal
2024-10-28 11:01             ` [PATCH v6 4/9] raw/cnxk_rvu_lf: support msg handler registration Akhil Goyal
2024-10-28 11:01             ` [PATCH v6 5/9] raw/cnxk_rvu_lf: support to set message ID range Akhil Goyal
2024-10-28 11:01             ` [PATCH v6 6/9] raw/cnxk_rvu_lf: support mailbox processing Akhil Goyal
2024-10-28 11:01             ` [PATCH v6 7/9] raw/cnxk_rvu_lf: support device pffunc get Akhil Goyal
2024-10-28 11:01             ` [PATCH v6 8/9] raw/cnxk_rvu_lf: support getting BAR addresses Akhil Goyal
2024-10-28 11:01             ` [PATCH v6 9/9] raw/cnxk_rvu_lf: add selftest Akhil Goyal
2024-09-07 19:33 ` [PATCH 3/9] raw/cnxk_rvu_lf: add PMD API to get npa/sso pffunc Akhil Goyal
2024-09-07 19:33 ` [PATCH 4/9] raw/cnxk_rvu_lf: add PMD API to get BAR addresses Akhil Goyal
2024-09-07 19:33 ` [PATCH 5/9] raw/cnxk_rvu_lf: register/unregister interrupt handler Akhil Goyal
2024-09-07 19:33 ` [PATCH 6/9] raw/cnxk_rvu_lf: register/unregister msg handler Akhil Goyal
2024-09-07 19:33 ` [PATCH 7/9] raw/cnxk_rvu_lf: set message ID range Akhil Goyal
2024-09-07 19:33 ` [PATCH 8/9] raw/cnxk_rvu_lf: process mailbox message Akhil Goyal
2024-09-07 19:33 ` [PATCH 9/9] raw/cnxk_rvu_lf: add selftest Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1M=pRe-wzEcGmTinh+YgxOuuEmnPsxUcM7yXCTUv1E=mg@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=gakhil@marvell.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=hkalra@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).