From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D5D7A04C5; Fri, 15 Nov 2019 11:18:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 502CB2C15; Fri, 15 Nov 2019 11:17:59 +0100 (CET) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id C16A22C12 for ; Fri, 15 Nov 2019 11:17:57 +0100 (CET) Received: by mail-io1-f65.google.com with SMTP id q83so9909800iod.1 for ; Fri, 15 Nov 2019 02:17:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FRutZNUmsl37YMUYuWCSXQPcitivcII5RtRqXAnO5OU=; b=r7pZjHbAz2N5jr4UMslf4IjQ+RZgExTdLH+ctND3OTW1bwAGCUUWHAIy2VLrJfikJf bLzwwHYnhRtmrISINcYzdpF0os9GJ3dfg+zepiLVq5mxJuYArPQ4mRLAJRpaHBdEIbwb iSggJiBBl1zuPV71asDEaVZmXDmdWza01KqS9dQgqMaulK+pfJtSgFFA1tP92yBeF+bc BCUP/GRuXvvPJa+mAaNKeiLD+wBLImnO7yoL+/RUld4STihoEHpBsQ8XAplksVhJhkzL RPCpS844h+jkflfhJz/k959PHRXACCVyt05ZbiI4hecdh5q9f5At3kRr9avtqH/ROftp aj6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FRutZNUmsl37YMUYuWCSXQPcitivcII5RtRqXAnO5OU=; b=jHMW6JklAF265P1re7ebfZiGb0hKKL6niiE2s59aojEv4JQUJakquNV2YGonQxnOsc Pi/+zMq0WOEZEXDbziQsnNdnXkhqKQ5D4YwQXj+8rn0FQ+t9G6X8+GHvv1lQ5bXFWrXg U531uX4Avmcy4+q0kTrqh12nlJ8qpsfE2G0zwXFa+zpB0IVgZDrv+5FBdTbLufToz00W bAGBdrEPP3nDOrlkZjtw5iacUyyguD3lwRea9enTdW8wcJBnitrZlgojneKqE7Thtp2L BfrAYtbjZnAbQkUfHTa3XKZ6vpCnbrKmxhnL+rY1m1zSaJctAYoHovxC/8TLb7uUluwq WsjQ== X-Gm-Message-State: APjAAAU/DFHx9JzrBgO7t/xosR3xxY8j3/7JGdomu9whbC4KZ0vrZOCx gUVO8oUQ4hluSOY/KtSPqlRcmY+gxanAZI7/4yk= X-Google-Smtp-Source: APXvYqwjWVuDcLjeqfeWAIK6ngvgHCoAs2i78REH7vuMv0ITN0NcOvYdPdLGWV/sYJXTLTsa6MuG2k0Z0wuBK4gqzhA= X-Received: by 2002:a6b:e403:: with SMTP id u3mr13523803iog.130.1573813076710; Fri, 15 Nov 2019 02:17:56 -0800 (PST) MIME-Version: 1.0 References: <20191017165147.7054-1-pbhagavatula@marvell.com> <20191107025254.4297-1-pbhagavatula@marvell.com> In-Reply-To: <20191107025254.4297-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Fri, 15 Nov 2019 15:47:40 +0530 Message-ID: To: Pavan Nikhilesh , Ferruh Yigit Cc: Jerin Jacob , Nithin Dabilpuram , Kiran Kumar K , John McNamara , Marko Kovacevic , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4] net/octeontx2: add set supported types op X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 7, 2019 at 8:23 AM wrote: > > From: Pavan Nikhilesh > > Add support to set supported ptypes for octeontx2. Added extra git commit log: Add support to set supported ptypes for octeontx2 and remove devarg scheme to disable ptype parsing support as application can use rte_eth_dev_set_ptypes() normative API to enable the same use case. > > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob Applied to dpdk-next-net-mrvl/master. Thanks > --- > v4 Changes: > ---------- > - Rebase onto series > http://patches.dpdk.org/project/dpdk/list/?series=7302. > > v3 Changes: > ---------- > - Actually update doc file. > > v2 Changes: > ---------- > - Update documentation. > - Use positive logic. > > doc/guides/nics/octeontx2.rst | 5 ----- > drivers/net/octeontx2/otx2_ethdev.c | 1 + > drivers/net/octeontx2/otx2_ethdev.h | 1 + > drivers/net/octeontx2/otx2_ethdev_devargs.c | 21 --------------------- > drivers/net/octeontx2/otx2_lookup.c | 15 +++++++++++++++ > 5 files changed, 17 insertions(+), 26 deletions(-) > > diff --git a/doc/guides/nics/octeontx2.rst b/doc/guides/nics/octeontx2.rst > index eb7aaa468..026df44e6 100644 > --- a/doc/guides/nics/octeontx2.rst > +++ b/doc/guides/nics/octeontx2.rst > @@ -113,11 +113,6 @@ use arm64-octeontx2-linux-gcc as target. > Runtime Config Options > ---------------------- > > -- ``HW offload ptype parsing disable`` (default ``0``) > - > - Packet type parsing is HW offloaded by default and this feature may be toggled > - using ``ptype_disable`` ``devargs`` parameter. > - > - ``Rx&Tx scalar mode enable`` (default ``0``) > > Ethdev supports both scalar and vector mode, it may be selected at runtime > diff --git a/drivers/net/octeontx2/otx2_ethdev.c b/drivers/net/octeontx2/otx2_ethdev.c > index dfa8cd205..db18e4cb9 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.c > +++ b/drivers/net/octeontx2/otx2_ethdev.c > @@ -1983,6 +1983,7 @@ static const struct eth_dev_ops otx2_eth_dev_ops = { > .dev_set_link_up = otx2_nix_dev_set_link_up, > .dev_set_link_down = otx2_nix_dev_set_link_down, > .dev_supported_ptypes_get = otx2_nix_supported_ptypes_get, > + .dev_ptypes_set = otx2_nix_ptypes_set, > .dev_reset = otx2_nix_dev_reset, > .stats_get = otx2_nix_dev_stats_get, > .stats_reset = otx2_nix_dev_stats_reset, > diff --git a/drivers/net/octeontx2/otx2_ethdev.h b/drivers/net/octeontx2/otx2_ethdev.h > index 4d9ed4870..b65891a5b 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.h > +++ b/drivers/net/octeontx2/otx2_ethdev.h > @@ -525,6 +525,7 @@ void *otx2_nix_fastpath_lookup_mem_get(void); > > /* PTYPES */ > const uint32_t *otx2_nix_supported_ptypes_get(struct rte_eth_dev *dev); > +int otx2_nix_ptypes_set(struct rte_eth_dev *eth_dev, uint32_t ptype_mask); > > /* Mac address handling */ > int otx2_nix_mac_addr_set(struct rte_eth_dev *eth_dev, > diff --git a/drivers/net/octeontx2/otx2_ethdev_devargs.c b/drivers/net/octeontx2/otx2_ethdev_devargs.c > index ca9a5ffb8..04da1abbd 100644 > --- a/drivers/net/octeontx2/otx2_ethdev_devargs.c > +++ b/drivers/net/octeontx2/otx2_ethdev_devargs.c > @@ -63,21 +63,6 @@ parse_reta_size(const char *key, const char *value, void *extra_args) > return 0; > } > > -static int > -parse_ptype_flag(const char *key, const char *value, void *extra_args) > -{ > - RTE_SET_USED(key); > - uint32_t val; > - > - val = atoi(value); > - if (val) > - val = 0; /* Disable NIX_RX_OFFLOAD_PTYPE_F */ > - > - *(uint16_t *)extra_args = val; > - > - return 0; > -} > - > static int > parse_flag(const char *key, const char *value, void *extra_args) > { > @@ -119,7 +104,6 @@ parse_switch_header_type(const char *key, const char *value, void *extra_args) > } > > #define OTX2_RSS_RETA_SIZE "reta_size" > -#define OTX2_PTYPE_DISABLE "ptype_disable" > #define OTX2_SCL_ENABLE "scalar_enable" > #define OTX2_MAX_SQB_COUNT "max_sqb_count" > #define OTX2_FLOW_PREALLOC_SIZE "flow_prealloc_size" > @@ -129,7 +113,6 @@ parse_switch_header_type(const char *key, const char *value, void *extra_args) > int > otx2_ethdev_parse_devargs(struct rte_devargs *devargs, struct otx2_eth_dev *dev) > { > - uint16_t offload_flag = NIX_RX_OFFLOAD_PTYPE_F; > uint16_t rss_size = NIX_RSS_RETA_SIZE; > uint16_t sqb_count = NIX_MAX_SQB; > uint16_t flow_prealloc_size = 8; > @@ -145,8 +128,6 @@ otx2_ethdev_parse_devargs(struct rte_devargs *devargs, struct otx2_eth_dev *dev) > if (kvlist == NULL) > goto exit; > > - rte_kvargs_process(kvlist, OTX2_PTYPE_DISABLE, > - &parse_ptype_flag, &offload_flag); > rte_kvargs_process(kvlist, OTX2_RSS_RETA_SIZE, > &parse_reta_size, &rss_size); > rte_kvargs_process(kvlist, OTX2_SCL_ENABLE, > @@ -162,7 +143,6 @@ otx2_ethdev_parse_devargs(struct rte_devargs *devargs, struct otx2_eth_dev *dev) > rte_kvargs_free(kvlist); > > null_devargs: > - dev->rx_offload_flags = offload_flag; > dev->scalar_ena = scalar_enable; > dev->max_sqb_count = sqb_count; > dev->rss_info.rss_size = rss_size; > @@ -177,7 +157,6 @@ otx2_ethdev_parse_devargs(struct rte_devargs *devargs, struct otx2_eth_dev *dev) > > RTE_PMD_REGISTER_PARAM_STRING(net_octeontx2, > OTX2_RSS_RETA_SIZE "=<64|128|256>" > - OTX2_PTYPE_DISABLE "=1" > OTX2_SCL_ENABLE "=1" > OTX2_MAX_SQB_COUNT "=<8-512>" > OTX2_FLOW_PREALLOC_SIZE "=<1-32>" > diff --git a/drivers/net/octeontx2/otx2_lookup.c b/drivers/net/octeontx2/otx2_lookup.c > index 3071278fc..17c44e20e 100644 > --- a/drivers/net/octeontx2/otx2_lookup.c > +++ b/drivers/net/octeontx2/otx2_lookup.c > @@ -62,6 +62,21 @@ otx2_nix_supported_ptypes_get(struct rte_eth_dev *eth_dev) > return NULL; > } > > +int > +otx2_nix_ptypes_set(struct rte_eth_dev *eth_dev, uint32_t ptype_mask) > +{ > + struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev); > + > + if (ptype_mask) > + dev->rx_offload_flags |= NIX_RX_OFFLOAD_PTYPE_F; > + else > + dev->rx_offload_flags &= ~NIX_RX_OFFLOAD_PTYPE_F; > + > + otx2_eth_set_rx_function(eth_dev); > + > + return 0; > +} > + > /* > * +------------------ +------------------ + > * | | IL4 | IL3| IL2 | TU | L4 | L3 | L2 | > -- > 2.17.1 >