From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 662A2A034C; Fri, 21 Jan 2022 10:38:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4A81E42739; Fri, 21 Jan 2022 10:38:11 +0100 (CET) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by mails.dpdk.org (Postfix) with ESMTP id BB21F40042 for ; Fri, 21 Jan 2022 10:38:09 +0100 (CET) Received: by mail-io1-f52.google.com with SMTP id y22so10138708iof.7 for ; Fri, 21 Jan 2022 01:38:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VXkG0upTt6rIgFCYsjUwBraPQX8Kmm1dHaaNI8j0wPY=; b=Rf1/AcT/DwdpdFaTuZ40FE16+G0/CijwqAWOvnGywcWiL2Nf5UCjEap9D6CZyYvS4Z Kwj0gJmII2b3FrD7waM+Sue5Jiwu+M6ttMAz3AoVo5KRsFRG91rZwwmHe6vo/kZ/Fgsl BNisFHn53lbIbkQq3pp5XaOqHt3whjLoi9qnqBD/hFY/hZa9HK6/dSaikMvHhl95FCag G1dNaZrJ5K22tGa53YXdk/H80vyLKvNWCDoY0gDf6SZvCcBESGR3Beq7wkaFBkE1o8G/ 0GN1HA48DYYRe98V0OdlaKYEjOHN09V+nEGuCVgZB6uurCyx/TO6CbnJT8HZjCbdSuhJ q5Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VXkG0upTt6rIgFCYsjUwBraPQX8Kmm1dHaaNI8j0wPY=; b=yhEgZXoUQCg42BM5Dcn4UEtJmoNoQ24AwU5Kh92zYxvFNY2MhfxBO5TdDzJvS2aIdI I7W4w6uj0YonMvLrME8cqyzL5xDDTtzDLiuGgg55rsVAOi/Zl1nApcdl2UGHcp/dB+AL NSuAp4QUZO4cgC1bIxv2Bc+w3CqLWfEnjTZoPxJ4E/gO9b5qbajazP3iV89QcDNblJYo 1LoNgGU94/Fjv/wqFzp+eABFtWersLWRMIUf5J/iMf9YBiKMXzv80ByW+86k3C2NWugB XvwKS7qDeu1bS8vYbfPCFZEiU/MW/bK1lCsQAKPcLZuFlEvDzxZlnGDxIMz/77r4Kb5I /vsw== X-Gm-Message-State: AOAM533fN53Q6TJ3aDVCNTSedNRzNKeW5XAV7nThsynENtL8ZtEsQ4PD anLiPgkOapVBC7bCn0HkErsJ8r+mYcp6IbAHIVs= X-Google-Smtp-Source: ABdhPJxUwuFOsGwWJYb40ChnqctUKtIqzbWUU2LTjptxjHGd/XGGn5KfP3TX6zilqHEtg0pnhzpP4gvShvEIp81K06Y= X-Received: by 2002:a05:6602:c2:: with SMTP id z2mr1511424ioe.25.1642757889109; Fri, 21 Jan 2022 01:38:09 -0800 (PST) MIME-Version: 1.0 References: <20211213110615.4458-1-pbhagavatula@marvell.com> In-Reply-To: From: Jerin Jacob Date: Fri, 21 Jan 2022 15:07:43 +0530 Message-ID: Subject: Re: [PATCH] config/cn10k: align mempool elements to 128 bytes To: Ruifeng Wang , Ferruh Yigit , Thomas Monjalon Cc: "pbhagavatula@marvell.com" , "jerinj@marvell.com" , Jan Viktorin , Bruce Richardson , "dev@dpdk.org" , nd Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jan 20, 2022 at 3:21 PM Jerin Jacob wrote: > > On Tue, Dec 14, 2021 at 2:53 PM Ruifeng Wang wrote: > > > > > -----Original Message----- > > > From: pbhagavatula@marvell.com > > > Sent: Monday, December 13, 2021 7:06 PM > > > To: jerinj@marvell.com; Jan Viktorin ; Ruifeng > > > Wang ; Bruce Richardson > > > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > > Subject: [PATCH] config/cn10k: align mempool elements to 128 bytes > > > > > > From: Pavan Nikhilesh > > > > > > Mempool elements are by default aligned to CACHELINE_SIZE. > > > In CN10K cacheline size is 64B but the RoC requires buffers to be aligned to > > > 128B. > > > Set RTE_MEMPOOL_ALIGN to 128 to force mempool buffers to be aligned > > > 128 bytes. > > > > > > Signed-off-by: Pavan Nikhilesh > > > --- > > > config/arm/meson.build | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/config/arm/meson.build b/config/arm/meson.build index > > > 213324d262..33afe1a9ad 100644 > > > --- a/config/arm/meson.build > > > +++ b/config/arm/meson.build > > > @@ -276,7 +276,8 @@ soc_cn10k = { > > > 'implementer' : '0x41', > > > 'flags': [ > > > ['RTE_MAX_LCORE', 24], > > > - ['RTE_MAX_NUMA_NODES', 1] > > > + ['RTE_MAX_NUMA_NODES', 1], > > > + ['RTE_MEMPOOL_ALIGN', 128] > > > ], > > > 'part_number': '0xd49', > > > 'extra_march_features': ['crypto'], > > > -- > > > 2.17.1 > > > > Reviewed-by: Ruifeng Wang > > Applied to dpdk-next-net-mrvl/for-next-net. Thanks As per @Ferruh Yigit suggestion, This patch will be taken through the main tree. I changed state as New and Delegate as @Thomas Monjalon for this patch in pw. > > > Added > Fixes: 1b4c86a721c9 ("config/arm: add Marvell CN10K") > Cc: stable@dpdk.org > >