From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 53832A00C4; Wed, 28 Sep 2022 16:46:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 452A64114E; Wed, 28 Sep 2022 16:46:28 +0200 (CEST) Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by mails.dpdk.org (Postfix) with ESMTP id 1B243410FA for ; Wed, 28 Sep 2022 16:46:26 +0200 (CEST) Received: by mail-qk1-f181.google.com with SMTP id i3so7986235qkl.3 for ; Wed, 28 Sep 2022 07:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=L4GziNjdFMAJeuKFIBy9YDHqx2USd7zm+htAIcZNrlM=; b=FFSP4Nqbg3mDq6gA6TKS71u9gwZ90kbPDxTteoFg9XH/UHt8PyedMek7RHQ9ZUBOJy qPiXEJHiImvT//s20YQ96HQH9fVRTB1qfSRLpbzQr6YzxjunJxgxEH1i6xCzfCxMC77x MyNhwZZuAx5/x33JbDuQ6BIYjhSYiwV7dVNDVoaoDvc2cXWJDTB0MzGekoUP2x6ilLoa TK2mPMkJVMkD8L25i8DQxdmfUsiVXZZ5h76vUfIHl+mwjdLKDnDBzhEgW7ytUEsuGznQ xSRf/AfL+KNWLNwww9WUbCefcpqAgWURCoFgxDMhqtfwbnsAYBwcbY/sqSe/FMyebJbY 0gYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=L4GziNjdFMAJeuKFIBy9YDHqx2USd7zm+htAIcZNrlM=; b=m2n0/CMh5HsA4bfh0s+33+o5ajnUveuF6XMtbFAVYq7ATFRzn8afu78JGiP0IncY9x d7W6f9HOk3RZJEful+laLKDXfd8U5dScFb08ilu+WRlEZ2qQRkLTkGBlEgTKcwnn9v6X 1r2WY6ItqFZRFCiOjwycgk+lIoTdtVeKe0DSS9/lyumWSMtvK7L6mJwBVEo4OlaY+SbX UmOkOSFcV+FyJclGNe4RhIFOoNR5kTFnZSj+B7GTXTMo4cr8Ndh7XrYraXEnoQ9Ws4uB JpzmyTql0pMDCEiY2NnYiC3TaYzIT+WaKuzuO+OvQC2Vfi/zXZwy8afT9AdsZait2gWF itCw== X-Gm-Message-State: ACrzQf12sEDBf4WiLsvYuNc1qNT+oclieBXA5bnAHpcPfDhM6bOLe5KN 5NslKaCiaIpjHCsRFrBUKZEJhGPvqrapUPY0Ku4= X-Google-Smtp-Source: AMsMyM7ykySqctomZzpGx9xsz0wYGItnBhFHcanwplNe+OA1uoP4qXIMOngic9Z+OnY1q31jSQ3p3ENuccZaYIGFDpA= X-Received: by 2002:a05:620a:2b90:b0:6ce:30a5:b716 with SMTP id dz16-20020a05620a2b9000b006ce30a5b716mr22301578qkb.494.1664376385455; Wed, 28 Sep 2022 07:46:25 -0700 (PDT) MIME-Version: 1.0 References: <20220820005957.2986689-2-timothy.mcdaniel@intel.com> <20220927014204.1401746-1-abdullah.sevincer@intel.com> In-Reply-To: <20220927014204.1401746-1-abdullah.sevincer@intel.com> From: Jerin Jacob Date: Wed, 28 Sep 2022 20:15:59 +0530 Message-ID: Subject: Re: [PATCH v4 1/3] event/dlb2: add producer port probing optimization To: Abdullah Sevincer Cc: dev@dpdk.org, jerinj@marvell.com, rashmi.shetty@intel.com, pravin.pathak@intel.com, mike.ximing.chen@intel.com, timothy.mcdaniel@intel.com, shivani.doneria@intel.com, tirthendu.sarkar@intel.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Sep 27, 2022 at 7:12 AM Abdullah Sevincer wrote: > > For best performance, applications running on certain cores should use > the DLB device locally available on the same tile along with other > resources. To allocate optimal resources, probing is done for each > producer port (PP) for a given CPU and the best performing ports are > allocated to producers. The cpu used for probing is either the first > core of producer coremask (if present) or the second core of EAL > coremask. This will be extended later to probe for all CPUs in the > producer coremask or EAL coremask. > > Producer coremask can be passed along with the BDF of the DLB devices. > "-a xx:y.z,producer_coremask=" > > Applications also need to pass RTE_EVENT_PORT_CFG_HINT_PRODUCER during > rte_event_port_setup() for producer ports for optimal port allocation. > > +#define DLB2_PRODUCER_COREMASK "producer_coremask" Documentation patch is missing. Please add in 1/3. > +#define DLB2_DEFAULT_LDB_PORT_ALLOCATION_ARG "default_port_allocation" Please squash https://patches.dpdk.org/project/dpdk/patch/20220927001835.1394994-1-abdullah.sevincer@intel.com/ patch 1/3 here. Rest looks good. We should merge the next version.