From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9CDDA0524; Fri, 31 Jan 2020 16:55:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C67251C0CF; Fri, 31 Jan 2020 16:55:56 +0100 (CET) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 955FC1C0CD for ; Fri, 31 Jan 2020 16:55:55 +0100 (CET) Received: by mail-io1-f67.google.com with SMTP id k24so8683478ioc.4 for ; Fri, 31 Jan 2020 07:55:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZDXs8QmQ73H+wrZpcWPlOupVgRrQi0rdxxs2f2Fp/1Y=; b=uXyxYQ/CQ8vv/fx8vStIps20vK4BVGTwmaZAPRe6KJTvCQTS9VVIZUudWeM4KL+jR2 RO8Ta4OlXd4WxPU5TuCjucmEkup0/32P8+LBgnhQ33g405cFUFLIVc9fzLgCCo5FWZcV +M2yXI6deYXnXb3R1ZN0b3zyUCXUR/JhusP7czJBR49IqhvrjUAF95QKDv2vARTjc65n opzkBawaZi85Yp4+TWWNM8WfFH+JrV8C8Tzs8/B0aoFrs/kxVObFfOQLVNm/cBUQG9Oy v/ICJn4EhVWMS0uLG6zNX5lBXRSU72lgJGOKR5iE+PLSf1ezBwPbChHIY1xO/JpwnmVT wmVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZDXs8QmQ73H+wrZpcWPlOupVgRrQi0rdxxs2f2Fp/1Y=; b=c3C3Fz1IXsOJmJbgxblRH/1PIqxbs090vooOP4jeu3DBzJVsVETRQ4gUKGIT0vSKr+ v7bbvP7YQkGlci4w8XABW5LX/dFckj1BuUm2uVuT5XHB55omWy5u7EnJ4tNZ9Qjld0Fr tDVPcxkOGQxBdWLy/MQya4GPvsZidyN6SgAY6QBOUQZ1fgkJlTzeY0sC4qF0HLaRsEwX PZDApUjMO6QNuHOclwCZ0JC+QBk37qNRCUqH+J+1YE0izO8FLS1tADZvw2u+fIhgWc7Q SBV0QHbHHb5r/GrXbTfSn5Q9KbUMDwMOG60PN84q9acz9b2TXT3pHygWYBAdLJiJOiOd 7i/g== X-Gm-Message-State: APjAAAWpS2enq4nDlkEWeZZTGv4Tq54oSBIpS46boAfWFCuF9Sha9Zww kPaKyFNoLYzz6QgB+bTTSS628Y8vfN1a1gXacn0= X-Google-Smtp-Source: APXvYqw6bo+iMvW+RqHo16rnypeNm+762tbI5e5CNBbpfEV0KzoFTSNh3Gwh7RyrNI2r9JG5ODiwa1YiNVRUD/qSI+o= X-Received: by 2002:a6b:39c4:: with SMTP id g187mr9019306ioa.271.1580486154614; Fri, 31 Jan 2020 07:55:54 -0800 (PST) MIME-Version: 1.0 References: <20200131125059.1556-1-pbhagavatula@marvell.com> In-Reply-To: <20200131125059.1556-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Fri, 31 Jan 2020 21:25:36 +0530 Message-ID: To: Pavan Nikhilesh Cc: Jerin Jacob , Nithin Dabilpuram , Vamsi Attunuru , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] mempool/octeontx2: optimize for L1D cache architecture X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 31, 2020 at 6:21 PM wrote: > > From: Pavan Nikhilesh > > OCTEON TX2 has 8 sets, 41 ways L1D cache, VA<9:7> bits dictate > the set selection. > Add additional padding to ensure that the element size always > occupies odd number of cachelines to ensure even distribution > of elements among L1D cache sets. > > Signed-off-by: Pavan Nikhilesh > Signed-off-by: Nithin Dabilpuram > Signed-off-by: Vamsi Attunuru > Signed-off-by: Jerin Jacob > --- > drivers/mempool/octeontx2/otx2_mempool_ops.c | 41 ++++++++++++++++++++ > 1 file changed, 41 insertions(+) Please fix the 32-bit build issues(i.e use PRIx64) /export/dpdk.org/drivers/mempool/octeontx2/otx2_mempool_ops.c:782:41: note: format string is defined here 782 | otx2_npa_dbg("iova %lx, aligned iova %lx", iova - off, iova); | ~~^ | | | long unsigned int | %llx