From: Jerin Jacob <jerinjacobk@gmail.com>
To: Timothy McDaniel <timothy.mcdaniel@intel.com>
Cc: "Jerin Jacob" <jerinj@marvell.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
dpdk-dev <dev@dpdk.org>,
"John McNamara" <john.mcnamara@intel.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>
Subject: Re: [dpdk-dev] [PATCH] event/dlb: fix bug accessing unitialized variable
Date: Wed, 3 Feb 2021 22:28:43 +0530 [thread overview]
Message-ID: <CALBAE1MDhY5XjbQv9RGruBRuHpsKz33vU=Sw3SHcs7x11syoTA@mail.gmail.com> (raw)
In-Reply-To: <1612371417-21917-1-git-send-email-timothy.mcdaniel@intel.com>
On Wed, Feb 3, 2021 at 10:26 PM Timothy McDaniel
<timothy.mcdaniel@intel.com> wrote:
>
Please add a comment and also squash the similar patches.
> Fixes: eb14a3421afd ("event/dlb: add eventdev start")
> Coverity issue: 366205
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> ---
> drivers/event/dlb/dlb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/event/dlb/dlb.c b/drivers/event/dlb/dlb.c
> index 64e6df7..b580dc9 100644
> --- a/drivers/event/dlb/dlb.c
> +++ b/drivers/event/dlb/dlb.c
> @@ -1847,7 +1847,7 @@ static int dlb_num_dir_queues_setup(struct dlb_eventdev *dlb)
> {
> struct dlb_hw_dev *handle = &dlb->qm_instance;
> struct dlb_create_dir_queue_args cfg;
> - struct dlb_cmd_response response;
> + struct dlb_cmd_response response = {0};
> int32_t ret;
>
> cfg.response = (uintptr_t)&response;
> --
> 1.7.10
>
next prev parent reply other threads:[~2021-02-03 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 16:56 Timothy McDaniel
2021-02-03 16:58 ` Jerin Jacob [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-02-03 16:56 Timothy McDaniel
2021-02-03 16:56 Timothy McDaniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1MDhY5XjbQv9RGruBRuHpsKz33vU=Sw3SHcs7x11syoTA@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=jerinj@marvell.com \
--cc=john.mcnamara@intel.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=timothy.mcdaniel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).