DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Cc: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
	 Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [EXT] [PATCH] eventdev: fix free of adapters storage
Date: Thu, 21 Oct 2021 14:13:02 +0530	[thread overview]
Message-ID: <CALBAE1MEHp9Qh=V-7CphP9dc5nS5Z_UNG5Gsmg4d=bqdXDBCTg@mail.gmail.com> (raw)
In-Reply-To: <PH0PR18MB40860E3F35F2E930CD353FFDDEBF9@PH0PR18MB4086.namprd18.prod.outlook.com>

On Thu, Oct 21, 2021 at 1:05 PM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
>
>
> >-----Original Message-----
> >From: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
> >Sent: Thursday, October 21, 2021 1:50 AM
> >To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Pavan Nikhilesh
> >Bhagavatula <pbhagavatula@marvell.com>
> >Cc: dev@dpdk.org
> >Subject: [EXT] [PATCH] eventdev: fix free of adapters storage
> >
> >External Email
> >
> >----------------------------------------------------------------------
> >Fix a typo that can cause the hugepage memory that backs the adapters
> >array to be freed unexpectedly.
> >
> >Fixes: e9caa6a09a "eventdev: move timer adapters memory to
> >hugepage")
> >
> >Signed-off-by: Erik Gabriel Carrillo <erik.g.carrillo@intel.com>
>
> LGTM, Jerin please squash as the series is not in main branch yet.

Thanks Eric. Squashed the patch in the series in next-event


>
> Thanks.
>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> >---
> > lib/eventdev/rte_event_timer_adapter.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/lib/eventdev/rte_event_timer_adapter.c
> >b/lib/eventdev/rte_event_timer_adapter.c
> >index 86b6c3fc6f..0e21b7c475 100644
> >--- a/lib/eventdev/rte_event_timer_adapter.c
> >+++ b/lib/eventdev/rte_event_timer_adapter.c
> >@@ -407,7 +407,7 @@ rte_event_timer_adapter_free(struct
> >rte_event_timer_adapter *adapter)
> >       ret = 0;
> >       for (i = 0; i < RTE_EVENT_TIMER_ADAPTER_NUM_MAX; i++)
> >               if (adapters[i].allocated)
> >-                      ret = adapter[i].allocated;
> >+                      ret = adapters[i].allocated;
> >
> >       if (!ret) {
> >               rte_free(adapters);
> >--
> >2.23.0
>

      reply	other threads:[~2021-10-21  8:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-20 20:20 [dpdk-dev] " Erik Gabriel Carrillo
2021-10-21  7:34 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
2021-10-21  8:43   ` Jerin Jacob [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1MEHp9Qh=V-7CphP9dc5nS5Z_UNG5Gsmg4d=bqdXDBCTg@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=dev@dpdk.org \
    --cc=erik.g.carrillo@intel.com \
    --cc=jerinj@marvell.com \
    --cc=pbhagavatula@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).