From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5671FA0548; Fri, 2 Apr 2021 15:43:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D03194069E; Fri, 2 Apr 2021 15:43:37 +0200 (CEST) Received: from mail-il1-f178.google.com (mail-il1-f178.google.com [209.85.166.178]) by mails.dpdk.org (Postfix) with ESMTP id 3C38A40142 for ; Fri, 2 Apr 2021 15:43:36 +0200 (CEST) Received: by mail-il1-f178.google.com with SMTP id y17so4694757ila.6 for ; Fri, 02 Apr 2021 06:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=il4mObQZb248+g0NaY5DYNxqxCxG48C9aMW19r9SXzs=; b=ieNsnL3Xf7hPBBpKlJAdgL1YAEPV3nwy12wWJk5qqR1cSqRTcWrhjqz3ETKuzX14L0 nPN/RqC/q/Rjr5czmP5cXIyWCnNpxoGo4/ElXrye42LKz2NWX/3hsvJgrQ4SIRbRRu7C LXiEIhvYIk6pF0cCuJxXu4c9LWvCsGKuIsxL5ncW0lKURLcTMg1Tjxml3nj4i8JpO1rk j6+mVyw4tUsTSxMh3KK/DbT6jQp0h+HMMnZ1P1ue0Hpu2CNdIjyul9tCkKdLmNBn1hfH tGuYtUIjKgQtMlOoBeCnmINXheVQsmZTFyjYHstuzpXkqksFnyioVEpdkOxREtsnXUzs bFyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=il4mObQZb248+g0NaY5DYNxqxCxG48C9aMW19r9SXzs=; b=eo/xVyi7Z6aOxEqOcZ0qz60eNWZx4Q8ssKAqm26KHNSzLKXWOnk/KzFRnrC2VCbPDZ bAabF8nkHNhYnP0LcKX/8bsdizbX4KosIYmfBad60GtHPn0K8PTClynsQe731ze04LWi MyimEu44ZW0m+He3XVJqKbozJLBppdqjKsm/7sKu0MgmZp8OW+vZ0Sha7giydsoHIT+/ QavxGv6Ca/Vd1Dh5vQLpYbTjxS0kE5Gd1udJelY0pkE7hefpdHdtllxaLWvJ2DdsWLmn JWcW+bykJfgr+M1iLsKTKQVKsgJaUaSU2TtlkRlbmvyqj5BrkeQfcJAyHw47TcZQCV0d 2s4A== X-Gm-Message-State: AOAM533sEjGYD+tYwL7K9wIk7UDNFmkWSD7ZZMxfPZbromKUUEXFu8uY al7EdfeSURXNTjLygQ1V7as2rTl/bbTI8y0PWP0= X-Google-Smtp-Source: ABdhPJyPLyUjXMEHLSVISv2zLDr647jn/CicE8PwDgtNc+kreAaAPjJMnYrIMbIvZRD4uskuETKLzdPtPXPY564QWps= X-Received: by 2002:a05:6e02:188b:: with SMTP id o11mr10814796ilu.294.1617371015569; Fri, 02 Apr 2021 06:43:35 -0700 (PDT) MIME-Version: 1.0 References: <20210401090516.209155-1-anatoly.burakov@intel.com> In-Reply-To: <20210401090516.209155-1-anatoly.burakov@intel.com> From: Jerin Jacob Date: Fri, 2 Apr 2021 19:13:19 +0530 Message-ID: To: Anatoly Burakov , Thomas Monjalon , David Marchand , "Richardson, Bruce" Cc: dpdk-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [RFC] devtools: improve DPDK review process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 1, 2021 at 2:35 PM Anatoly Burakov wrote: > > A common problem on the DPDK mailing list is lack of reviewers for > patches. This script is intended to help with that problem, by picking > a random commit author from our git history, and adding a Reviewed-by: > tag. This can be added to e.g. commit-msg git hook, like so: > > # add reviewer to commit message > $(git rev-parse --show-toplevel)/devtools/get-reviewer.sh >> $1 > > Now all DPDK code will definitely be well reviewed! > > Signed-off-by: Anatoly Burakov > R=D0=B5vi=D0=B5w=D0=B5d-by: Th=D0=BEmas M=D0=BEnj=D0=B0l=D0=BEn Looks like shuf aliased to "git shortlog --numbered --summary | head -n 1" > --- > devtools/get-reviewer.sh | 4 ++++ > 1 file changed, 4 insertions(+) > create mode 100755 devtools/get-reviewer.sh > > diff --git a/devtools/get-reviewer.sh b/devtools/get-reviewer.sh > new file mode 100755 > index 0000000000..f4b07c9862 > --- /dev/null > +++ b/devtools/get-reviewer.sh > @@ -0,0 +1,4 @@ > +#!/bin/sh > + > +# find a reviewer for the code > +git log --format=3D"Reviewed-by: %an <%ae>" | sort -u | shuf -n 1 Leaving the fun part aside, Looks like we can really improve the situation by doing git annotate(to get the original author) of couple lines below and above current patch that changes lines. Thoughts? > -- > 2.25.1 >