From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B3EA43193; Wed, 18 Oct 2023 05:49:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09B7740261; Wed, 18 Oct 2023 05:49:11 +0200 (CEST) Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) by mails.dpdk.org (Postfix) with ESMTP id 195EF4003C for ; Wed, 18 Oct 2023 05:49:09 +0200 (CEST) Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-41983b83e53so43329721cf.2 for ; Tue, 17 Oct 2023 20:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697600948; x=1698205748; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lT+C8LF8Vmd8QR1U+jO4/dGIhQUnSrG2iXeKSz9O/Io=; b=HCZ40/ojQ1y1AxcwwtUSRykVz/fm3ZSUdoNjR5bra+jO4S8rQR4vVvzqitRU/F+aO/ tcfb+AcJL9SNiYTKeSTGZZ1xIX68kIJqNCAqrs0Lr3P/tyTyLmDiqMSLZ4lh36M0uCwP dZkRjfz77RyL1gWQjuOlozqN67H+hHHmf+RUmluMO66ldd3JeyuJ8eArtn7v/ERT/rbC 3GDYbIDbtpF/c26oNOnXutD6QqRv9wIS4CL3JP25xGUvN4yfIDi3l/sUEcnl7sgcsiE+ EhIwzxOaiMWiRZCFzweQi5pLf609ug9jm7iFhKMDEhXaUUgQUKBTgN8hLFbpckDG24la PG+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697600948; x=1698205748; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lT+C8LF8Vmd8QR1U+jO4/dGIhQUnSrG2iXeKSz9O/Io=; b=WD8ymNw5leBkxqOOjNwHIJw8yL3e7+ChFnwIBdbvDWt3qWj0rqU+k5YefgHUenuxmr HRzXgKf3PcwoSNsO8aiaf4+LTTrkIrBcV8OE85hpo4mQbpx9rRBk9kkEsvhMWaLExPJX gB/7T/4cT/7S2aogk0K6YWUJVpoK7+HHy7nwknZArEFJVXpINAIQ9FmMXOT+Fc6XKbRD +ZKqG+8y/Oa1a+bbaYIkhfSR92dJT/DzJjlFEftX95q19oE+w32sCZ0iTj86L9qdglYl noqS47R6jagteYlBJ/0wuCBuiUM1QBt2dtqC1oOPPlaidv0ctzMxUP8PQP8/K7d/XnIf UEGA== X-Gm-Message-State: AOJu0YzKKkMVsglxDZQKIZcV6UF19ChmQPgGoqd0NIet51ZaGhYsThzj N7NkClHZC+ySHSYuo0TB7+rDhrrl5C63XGVatBRt4sxGYHg= X-Google-Smtp-Source: AGHT+IFreTQoznYsEClG+PUkpPPZUSfwRf3RxfLiGrEDbzDIANv2fUGeU0IfvOAnh9g84gftCfFAAAAjZN9gIvCBLmg= X-Received: by 2002:a05:622a:18a:b0:417:cdc5:847a with SMTP id s10-20020a05622a018a00b00417cdc5847amr5053088qtw.39.1697600948221; Tue, 17 Oct 2023 20:49:08 -0700 (PDT) MIME-Version: 1.0 References: <20231011125346.529973-1-vattunuru@marvell.com> <20231012062354.535392-1-vattunuru@marvell.com> <20231012062354.535392-4-vattunuru@marvell.com> In-Reply-To: <20231012062354.535392-4-vattunuru@marvell.com> From: Jerin Jacob Date: Wed, 18 Oct 2023 09:18:41 +0530 Message-ID: Subject: Re: [PATCH v4 3/3] net/octeon_ep: add new fastpath routines To: Vamsi Attunuru Cc: dev@dpdk.org, jerinj@marvell.com, sthotton@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 12, 2023 at 4:41=E2=80=AFPM Vamsi Attunuru wrote: > > Adds new fastpath routines for cn10k & cn9k endpoint > devices and assigns the fastpath routines based on > the offload flags. > > Patch also adds misc changes to improve performance > and code-readability. > > Signed-off-by: Vamsi Attunuru Could you rebase to next-net-mrvl. There is build issue, either due to latest clang or new changes in main. [for-next-net][dpdk-next-net-mrvl] $ clang -v clang version 16.0.6 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/bin Found candidate GCC installation: /usr/bin/../lib/gcc/x86_64-pc-linux-gnu/1= 3.2.1 Found candidate GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.2.1 Selected GCC installation: /usr/bin/../lib64/gcc/x86_64-pc-linux-gnu/13.2.1 Candidate multilib: .;@m64 Candidate multilib: 32;@m32 Selected multilib: .;@m64 ccache clang -Idrivers/libtmp_rte_net_octeon_ep.a.p -Idrivers -I../drivers -Idrivers/net/octeon_ep -I../drivers/net/octeon_ep -Ilib/ethdev -I../lib/ethdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/ include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -fcolor-diagnostics -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -Werror -std=3Dc11 -O2 -g -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing- declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Dna tive -mrtm -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -DRTE_LOG_DEFAULT_LOGTYPE=3Dpmd.net.octeon_ep -DRTE_ANNOTATE_LOCKS -Wthread-safety -MD -MQ drivers/libtmp_rte_net_octeon_ep.a.p/net_octeon_ep_otx_ep_rxtx.c.o -MF drivers/libtmp_rte_net_ octeon_ep.a.p/net_octeon_ep_otx_ep_rxtx.c.o.d -o drivers/libtmp_rte_net_octeon_ep.a.p/net_octeon_ep_otx_ep_rxtx.c.o -c ../drivers/net/octeon_ep/otx_ep_rxtx.c ../drivers/net/octeon_ep/otx_ep_rxtx.c:448:10: error: address argument to atomic operation must be a pointer to _Atomic type ('uint32_t *' (aka 'unsigned int *') invalid) while (rte_atomic_load_explicit(iq->inst_cnt_ism, rte_memory_order_relaxed) >=3D ^ ~~~~~~~~~~~~~~~~ ../lib/eal/include/rte_stdatomic.h:71:2: note: expanded from macro 'rte_atomic_load_explicit' atomic_load_explicit(ptr, memorder) ^ ~~~ /usr/lib/clang/16/include/stdatomic.h:134:30: note: expanded from macro 'atomic_load_explicit' #define atomic_load_explicit __c11_atomic_load ^ ../drivers/net/octeon_ep/otx_ep_rxtx.c:924:10: error: address argument to atomic operation must be a pointer to _Atomic type ('uint32_t *' (aka 'unsigned int *') invalid) while (rte_atomic_load_explicit(droq->pkts_sent_ism, rte_memory_order_relaxed) >=3D ^ ~~~~~~~~~~~~~~~~~~~ ../lib/eal/include/rte_stdatomic.h:71:2: note: expanded from macro 'rte_atomic_load_explicit' atomic_load_explicit(ptr, memorder) ^ ~~~ /usr/lib/clang/16/include/stdatomic.h:134:30: note: expanded from macro 'atomic_load_explicit' #define atomic_load_explicit __c11_atomic_load ^