From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 75830A0350;
	Fri, 26 Jun 2020 08:55:55 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 340A21B3BB;
	Fri, 26 Jun 2020 08:55:54 +0200 (CEST)
Received: from mail-il1-f195.google.com (mail-il1-f195.google.com
 [209.85.166.195]) by dpdk.org (Postfix) with ESMTP id 8D2701B203;
 Fri, 26 Jun 2020 08:55:52 +0200 (CEST)
Received: by mail-il1-f195.google.com with SMTP id t85so7595427ili.5;
 Thu, 25 Jun 2020 23:55:52 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=8PLlo8ImEuhRXTinnIm1s+8WspkfiiypBOH9NSVh2dY=;
 b=kNa4SR8dw6fASYRlZoYopVlgQ/DggBV955TY4ep5BKAvVkN0gJRKxj13IXEqxsvdaw
 PJt4OaVDxqpIzgcpY/otXRLJp1GKyMLkdv+fElDuOFOOXd5UWRYGqtb94oRDIUFuPqJO
 aJ1h5bNeIzk0mGrONMXns8PDk+iB21960YTU2Yysq6MCg7C7ejfTfPLw4BiC9Jt0yp2U
 ssbxfyYqcjEqMmvEqrMp2ATNhquubPEoobUWdI9hZIDJBV7PR7zIXAgdyrXY+STV8a1z
 NLyDBzmLLwkFAa7CU3ruI4cAu+VWjoBXJV9KLL7VPA3jHwLmMWqCQ0aN+5GkluvpgKxw
 qUEQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=8PLlo8ImEuhRXTinnIm1s+8WspkfiiypBOH9NSVh2dY=;
 b=GBoPGr6Bv/VsywH9udu1tpnjqtRMMvdCU4aO/0ZpQE3yVE+hJZGu4lry8bCW/dP9/H
 Fg5Bb4ii5E5papb0+q8byS9Gpua5DoO+uSz9koiKSr4vH5LPSIm6LaMZm7smU/btAnKZ
 BDvkg2NlmLQNugFF1LpOq0FmZz9GXibv9xGEvcnYf8r+WcmpnjpOazUYfmRy8z/5AWFg
 cYxTMjjtnxhIQy/uZ56HqBfnHl+7kPgKzH02sFNN8dltZKgVNFG065tsN79aGLFKWI4g
 aF8kZCo8xkzkZBaZY4iY6njHk8kUBqLRu4ke3bA9+VJMXuiPM2/5g8edVf5+gSwuhviI
 o8eQ==
X-Gm-Message-State: AOAM530FO5vlQk/p3Erd9OsCLen+Ivjrj2v9htwolsoiSg+lfbxjRjJd
 mDI7kSgJxm4XKqlSZW/4P2ok90CT7xAVq28FnWA=
X-Google-Smtp-Source: ABdhPJzXTaUonhd4cqDFGjucTJ+UrOg+2M7Elfm6B9mqp5pfXpUBc0UzzHlGCm5JRMQ1YPsiyO9MIWkjnuxI6HpwCcg=
X-Received: by 2002:a92:d0a:: with SMTP id 10mr1712048iln.162.1593154551674;
 Thu, 25 Jun 2020 23:55:51 -0700 (PDT)
MIME-Version: 1.0
References: <20200612143940.52851-1-roy.fan.zhang@intel.com>
In-Reply-To: <20200612143940.52851-1-roy.fan.zhang@intel.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Fri, 26 Jun 2020 12:25:35 +0530
Message-ID: <CALBAE1MGP-7yUcuXirjy3yzqvQYDEgU-NELs2rPYdWA7neviHw@mail.gmail.com>
To: Fan Zhang <roy.fan.zhang@intel.com>, techboard@dpdk.org, 
 Anoob Joseph <anoobj@marvell.com>
Cc: dpdk-dev <dev@dpdk.org>, Akhil Goyal <akhil.goyal@nxp.com>, 
 Fiona Trahe <fiona.trahe@intel.com>,
 Piotr Bronowski <piotrx.bronowski@intel.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] crypto/qat: add data-path APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Jun 12, 2020 at 8:10 PM Fan Zhang <roy.fan.zhang@intel.com> wrote:
>
> This patch adds data-path APIs to QAT symmetric dirver to support
> raw data as input.
>
> For applications/libraries that want to benefit from the data-path
> encryption acceleration provided by QAT but not necessarily depends
> on DPDK data-path structures (such as VPP), some performance
> degradation is unavoidable to convert between their specific data
> structure and DPDK cryptodev operation as well as mbufs.
>
> This patch takes advantage of existing QAT implementations to form
> symmetric data-path enqueue and dequeue APIs that support raw data
> as input so that they can have wider usability towards those
> applications/libraries without performance drop caused by the data
> structure conversions. In the meantime the less performance-sensitive
> cryptodev device and session management remains intact so that DPDK
> cryptodev remains to be unified control path library for QAT.
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> Signed-off-by: Piotr Bronowski <piotrx.bronowski@intel.com>
> ---

+ Techboard,

I think, this problem is not specific to QAT nor the crypto subsystem.
If we are planning to expose the PMD specific descriptors, It would good to get
general agreement from everyone. Probably we can/need to extend ethdev
PMDs as well based on the need.

If we are taking this path, at minimum, we need a generic control path
API with cryptodev,
to query such capability. (Probably API to register descriptor and
query supported descriptor as PMD
can support multiple descriptors)

> +       SYMLINK-y-include += qat_sym_frame.h

I think, the exposed file name should be rte_pmd_qat_sym_frame.h