Re: [dpdk-dev] [PATCH v2] eventdev: fix event port setup in tx adapter

[Jerin Jacob <jerinjacobk@gmail.com>]

On Fri, Jul 30, 2021 at 4:00 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 30/07/2021 12:24, Jerin Jacob:
> > On Wed, Jul 28, 2021 at 4:27 PM Jayatheerthan, Jay
> > <jay.jayatheerthan@intel.com> wrote:
> > >
> > > > -----Original Message-----
> > > > From: Jerin Jacob <jerinjacobk@gmail.com>
> > > > Sent: Wednesday, July 28, 2021 3:01 PM
> > > > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>
> > > > Cc: Naga Harish K, S V <s.v.naga.harish.k@intel.com>; dev@dpdk.org
> > > > Subject: Re: [PATCH v2] eventdev: fix event port setup in tx adapter
> >
> > > >
> > > > >
> > > > > >
> > > > > > Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> > > >
> > > >
> > > > @Naga Harish K, S V Can we remove "," from the Signoff name.
> > > >
> > > > Some suggestions for consideration in preferred order. Let me know
> > > > your preferred Signoff name, I will change it accordingly.
> > > >
> > > > Naga Harish <s.v.naga.harish.k@intel.com>
> > > >
> > > > or
> > > >
> > > > Naga Harish K <s.v.naga.harish.k@intel.com>
> > > >
> > > > or
> > > >
> > > > Naga Harish K S V <s.v.naga.harish.k@intel.com>
> > >
> > > This option is good. (Harish is out and hence I am responding)
> >
> > 1)  Option 'Signed-off-by: Naga Harish K S V
> > <s.v.naga.harish.k@intel.com> is warned by checkpatch
> >
> > [for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n 1
> >
> > ### eventdev: fix event port setup in Tx adapter
> >
> > WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name
> > mismatch: 'From: "Naga Harish K, S V" <s.v.naga.harish.k@intel.com>'
> > != 'Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>'
> >
> > 2)  Option 'Signed-off-by: Naga Harish K, S V
> > <s.v.naga.harish.k@intel.com>' is warning by check-git-log.sh
> >
> > [for-main]dell[dpdk-next-eventdev] $ ./devtools/check-git-log.sh -n 1
> > Wrong tag:
> >         Signed-off-by: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> >
> >
> > @thomas @David Marchand
> >
> > Could you suggest what Sign-off to take?
>
> The first option is probably OK but the problem is a mismatch with the author name.
> Make sure to change the authorship with --amend --author=

Thanks for the input.


>
>