* [PATCH] examples/eventdev: Check for the NULL pointer after calling rte_zmalloc
@ 2022-07-06 7:23 835703180
2022-09-13 12:17 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: 835703180 @ 2022-07-06 7:23 UTC (permalink / raw)
To: harry.van.haaren; +Cc: dev, Shiqi Liu
From: Shiqi Liu <835703180@qq.com>
As the possible failure of the rte_zmalloc(), the not_checked and
checked could be NULL pointer.
Therefore, it should be better to check it in order to avoid
the dereference of the NULL pointer.
Fixes: fa8054c8c88 ("examples/eventdev: add thread safe Tx worker pipeline")
Signed-off-by: Shiqi Liu <835703180@qq.com>
---
examples/eventdev_pipeline/pipeline_worker_tx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/examples/eventdev_pipeline/pipeline_worker_tx.c b/examples/eventdev_pipeline/pipeline_worker_tx.c
index a82e064c1c..6ea676c516 100644
--- a/examples/eventdev_pipeline/pipeline_worker_tx.c
+++ b/examples/eventdev_pipeline/pipeline_worker_tx.c
@@ -764,7 +764,9 @@ init_adapters(uint16_t nb_ports)
ret = rte_event_dev_info_get(evdev_id, &dev_info);
adptr_services = rte_zmalloc(NULL, sizeof(struct rx_adptr_services), 0);
-
+ if (adptr_services == NULL) {
+ return -ENOMEM;
+ }
struct rte_event_port_conf adptr_p_conf = {
.dequeue_depth = cdata.worker_cq_depth,
.enqueue_depth = 64,
--
2.35.1.windows.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] examples/eventdev: Check for the NULL pointer after calling rte_zmalloc
2022-07-06 7:23 [PATCH] examples/eventdev: Check for the NULL pointer after calling rte_zmalloc 835703180
@ 2022-09-13 12:17 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2022-09-13 12:17 UTC (permalink / raw)
To: 835703180; +Cc: harry.van.haaren, dev
On Wed, Jul 6, 2022 at 12:54 PM <835703180@qq.com> wrote:
>
> From: Shiqi Liu <835703180@qq.com>
>
> As the possible failure of the rte_zmalloc(), the not_checked and
> checked could be NULL pointer.
> Therefore, it should be better to check it in order to avoid
> the dereference of the NULL pointer.
>
> Fixes: fa8054c8c88 ("examples/eventdev: add thread safe Tx worker pipeline")
> Signed-off-by: Shiqi Liu <835703180@qq.com>
> ---
> examples/eventdev_pipeline/pipeline_worker_tx.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/examples/eventdev_pipeline/pipeline_worker_tx.c b/examples/eventdev_pipeline/pipeline_worker_tx.c
> index a82e064c1c..6ea676c516 100644
> --- a/examples/eventdev_pipeline/pipeline_worker_tx.c
> +++ b/examples/eventdev_pipeline/pipeline_worker_tx.c
> @@ -764,7 +764,9 @@ init_adapters(uint16_t nb_ports)
>
> ret = rte_event_dev_info_get(evdev_id, &dev_info);
> adptr_services = rte_zmalloc(NULL, sizeof(struct rx_adptr_services), 0);
> -
> + if (adptr_services == NULL) {
> + return -ENOMEM;
> + }
it does not look like you have tried to compile this patch. It is a
void return function.
CI: http://mails.dpdk.org/archives/test-report/2022-July/294780.html
Also, Please update the subject. Some suggestion to consider.
examples/eventdev: validate memory allocation
> struct rte_event_port_conf adptr_p_conf = {
> .dequeue_depth = cdata.worker_cq_depth,
> .enqueue_depth = 64,
> --
> 2.35.1.windows.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-13 12:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-06 7:23 [PATCH] examples/eventdev: Check for the NULL pointer after calling rte_zmalloc 835703180
2022-09-13 12:17 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).