From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07DAFA00C2; Tue, 27 Sep 2022 05:23:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BDAF4113C; Tue, 27 Sep 2022 05:23:32 +0200 (CEST) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by mails.dpdk.org (Postfix) with ESMTP id D96AB410D0; Tue, 27 Sep 2022 05:23:30 +0200 (CEST) Received: by mail-qk1-f174.google.com with SMTP id 3so5346178qka.5; Mon, 26 Sep 2022 20:23:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=WSpdklBTF+6B9YXPV5pVkzih5kVxXbNTxL8HEgHbKcg=; b=eV2Z4LcswWpKztHNe4kWLRISiNFR7Ok41l/YBF8iZe9BL06/weGFQIGB3/2ZreUpBJ R8nLm6t7IeJpDEtxOgAlK492uY9WS+oZoJ0a+wgfmw3rEw7uh8ob/2+ygp8mKhjerolH mbdclRQOerElRYBqfUusv7Kbr9pqxMXxnl6z24DDWa52+FcxhE8bxobpxb/06bPq5M5X 1xisdb7/7FiRLYH8T2myYWFjBMIWyZ7y/KnSWeFe3dHGtbGIfZRsLZ5F6kfZ5zSWl/MB znYUArolL1Nsa1d3HFNbUq/z2ub0ta/W1v7zfcnpD26UTRQCcm3dq6azEZIF3R6EIuRP kaJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=WSpdklBTF+6B9YXPV5pVkzih5kVxXbNTxL8HEgHbKcg=; b=Z1Nl8eY15ZyU/b+VVcH/08HcQLXqc8xlQfTkE/G7GnXZiBQxmL0N5b2Udk3QAh0qVk kRBA/UKg07fvqOIzQrHFzMHK7Gn7AbxTWyhRgyBEkBe6dKxZEthdhq08pD3QFQpi080y S0XR/1l3J3a3goMCfPcZ3S6Wu6BHLfBBCGzccxmxMhPv6W4eBh6Cxe27xVtVUHUy0S/5 DoOv31BVrBPxJFeVyvISYTMEgEfBpiTIggJnaSbdtaea1AKNovpdcs86Da5EZW4q3s26 6aRR5dxdusTLw2Cp1qub7yMzl9Cgxzr++SlGh9G8WXF7gvbV1N0BCPKjOgl2X5k6JoSl 7x8w== X-Gm-Message-State: ACrzQf2vyfefSjRdwIVN5cSFiJ5SwQNDGs/FNC/Bw1a3n90/JZxwrxI0 K7W4mNN0YljjSuJZIGyOYvvQM2Eqq96cx8GTpDE= X-Google-Smtp-Source: AMsMyM6RTTE5pHLNqwknpnLpgPTIE+d+Z1MbkBCTDaNofBeg3i0rGlln423B0xeX+Vgkt6scU2KNG3YZpx4eaJNzVWc= X-Received: by 2002:a37:e319:0:b0:6cd:f643:b6d6 with SMTP id y25-20020a37e319000000b006cdf643b6d6mr16688429qki.616.1664249010052; Mon, 26 Sep 2022 20:23:30 -0700 (PDT) MIME-Version: 1.0 References: <20220725083545.2271-1-pbhagavatula@marvell.com> In-Reply-To: From: Jerin Jacob Date: Tue, 27 Sep 2022 08:53:03 +0530 Message-ID: Subject: Re: [EXT] Re: [PATCH] event/cnxk: fix stale data in workslots To: Pavan Nikhilesh Bhagavatula Cc: Jerin Jacob Kollanukkaran , Shijith Thotton , "dev@dpdk.org" , "stable@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 21, 2022 at 1:31 PM Pavan Nikhilesh Bhagavatula wrote: > > > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Tuesday, September 13, 2022 8:06 PM > > To: Pavan Nikhilesh Bhagavatula > > Cc: Jerin Jacob Kollanukkaran ; Shijith Thotton > > ; dev@dpdk.org; stable@dpdk.org > > Subject: [EXT] Re: [PATCH] event/cnxk: fix stale data in workslots > > > > External Email > > > > ---------------------------------------------------------------------- > > On Mon, Jul 25, 2022 at 2:05 PM wrote: > > > > > > From: Pavan Nikhilesh > > > > > > Fix stale XAQ depth check pointers in workslot memory after > > > XAQ pool resize. > > > > > > Fixes: bd64a963d2fc ("event/cnxk: use common XAQ pool functions") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Pavan Nikhilesh > > > > This needs to be rebased > > > > [for-main]dell[dpdk-next-eventdev] $ git pw series apply 24066 > > Failed to apply patch: > > Applying: event/cnxk: fix stale data in workslots > > error: sha1 information is lacking or useless > > (drivers/event/cnxk/cn10k_eventdev.c). > > error: could not build fake ancestor > > hint: Use 'git am --show-current-patch=diff' to see the failed patch > > Patch failed at 0001 event/cnxk: fix stale data in workslots > > When you have resolved this problem, run "git am --continue". > > If you prefer to skip this patch, run "git am --skip" instead. > > To restore the original branch and stop patching, run "git am --abort". > > This patch set depeneds on 24634 series Applied to dpdk-next-net-eventdev/for-main. Thanks > > > > > > --- > > > drivers/event/cnxk/cn10k_eventdev.c | 21 ++++++++++++++++--- > > > drivers/event/cnxk/cn9k_eventdev.c | 31 +++++++++++++++++++++++-- > > ---- > > > drivers/event/cnxk/cnxk_tim_evdev.c | 6 +++++- > > > drivers/event/cnxk/cnxk_tim_evdev.h | 6 +++++- > > > 4 files changed, 53 insertions(+), 11 deletions(-) > > > > > > diff --git a/drivers/event/cnxk/cn10k_eventdev.c > > b/drivers/event/cnxk/cn10k_eventdev.c > > > index db8dc2a9ce..ea6dadd7b7 100644 > > > --- a/drivers/event/cnxk/cn10k_eventdev.c > > > +++ b/drivers/event/cnxk/cn10k_eventdev.c > > > @@ -701,8 +701,11 @@ cn10k_sso_set_priv_mem(const struct > > rte_eventdev *event_dev, void *lookup_mem, u > > > > > > for (i = 0; i < dev->nb_event_ports; i++) { > > > struct cn10k_sso_hws *ws = event_dev->data->ports[i]; > > > - ws->lookup_mem = lookup_mem; > > > + ws->xaq_lmt = dev->xaq_lmt; > > > + ws->fc_mem = (uint64_t *)dev->fc_iova; > > > ws->tstamp = dev->tstamp; > > > + if (lookup_mem) > > > + ws->lookup_mem = lookup_mem; > > > if (meta_aura) > > > ws->meta_aura = meta_aura; > > > } > > > @@ -894,6 +897,7 @@ cn10k_crypto_adapter_qp_add(const struct > > rte_eventdev *event_dev, > > > const struct rte_event *event) > > > { > > > struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev); > > > + int ret; > > > > > > RTE_SET_USED(event); > > > > > > @@ -903,7 +907,10 @@ cn10k_crypto_adapter_qp_add(const struct > > rte_eventdev *event_dev, > > > dev->is_ca_internal_port = 1; > > > cn10k_sso_fp_fns_set((struct rte_eventdev *)(uintptr_t)event_dev); > > > > > > - return cnxk_crypto_adapter_qp_add(event_dev, cdev, > > queue_pair_id); > > > + ret = cnxk_crypto_adapter_qp_add(event_dev, cdev, > > queue_pair_id); > > > + cn10k_sso_set_priv_mem(event_dev, NULL, 0); > > > + > > > + return ret; > > > } > > > > > > static int > > > @@ -917,6 +924,14 @@ cn10k_crypto_adapter_qp_del(const struct > > rte_eventdev *event_dev, > > > return cnxk_crypto_adapter_qp_del(cdev, queue_pair_id); > > > } > > > > > > +static int > > > +cn10k_tim_caps_get(const struct rte_eventdev *evdev, uint64_t flags, > > > + uint32_t *caps, const struct event_timer_adapter_ops **ops) > > > +{ > > > + return cnxk_tim_caps_get(evdev, flags, caps, ops, > > > + cn10k_sso_set_priv_mem); > > > +} > > > + > > > static struct eventdev_ops cn10k_sso_dev_ops = { > > > .dev_infos_get = cn10k_sso_info_get, > > > .dev_configure = cn10k_sso_dev_configure, > > > @@ -950,7 +965,7 @@ static struct eventdev_ops cn10k_sso_dev_ops = { > > > .eth_tx_adapter_stop = cnxk_sso_tx_adapter_stop, > > > .eth_tx_adapter_free = cnxk_sso_tx_adapter_free, > > > > > > - .timer_adapter_caps_get = cnxk_tim_caps_get, > > > + .timer_adapter_caps_get = cn10k_tim_caps_get, > > > > > > .crypto_adapter_caps_get = cn10k_crypto_adapter_caps_get, > > > .crypto_adapter_queue_pair_add = cn10k_crypto_adapter_qp_add, > > > diff --git a/drivers/event/cnxk/cn9k_eventdev.c > > b/drivers/event/cnxk/cn9k_eventdev.c > > > index 992a2a555c..5d527c3be8 100644 > > > --- a/drivers/event/cnxk/cn9k_eventdev.c > > > +++ b/drivers/event/cnxk/cn9k_eventdev.c > > > @@ -942,7 +942,8 @@ cn9k_sso_rx_adapter_caps_get(const struct > > rte_eventdev *event_dev, > > > } > > > > > > static void > > > -cn9k_sso_set_priv_mem(const struct rte_eventdev *event_dev, void > > *lookup_mem) > > > +cn9k_sso_set_priv_mem(const struct rte_eventdev *event_dev, void > > *lookup_mem, > > > + uint64_t aura __rte_unused) > > > { > > > struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev); > > > int i; > > > @@ -951,12 +952,18 @@ cn9k_sso_set_priv_mem(const struct > > rte_eventdev *event_dev, void *lookup_mem) > > > if (dev->dual_ws) { > > > struct cn9k_sso_hws_dual *dws = > > > event_dev->data->ports[i]; > > > - dws->lookup_mem = lookup_mem; > > > + dws->xaq_lmt = dev->xaq_lmt; > > > + dws->fc_mem = (uint64_t *)dev->fc_iova; > > > dws->tstamp = dev->tstamp; > > > + if (lookup_mem) > > > + dws->lookup_mem = lookup_mem; > > > } else { > > > struct cn9k_sso_hws *ws = event_dev->data->ports[i]; > > > - ws->lookup_mem = lookup_mem; > > > + ws->xaq_lmt = dev->xaq_lmt; > > > + ws->fc_mem = (uint64_t *)dev->fc_iova; > > > ws->tstamp = dev->tstamp; > > > + if (lookup_mem) > > > + ws->lookup_mem = lookup_mem; > > > } > > > } > > > } > > > @@ -982,7 +989,7 @@ cn9k_sso_rx_adapter_queue_add( > > > > > > rxq = eth_dev->data->rx_queues[0]; > > > lookup_mem = rxq->lookup_mem; > > > - cn9k_sso_set_priv_mem(event_dev, lookup_mem); > > > + cn9k_sso_set_priv_mem(event_dev, lookup_mem, 0); > > > cn9k_sso_fp_fns_set((struct rte_eventdev *)(uintptr_t)event_dev); > > > > > > return 0; > > > @@ -1121,6 +1128,7 @@ cn9k_crypto_adapter_qp_add(const struct > > rte_eventdev *event_dev, > > > int32_t queue_pair_id, const struct rte_event *event) > > > { > > > struct cnxk_sso_evdev *dev = cnxk_sso_pmd_priv(event_dev); > > > + int ret; > > > > > > RTE_SET_USED(event); > > > > > > @@ -1130,7 +1138,10 @@ cn9k_crypto_adapter_qp_add(const struct > > rte_eventdev *event_dev, > > > dev->is_ca_internal_port = 1; > > > cn9k_sso_fp_fns_set((struct rte_eventdev *)(uintptr_t)event_dev); > > > > > > - return cnxk_crypto_adapter_qp_add(event_dev, cdev, > > queue_pair_id); > > > + ret = cnxk_crypto_adapter_qp_add(event_dev, cdev, > > queue_pair_id); > > > + cn9k_sso_set_priv_mem(event_dev, NULL, 0); > > > + > > > + return ret; > > > } > > > > > > static int > > > @@ -1144,6 +1155,14 @@ cn9k_crypto_adapter_qp_del(const struct > > rte_eventdev *event_dev, > > > return cnxk_crypto_adapter_qp_del(cdev, queue_pair_id); > > > } > > > > > > +static int > > > +cn9k_tim_caps_get(const struct rte_eventdev *evdev, uint64_t flags, > > > + uint32_t *caps, const struct event_timer_adapter_ops **ops) > > > +{ > > > + return cnxk_tim_caps_get(evdev, flags, caps, ops, > > > + cn9k_sso_set_priv_mem); > > > +} > > > + > > > static struct eventdev_ops cn9k_sso_dev_ops = { > > > .dev_infos_get = cn9k_sso_info_get, > > > .dev_configure = cn9k_sso_dev_configure, > > > @@ -1175,7 +1194,7 @@ static struct eventdev_ops cn9k_sso_dev_ops = { > > > .eth_tx_adapter_stop = cnxk_sso_tx_adapter_stop, > > > .eth_tx_adapter_free = cnxk_sso_tx_adapter_free, > > > > > > - .timer_adapter_caps_get = cnxk_tim_caps_get, > > > + .timer_adapter_caps_get = cn9k_tim_caps_get, > > > > > > .crypto_adapter_caps_get = cn9k_crypto_adapter_caps_get, > > > .crypto_adapter_queue_pair_add = cn9k_crypto_adapter_qp_add, > > > diff --git a/drivers/event/cnxk/cnxk_tim_evdev.c > > b/drivers/event/cnxk/cnxk_tim_evdev.c > > > index f8a536e71a..5dd79cbd47 100644 > > > --- a/drivers/event/cnxk/cnxk_tim_evdev.c > > > +++ b/drivers/event/cnxk/cnxk_tim_evdev.c > > > @@ -8,6 +8,7 @@ > > > #include "cnxk_tim_evdev.h" > > > > > > static struct event_timer_adapter_ops cnxk_tim_ops; > > > +static cnxk_sso_set_priv_mem_t sso_set_priv_mem_fn; > > > > > > static int > > > cnxk_tim_chnk_pool_create(struct cnxk_tim_ring *tim_ring, > > > @@ -265,6 +266,7 @@ cnxk_tim_ring_create(struct > > rte_event_timer_adapter *adptr) > > > cnxk_sso_updt_xae_cnt(cnxk_sso_pmd_priv(dev->event_dev), > > tim_ring, > > > RTE_EVENT_TYPE_TIMER); > > > cnxk_sso_xae_reconfigure(dev->event_dev); > > > + sso_set_priv_mem_fn(dev->event_dev, NULL, 0); > > > > > > plt_tim_dbg( > > > "Total memory used %" PRIu64 "MB\n", > > > @@ -375,7 +377,8 @@ cnxk_tim_stats_reset(const struct > > rte_event_timer_adapter *adapter) > > > > > > int > > > cnxk_tim_caps_get(const struct rte_eventdev *evdev, uint64_t flags, > > > - uint32_t *caps, const struct event_timer_adapter_ops **ops) > > > + uint32_t *caps, const struct event_timer_adapter_ops **ops, > > > + cnxk_sso_set_priv_mem_t priv_mem_fn) > > > { > > > struct cnxk_tim_evdev *dev = cnxk_tim_priv_get(); > > > > > > @@ -389,6 +392,7 @@ cnxk_tim_caps_get(const struct rte_eventdev > > *evdev, uint64_t flags, > > > cnxk_tim_ops.start = cnxk_tim_ring_start; > > > cnxk_tim_ops.stop = cnxk_tim_ring_stop; > > > cnxk_tim_ops.get_info = cnxk_tim_ring_info_get; > > > + sso_set_priv_mem_fn = priv_mem_fn; > > > > > > if (dev->enable_stats) { > > > cnxk_tim_ops.stats_get = cnxk_tim_stats_get; > > > diff --git a/drivers/event/cnxk/cnxk_tim_evdev.h > > b/drivers/event/cnxk/cnxk_tim_evdev.h > > > index 0fda9f4f13..0c192346c7 100644 > > > --- a/drivers/event/cnxk/cnxk_tim_evdev.h > > > +++ b/drivers/event/cnxk/cnxk_tim_evdev.h > > > @@ -78,6 +78,9 @@ > > > #define TIM_BUCKET_SEMA_WLOCK \ > > > (TIM_BUCKET_CHUNK_REMAIN | (1ull << TIM_BUCKET_W1_S_LOCK)) > > > > > > +typedef void (*cnxk_sso_set_priv_mem_t)(const struct rte_eventdev > > *event_dev, > > > + void *lookup_mem, uint64_t aura); > > > + > > > struct cnxk_tim_ctl { > > > uint16_t ring; > > > uint16_t chunk_slots; > > > @@ -317,7 +320,8 @@ cnxk_tim_timer_cancel_burst(const struct > > rte_event_timer_adapter *adptr, > > > > > > int cnxk_tim_caps_get(const struct rte_eventdev *dev, uint64_t flags, > > > uint32_t *caps, > > > - const struct event_timer_adapter_ops **ops); > > > + const struct event_timer_adapter_ops **ops, > > > + cnxk_sso_set_priv_mem_t priv_mem_fn); > > > > > > void cnxk_tim_init(struct roc_sso *sso); > > > void cnxk_tim_fini(void); > > > -- > > > 2.35.1 > > >