From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B737DA054F; Thu, 9 Jun 2022 19:40:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91E154069C; Thu, 9 Jun 2022 19:40:28 +0200 (CEST) Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) by mails.dpdk.org (Postfix) with ESMTP id 0FB5840689 for ; Thu, 9 Jun 2022 19:40:27 +0200 (CEST) Received: by mail-qk1-f179.google.com with SMTP id d128so10382657qkg.8 for ; Thu, 09 Jun 2022 10:40:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ghH0goDrYyHAtOVi4KRqTxh0Eh2wmdvcJ009GBCmDx8=; b=CK5Ddj6O/TtBNEU3otzDSRON5Djj/VSulsTnDpiDKWRDfHv6vJp1rEa/guq1kKQpLR XLOg+UDEE4kyanq0zXwKYiRSwvIGlc7yUcjT+D/69BjXL18/HNaA64yNU90nMPuhHvtx srFyioWQZ+LJeiNu3S3DOfMM+R0P79A9YbNx80Khxupbjb5/WhclGynfSRiz+3FQ0h3l bmQUjllE/zuxkTg/A4Ie3SiBqO6+zfdQtD/nZ5idsCqfDqa56xz8/YV2Q22g5DSCD9Wy 3rkYGQuBkXbf3S5O4s23O9Fw7z3LzbRdvPP1QBw8+UjjcoloRFj/05UKbXf+FMu3kJWm GHaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ghH0goDrYyHAtOVi4KRqTxh0Eh2wmdvcJ009GBCmDx8=; b=Ttfnr0lXB7P1OryAiBvNeYd8QxTVkowcETUxngcfQ+y3+koyMSLRa9ObuEvJ0ZP4C1 66mCsJ6Vjqhauf7jWiBnVsAatHUBgAIJTkJ1g2ZBs5IDJIi/k9fVHFCysV47/8qm/cWc DwQTwtABAScd+QhfKo0ymMqHCviW1XGe+JlmqhEEzjAx+XcCdF3hMFn+Dmp7GwKX/g38 q4iSwMdRAote7wZTm4VUB24yYGX7sHjVffQ9AHUh/5H/HxKUnLmmocx9ymG98hTF5LD7 5pXe/c2Evf2AuJzlwtcNwX+p2bymnPlc1nm4jkQwI0NW18iFW42iDzhCT9kbK9iSbUti BAOA== X-Gm-Message-State: AOAM530qUGjZPNlVr8rSpKqAhlQnjlogwBj3yN16XWD0BGR8PbpFg1NC pVhJMXWUp6q0mLFhhP9IQxBDWHdTCzWqkengBgk= X-Google-Smtp-Source: ABdhPJxrF6CdKXr+rQGtztGmsqjK4MTcX/df+J0ky2WCvbquDgFeFjQyrn87YptyTGuVHeK4SmWXW+/1bOHrlgyUSYM= X-Received: by 2002:a05:620a:cd5:b0:6a6:8d8b:7b88 with SMTP id b21-20020a05620a0cd500b006a68d8b7b88mr24144870qkj.402.1654796426369; Thu, 09 Jun 2022 10:40:26 -0700 (PDT) MIME-Version: 1.0 References: <20220409151849.1007602-1-timothy.mcdaniel@intel.com> <20220523160955.3890850-1-timothy.mcdaniel@intel.com> In-Reply-To: From: Jerin Jacob Date: Thu, 9 Jun 2022 23:10:00 +0530 Message-ID: Subject: Re: [PATCH v4] event/dlb2: add support for single 512B write of 4 QEs To: Bruce Richardson Cc: "McDaniel, Timothy" , "jerinj@marvell.com" , "dev@dpdk.org" , "Wires, Kent" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 23, 2022 at 10:25 PM Bruce Richardson wrote: > > On Mon, May 23, 2022 at 05:52:06PM +0100, McDaniel, Timothy wrote: > > > > > > > > > > Instead, I'd recommend doing as other places in DPDK - such as in ACL > > > library, or i40e or ice net drivers - where we not only check the current > > > build support, but also check the compiler support. That way, even if we > > > are building for e.g. a target of AVX2, we can still build the AVX-512 > > > parts using the appropriate compiler flags, and choose them > > > opportunistically at runtime. > > > > I do not understand what you are getting at here. > > > Check out net/i40e/meson.build and hopefully things may become clearer. I am updating the patchwork status as "Changes requested" for this patch. @McDaniel, Timothy Please send the updated version. Also, the following patch depends on this. I will wait for the merging below after this patch is merged. https://patches.dpdk.org/project/dpdk/patch/20220410225602.1524724-1-timothy.mcdaniel@intel.com/ https://patches.dpdk.org/project/dpdk/patch/20220410224755.1524117-1-timothy.mcdaniel@intel.com/ > > /Bruce