From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 67C52A034F;
	Wed, 10 Nov 2021 11:44:04 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3B13D4068B;
	Wed, 10 Nov 2021 11:44:04 +0100 (CET)
Received: from mail-il1-f179.google.com (mail-il1-f179.google.com
 [209.85.166.179])
 by mails.dpdk.org (Postfix) with ESMTP id 3936640683
 for <dev@dpdk.org>; Wed, 10 Nov 2021 11:44:02 +0100 (CET)
Received: by mail-il1-f179.google.com with SMTP id h23so1993644ila.4
 for <dev@dpdk.org>; Wed, 10 Nov 2021 02:44:02 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc:content-transfer-encoding;
 bh=OUlCU6vrvHBG16uVUhh+wPBk0yMK1nRpDd5rRneiKOI=;
 b=FXyOiJV58vcbzOA76HG7oPlwdckCkjMcjugP2BGer3TQbe/j11Cm62ixrxfon+Smlw
 hMHgIfrwf6J3+VzIE7mtccCZ3y+DoVX5zytFEc9CLnJTJ73dVB2+pjCM4PhLg7889D5M
 fftzCn4GQ40m8tiC+JZzNoIPYAdlqntBxjbqlDuUVrRrn5SD/ubpZmWXYTB2aqrlOIoi
 k2UBFwVgHCUvfpQmTO9E+4b5w1TZIcJ1+1DEZgZ7MLaL1Tb0HNMtgG8eOz4qeNW6fzRI
 dmx3hd9M0Ir8uqYTSoQthATEzs30dNzIV0fkUvjmQ8k7zkfClILoGNJSEVyJowEeUE3K
 BOsw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc:content-transfer-encoding;
 bh=OUlCU6vrvHBG16uVUhh+wPBk0yMK1nRpDd5rRneiKOI=;
 b=ww4MqfSTMsUk2kxmNXuNMtAwCeJcpRlubqDqbWxkvqZXwzuSFCqiW668YdTvTrWmlj
 8pd7VLG9XC3vZ3iGuv16owCje4M6qN/9g2JWklCYP1gxui9VD90hFtVjeg3+VvXyHb+/
 jx60vjMZTj7gMfJn54MQYmWx7zVxgfizumG0t718Q65ACcH09B1b5hQSpEUGNA7REjTk
 pOk4Cv7Jatyw0Jh+xPOvQGv/URmSyp9ckU3N5fOU8QUYrPs6KZy0O2yTq4/1JaUVkb7y
 jCkRk3vptw//jzo06txst9ZuewmnqGjOzR8OJi3gU2IGC+neUpwq4YSvM9fjaMVHdY5/
 b35g==
X-Gm-Message-State: AOAM531QVqopa2brLgJKA1Va/vi0TzJTJIL3k6F5OMg8paaGWTQ8yoJc
 z8m6oqX2rEwpTOhpgqIsPQGiBsrES5RZHyqVuMM=
X-Google-Smtp-Source: ABdhPJy6a6j3ac7OpmlZb3DNj+4pXgD+n8bOhxO9rIA2zsJUBI+/x4b7Lr/E6OoyuXwSa/Vaa2USOjWF1ZYmuO+hD14=
X-Received: by 2002:a05:6e02:1aac:: with SMTP id
 l12mr11126933ilv.295.1636541041564; 
 Wed, 10 Nov 2021 02:44:01 -0800 (PST)
MIME-Version: 1.0
References: <BY3PR18MB4785570DFB1C9DCE068EED6FC8939@BY3PR18MB4785.namprd18.prod.outlook.com>
 <20211110092906.20980-1-mattias.ronnblom@ericsson.com>
 <BN0PR11MB57126C35FAA6D7C7A6CD28B8D7939@BN0PR11MB5712.namprd11.prod.outlook.com>
 <93db4995-817a-d6d5-8d8c-8f53d3f46764@ericsson.com>
In-Reply-To: <93db4995-817a-d6d5-8d8c-8f53d3f46764@ericsson.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Wed, 10 Nov 2021 16:13:35 +0530
Message-ID: <CALBAE1MM=NqUSMUv5Yc6x10esC0jLiRF4_BtupwosAUYPzQeDQ@mail.gmail.com>
To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>
Cc: "Van Haaren, Harry" <harry.van.haaren@intel.com>,
 "jerinj@marvell.com" <jerinj@marvell.com>, 
 Sunil Kumar Kori <skori@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>, 
 Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>, 
 Nipun Gupta <nipun.gupta@nxp.com>, Thomas Monjalon <thomas@monjalon.net>, 
 David Marchand <david.marchand@redhat.com>, 
 "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>, 
 "Carrillo, Erik G" <erik.g.carrillo@intel.com>, 
 "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>, "Yigit,
 Ferruh" <ferruh.yigit@intel.com>, Akhil Goyal <gakhil@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [dpdk-dev] [PATCH] eventdev: negate maintenance capability flag
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Nov 10, 2021 at 3:37 PM Mattias R=C3=B6nnblom
<mattias.ronnblom@ericsson.com> wrote:
>
> On 2021-11-10 10:55, Van Haaren, Harry wrote:
> >> -----Original Message-----
> >> From: Mattias R=C3=B6nnblom <mattias.ronnblom@ericsson.com>
> >> Sent: Wednesday, November 10, 2021 9:29 AM
> >> To: jerinj@marvell.com; Jerin Jacob <jerinjacobk@gmail.com>; Sunil Kum=
ar Kori
> >> <skori@marvell.com>
> >> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.co=
m>;
> >> Hemant Agrawal <hemant.agrawal@nxp.com>; Nipun Gupta
> >> <nipun.gupta@nxp.com>; Van Haaren, Harry <harry.van.haaren@intel.com>;
> >> Thomas Monjalon <thomas@monjalon.net>; David Marchand
> >> <david.marchand@redhat.com>; Gujjar, Abhinandan S
> >> <abhinandan.gujjar@intel.com>; Carrillo, Erik G <erik.g.carrillo@intel=
.com>;
> >> Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Yigit, Ferruh
> >> <ferruh.yigit@intel.com>; Akhil Goyal <gakhil@marvell.com>; mattias.ro=
nnblom
> >> <mattias.ronnblom@ericsson.com>
> >> Subject: [PATCH] eventdev: negate maintenance capability flag
> >>
> >> Replace RTE_EVENT_DEV_CAP_REQUIRES_MAINT, which signaled the need
> >> for the application to call rte_event_maintain(), with
> >> RTE_EVENT_DEV_CAP_MAINTENANCE_FREE, which does the opposite (i.e.,
> >> signifies that the event device does not require maintenance).
> >>
> >> This approach is more in line with how other eventdev hardware and/or
> >> software limitations are handled in the Eventdev API.
> >>
> >> Signed-off-by: Mattias R=C3=B6nnblom <mattias.ronnblom@ericsson.com>
> > Generally patch looks fine to me, but on testing I got a strange warnin=
g from the
> > compiler on the OPDL driver:
> >
> > In file included from ../drivers/event/opdl/opdl_evdev.h:8,
> >                   from ../drivers/event/opdl/opdl_evdev.c:15:
> > ../drivers/event/opdl/opdl_evdev.c: In function =E2=80=98opdl_info_get=
=E2=80=99:
> > ../lib/eventdev/rte_eventdev.h:302:44: warning: conversion from =E2=80=
=98long long unsigned int=E2=80=99 to =E2=80=98un
> > signed char=E2=80=99 changes value from =E2=80=981024=E2=80=99 to =E2=
=80=980=E2=80=99 [-Woverflow]
> >    302 | #define RTE_EVENT_DEV_CAP_MAINTENANCE_FREE (1ULL << 10)
> >        |                                            ^
> > ../drivers/event/opdl/opdl_evdev.c:379:34: note: in expansion of macro =
=E2=80=98RTE_EVENT_DEV_CAP_MAINT
> > ENANCE_FREE=E2=80=99
> >    379 |                                  RTE_EVENT_DEV_CAP_MAINTENANCE=
_FREE,
> >        |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~=
~~~~~
> >
> > Investigating, RTE_EVENT_DEV_CAP_* are assigned to struct rte_event_dev=
_info::event_dev_cap,
> > which is a uint32_t. The error suggests that the variable being assigne=
d to is a "unsigned char"?
> >
> > <snip>
> >
> >>   static void
> >> diff --git a/drivers/event/opdl/opdl_evdev.c b/drivers/event/opdl/opdl=
_evdev.c
> >> index 5007e9a7bf..787ee4713d 100644
> >> --- a/drivers/event/opdl/opdl_evdev.c
> >> +++ b/drivers/event/opdl/opdl_evdev.c
> >> @@ -376,6 +376,7 @@ opdl_info_get(struct rte_eventdev *dev, struct
> >> rte_event_dev_info *info)
> >>              .max_num_events =3D OPDL_INFLIGHT_EVENTS_TOTAL,
> >>              .event_dev_cap =3D RTE_EVENT_DEV_CAP_BURST_MODE |
> >>                               RTE_EVENT_DEV_CAP_CARRY_FLOW_ID,
> >> +                             RTE_EVENT_DEV_CAP_MAINTENANCE_FREE,
> >>      };
> > Aha! Replace:
> >>                               RTE_EVENT_DEV_CAP_CARRY_FLOW_ID,
> > with:
> >>                               RTE_EVENT_DEV_CAP_CARRY_FLOW_ID |
> > The "," character was causing the _FREE flag to not be combined with th=
e previous
> > flags field, instead being its own (unnamed?) assignment to the struct =
rte_event_dev_info.
> >
> > With that , to | change, all looks good to me. -Harry
> >
> >
> I sent a v2. Thanks!

v2 has doc build error. Please send v3

http://mails.dpdk.org/archives/test-report/2021-November/241649.html
>