From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88A9242B2C; Wed, 17 May 2023 16:49:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6F7AE406B7; Wed, 17 May 2023 16:49:34 +0200 (CEST) Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) by mails.dpdk.org (Postfix) with ESMTP id AF30140041 for ; Wed, 17 May 2023 16:49:33 +0200 (CEST) Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-44faec9af51so363938e0c.1 for ; Wed, 17 May 2023 07:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684334973; x=1686926973; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6PRNVwaKjxqatjj/weAusAUtZIbM0qplwfkJ+ATf4go=; b=CtkNUzse7cixML+v0hf1x+zGqdWzZ09NQ5Uu16u9PFq1n098/LrgQQEgx6LsFyhucX UxsyF5crGWy6LthhbFaGvEJtt+hiLNxj9jMf4plzaKlM8TKs1Mbt8yr5aMMvGgo+KzD3 DXwNHT9zrdvmKKaE2/RGMZwbH2sgIr247u6SHWeqJkLQelLDLjZ1x4lj8avSrwthvi21 9i8KAqfFoY5pKGsb3pu3Y7LNpuTcQOHW/Ufyyziz892YRKdcBkP+ds0D02tC48aA7N4w gWG3U5/RCGELNITINgpQUhBZUXfb9h0P+gQS7n29tJVtwhfp0n5f9VO5HtBR/u+BkxJU jhhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684334973; x=1686926973; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6PRNVwaKjxqatjj/weAusAUtZIbM0qplwfkJ+ATf4go=; b=IDtT7RoEei77dmh7Isnq01DmqyLIajRfMKNvolc8f3FN+nmFrHpA7/ZCD4HW9cuoV0 O8fX2PXKANenR6qlcHn6BcSbORPAWuTi2YLYgJnZCEMxF3cT6zg7wFRwyYf2MSCmOXze NGDOaKGZhRv3pW8/ffS6N3a3j/UfXrIB5X0E6du4jHsPMYEVzdy8bcf9+74tigFlmuTb ywrD9rRQBRWF63m/G8dWaRc1SrGlOJ2VVfa+U34RNXiyO2h3Gegh42CvFaPuvLHlmZ3+ ZhpGwnPeZ+cqlpBgNqIm2Ei0erpKAy2TKSq8994r1IjuHFpjIBFGNvsGhiGns3VZFGmP 1whA== X-Gm-Message-State: AC+VfDyAzFnz/WNXGF/aCdGwtmj7DRVFk7skZGoWXJrV6d52dTEWxwG4 6ovApY/f2Et3+aq821cHarFk2/RmrmdMM+kXerc= X-Google-Smtp-Source: ACHHUZ5jl51Dx0aWUqjxDxO39KhXhgz8dIVw9A3rvpLq30jkQVvCqkeQVOv0bMDO7n0/Ke47rgyU9Bv8TDBseYCH/7Y= X-Received: by 2002:a1f:4d47:0:b0:452:b436:d60a with SMTP id a68-20020a1f4d47000000b00452b436d60amr12567656vkb.8.1684334972917; Wed, 17 May 2023 07:49:32 -0700 (PDT) MIME-Version: 1.0 References: <20230418091616.1388517-1-ganapati.kundapura@intel.com> In-Reply-To: From: Jerin Jacob Date: Wed, 17 May 2023 20:19:06 +0530 Message-ID: Subject: Re: [PATCH v1] eventdev/crypto: refactor circular buffer size To: "Gujjar, Abhinandan S" Cc: "Kundapura, Ganapati" , "jerinj@marvell.com" , "dev@dpdk.org" , "Naga Harish K, S V" , "Jayatheerthan, Jay" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, May 17, 2023 at 10:23=E2=80=AFAM Gujjar, Abhinandan S wrote: > > > > -----Original Message----- > > From: Kundapura, Ganapati > > Sent: Tuesday, April 18, 2023 2:46 PM > > To: jerinj@marvell.com; Gujjar, Abhinandan S > > ; dev@dpdk.org > > Cc: Naga Harish K, S V ; Jayatheerthan, Ja= y > > > > Subject: [PATCH v1] eventdev/crypto: refactor circular buffer size > > > > In case of CRYPTO_ADAPTER_OPS_BUFFER_SZ is modified, > > eca_circular_buffer_space_for_batch() also needs to be updated to check > > maximum number of crypto ops can be accommodated in circular buffer > > when CPM becomes busy. > > > > Defined MAX_OPS_IN_BUFFER which contains size for batch of dequeued > > events and redefined CRYPTO_ADAPTER_OPS_BUFFER_SZ in terms of > > MAX_OPS_IN_BUFFER. > > > > This patch makes eca_circular_buffer_space_for_batch() independent of > > circular buffer changes. > > > > Signed-off-by: Ganapati Kundapura > > Acked-by: Abhinandan Gujjar Applied to dpdk-next-net-eventdev/for-main. Thanks > > > > > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > > b/lib/eventdev/rte_event_crypto_adapter.c > > index f6c1e53..52a28e5 100644 > > --- a/lib/eventdev/rte_event_crypto_adapter.c > > +++ b/lib/eventdev/rte_event_crypto_adapter.c > > @@ -25,7 +25,14 @@ > > #define CRYPTO_ADAPTER_MEM_NAME_LEN 32 > > #define CRYPTO_ADAPTER_MAX_EV_ENQ_RETRIES 100 > > > > -#define CRYPTO_ADAPTER_OPS_BUFFER_SZ (BATCH_SIZE + BATCH_SIZE) > > +/* MAX_OPS_IN_BUFFER contains size for batch of dequeued events */ > > +#define MAX_OPS_IN_BUFFER BATCH_SIZE > > + > > +/* CRYPTO_ADAPTER_OPS_BUFFER_SZ to accommodate > > MAX_OPS_IN_BUFFER + > > + * additional space for one batch > > + */ > > +#define CRYPTO_ADAPTER_OPS_BUFFER_SZ (MAX_OPS_IN_BUFFER + > > BATCH_SIZE) > > + > > #define CRYPTO_ADAPTER_BUFFER_SZ 1024 > > > > /* Flush an instance's enqueue buffers every > > CRYPTO_ENQ_FLUSH_THRESHOLD @@ -188,7 +195,8 @@ > > eca_circular_buffer_batch_ready(struct crypto_ops_circular_buffer *bufp= ) > > static inline bool eca_circular_buffer_space_for_batch(struct > > crypto_ops_circular_buffer *bufp) { > > - return (bufp->size - bufp->count) >=3D BATCH_SIZE; > > + /* circular buffer can have atmost MAX_OPS_IN_BUFFER */ > > + return (bufp->size - bufp->count) >=3D MAX_OPS_IN_BUFFER; > > } > > > > static inline void > > -- > > 2.6.4 >