From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BD15A04BB; Tue, 6 Oct 2020 11:58:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 90A3D2B8B; Tue, 6 Oct 2020 11:58:52 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id BD462F3E for ; Tue, 6 Oct 2020 11:58:49 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id k6so12367829ior.2 for ; Tue, 06 Oct 2020 02:58:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/asRTVTGTa68i6rpttgmGsfgcxAMc4XOetYnKRN9o9Q=; b=Faqzi8XzZPilRUil1ToA6DQY3ws7TlNTZjP7RlR6eJ5a5BdMuShWs/hXIQsSYbnnIA De6MqjO7wsTODJJt/CAhikh0ZN+Va8jP2inqoe3U++4e7lLmFXSBxb9Zh9aoqx8Lsi/M Y9ytNxCku/t0VvdZIiDavegZjHSREJkmt/831H4B73ki3Ze+L4mvwhOuTRhQ6YHiLTRV 9PYdENyhfVwOscK/RVEj1ls6vFqyFFQOkQ8B4Ci1FZkKkbbOjCJUehiF6htc9w3i6gqQ xNYBEzLMZpBDlitLVeFM68OcG429/EX4m1WilUVid1k7Luil/FZ6M+DN4j88hpSuBXJJ cu4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/asRTVTGTa68i6rpttgmGsfgcxAMc4XOetYnKRN9o9Q=; b=bJ+SYmQYyss9S4o08v/AXo7EkBX9BHdK6aje/33RA9TzZ/gVyvpMG2mAhVy9ivF45v 1wi8NgqejIva5MqilUKAGNAzkS91ZuQnm3QfbFZG/hMY6GqRrq8lrU6gWSbU+dymoi49 ZaUQlWCwBTHvTzHZJqzHU4Z5e7inzV1b6PDwWK9ET4QjzP/uNqvS3mAfnQdDoFXw1C88 oz1islPX1KlgnBZLIDe42yGlWhe4x8RzkN+RlTHWosnDampTCpC+A0kRbTLomljvVwvA eFCQWEVIAOMy2NxjIzL3cacUAkh2xYDBPmTw1ahQp17q+V3oWPRl8yIGALq3o2T6zSZr zekg== X-Gm-Message-State: AOAM530do7/1acYC2uc83TpCucRmP8AyO2n/jYkK/vrZuv8VY+NwWbDE /tCxznASp6R9FHerJFRCwrsc9b37O1UHsL07Rzs= X-Google-Smtp-Source: ABdhPJzSNv3U2HiwYyuFgrig6KBXKMB+tcEl6n89tfe1pI3hgdwcbMHtZPOBUPuYv5zcetmC2sOVFUdMq+LLtk4L6H4= X-Received: by 2002:a5e:8347:: with SMTP id y7mr397201iom.1.1601978329162; Tue, 06 Oct 2020 02:58:49 -0700 (PDT) MIME-Version: 1.0 References: <1601928154-26051-1-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: From: Jerin Jacob Date: Tue, 6 Oct 2020 15:28:33 +0530 Message-ID: To: David Marchand Cc: Sunil Kumar Kori , Timothy McDaniel , Jerin Jacob Kollanukkaran , dev , Erik Gabriel Carrillo , Gage Eads , Van Haaren Harry Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 1/1] eal: increase TRACE CTF SIZE to recommended size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 6, 2020 at 3:10 PM David Marchand w= rote: > > On Tue, Oct 6, 2020 at 11:22 AM Sunil Kumar Kori wrot= e: > > >On Mon, Oct 5, 2020 at 10:16 PM Timothy McDaniel > > > wrote: > > >> > > >> Increase TRACE_CTF_FIELD_SIZE to 448, the recommended size. > > > > > >Repeating the same sentence in the title and the commitlog does not gi= ve > > >much info. > > > > > >Plus, what is this "recommendation"? > > When analyzed this issue, only one more byte was needed to fix this iss= ue but in future similar issue can occur again. > > So increasing this value by 64 bytes which actually equals to a cache l= ine. That=E2=80=99s why we have suggested this size. > > 384 is aligned to both 64 and 128 bytes cache lines. > 448 is only aligned to 64 bytes. > > Should we care about 128 bytes cache lines systems? it is on a slow path. 448 is OK. > > > > > > > > > > > >> Fixes "CTF field is too long" error when running with trace enabled. > > > > > >Ok, you hit this limit, but it would help to get some context here. > > >Looking at this patch in the future, we won't know why it was necessar= y. > > How about following commitlog: > > """ > trace: increase trace point buffer size > > The current buffer size is not big enough to accomodate traces for new > additions in the eventdev subsystem. > Increase this buffer size by XXX for reason YYY. > """ Looks good to me. > > > -- > David Marchand >