From: Jerin Jacob <jerinjacobk@gmail.com>
To: Nithin Dabilpuram <ndabilpuram@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>, Ray Kinsella <mdr@ashroe.eu>,
dpdk-dev <dev@dpdk.org>, Srujana Challa <schalla@marvell.com>
Subject: Re: [dpdk-dev] [PATCH 1/9] common/cnxk: add code to write CPT CTX through microcode op
Date: Wed, 3 Nov 2021 20:39:59 +0530 [thread overview]
Message-ID: <CALBAE1MOeiA-C47zWCNh-s0HftBLg9--N8ZQCdSbs3Nt6=7Gqw@mail.gmail.com> (raw)
In-Reply-To: <20211102155421.486-1-ndabilpuram@marvell.com>
On Tue, Nov 2, 2021 at 9:24 PM Nithin Dabilpuram
<ndabilpuram@marvell.com> wrote:
>
> From: Srujana Challa <schalla@marvell.com>
>
> Adds APIs to write CPT CTX through microcode op(SET_CTX/WRITE_SA).
>
> Signed-off-by: Srujana Challa <schalla@marvell.com>
Series Acked-by: Jerin Jacob <jerinj@marvell.com>
Series applied to dpdk-next-net-mrvl/for-next-net. Thanks.
> ---
> drivers/common/cnxk/hw/cpt.h | 2 -
> drivers/common/cnxk/roc_cpt.c | 83 +++++++++++++++++++++++++--
> drivers/common/cnxk/roc_cpt.h | 8 ++-
> drivers/common/cnxk/roc_ie_ot.h | 5 ++
> drivers/common/cnxk/roc_nix_inl.c | 102 +++++++++++++++++++++++++++++++---
> drivers/common/cnxk/roc_nix_inl.h | 4 ++
> drivers/common/cnxk/roc_nix_inl_dev.c | 10 +++-
> drivers/common/cnxk/version.map | 5 ++
> 8 files changed, 204 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/common/cnxk/hw/cpt.h b/drivers/common/cnxk/hw/cpt.h
> index 4d9df59..919f842 100644
> --- a/drivers/common/cnxk/hw/cpt.h
> +++ b/drivers/common/cnxk/hw/cpt.h
> @@ -64,8 +64,6 @@ union cpt_lf_ctx_flush {
> struct {
> uint64_t cptr : 46;
> uint64_t inval : 1;
> - uint64_t res : 1;
> - uint64_t pf_func : 16;
> } s;
> };
>
> diff --git a/drivers/common/cnxk/roc_cpt.c b/drivers/common/cnxk/roc_cpt.c
> index f0e52ae..49d8bf2 100644
> --- a/drivers/common/cnxk/roc_cpt.c
> +++ b/drivers/common/cnxk/roc_cpt.c
> @@ -677,7 +677,7 @@ roc_cpt_dev_init(struct roc_cpt *roc_cpt)
> }
>
> int
> -roc_cpt_lf_ctx_flush(struct roc_cpt_lf *lf, uint64_t cptr)
> +roc_cpt_lf_ctx_flush(struct roc_cpt_lf *lf, void *cptr, bool inval)
> {
> union cpt_lf_ctx_flush reg;
>
> @@ -685,15 +685,32 @@ roc_cpt_lf_ctx_flush(struct roc_cpt_lf *lf, uint64_t cptr)
> return -ENOTSUP;
>
> reg.u = 0;
> - reg.s.pf_func = lf->pf_func;
> - reg.s.inval = 1;
> - reg.s.cptr = cptr;
> + reg.s.inval = inval;
> + reg.s.cptr = (uintptr_t)cptr >> 7;
>
> plt_write64(reg.u, lf->rbase + CPT_LF_CTX_FLUSH);
>
> return 0;
> }
>
> +int
> +roc_cpt_lf_ctx_reload(struct roc_cpt_lf *lf, void *cptr)
> +{
> + union cpt_lf_ctx_reload reg;
> +
> + if (lf == NULL) {
> + plt_err("Could not trigger CTX reload");
> + return -ENOTSUP;
> + }
> +
> + reg.u = 0;
> + reg.s.cptr = (uintptr_t)cptr >> 7;
> +
> + plt_write64(reg.u, lf->rbase + CPT_LF_CTX_RELOAD);
> +
> + return 0;
> +}
> +
> void
> cpt_lf_fini(struct roc_cpt_lf *lf)
> {
> @@ -890,3 +907,61 @@ roc_cpt_lmtline_init(struct roc_cpt *roc_cpt, struct roc_cpt_lmtline *lmtline,
>
> return 0;
> }
> +
> +int
> +roc_cpt_ctx_write(struct roc_cpt_lf *lf, void *sa_dptr, void *sa_cptr,
> + uint16_t sa_len)
> +{
> + uintptr_t lmt_base = lf->lmt_base;
> + uint64_t lmt_arg, io_addr;
> + struct cpt_inst_s *inst;
> + union cpt_res_s *res;
> + uint16_t lmt_id;
> + uint64_t *dptr;
> + int i;
> +
> + ROC_LMT_CPT_BASE_ID_GET(lmt_base, lmt_id);
> + inst = (struct cpt_inst_s *)lmt_base;
> +
> + memset(inst, 0, sizeof(struct cpt_inst_s));
> +
> + res = plt_zmalloc(sizeof(*res), ROC_CPT_RES_ALIGN);
> + if (res == NULL) {
> + plt_err("Couldn't allocate memory for result address");
> + return -ENOMEM;
> + }
> + dptr = plt_zmalloc(sa_len, 0);
> + if (!dptr) {
> + plt_err("Couldn't allocate memory for SA dptr");
> + plt_free(res);
> + return -ENOMEM;
> + }
> + for (i = 0; i < (sa_len / 8); i++)
> + dptr[i] = plt_cpu_to_be_64(((uint64_t *)sa_dptr)[i]);
> +
> + /* Fill CPT_INST_S for WRITE_SA microcode op */
> + res->cn10k.compcode = CPT_COMP_NOT_DONE;
> + inst->res_addr = (uint64_t)res;
> + inst->dptr = (uint64_t)dptr;
> + inst->w4.s.param2 = sa_len >> 3;
> + inst->w4.s.dlen = sa_len;
> + inst->w4.s.opcode_major = ROC_IE_OT_MAJOR_OP_WRITE_SA;
> + inst->w4.s.opcode_minor = ROC_IE_OT_MINOR_OP_WRITE_SA;
> + inst->w7.s.cptr = (uint64_t)sa_cptr;
> + inst->w7.s.ctx_val = 1;
> + inst->w7.s.egrp = ROC_CPT_DFLT_ENG_GRP_SE_IE;
> +
> + lmt_arg = ROC_CN10K_CPT_LMT_ARG | (uint64_t)lmt_id;
> + io_addr = lf->io_addr | ROC_CN10K_CPT_INST_DW_M1 << 4;
> +
> + roc_lmt_submit_steorl(lmt_arg, io_addr);
> + plt_wmb();
> +
> + /* Wait until CPT instruction completes */
> + while (res->cn10k.compcode == CPT_COMP_NOT_DONE)
> + plt_delay_ms(1);
> +
> + plt_free(res);
> +
> + return 0;
> +}
> diff --git a/drivers/common/cnxk/roc_cpt.h b/drivers/common/cnxk/roc_cpt.h
> index e84f168..12e6b81 100644
> --- a/drivers/common/cnxk/roc_cpt.h
> +++ b/drivers/common/cnxk/roc_cpt.h
> @@ -85,6 +85,8 @@
> (((ROC_CPT_CCM_ICV_LEN - 2) / 2) << 3) | (ROC_CPT_CCM_MSG_LEN - 1))
> #define ROC_CPT_CCM_SALT_LEN 3
>
> +#define ROC_CPT_RES_ALIGN 16
> +
> enum {
> ROC_CPT_REVISION_ID_83XX = 0,
> ROC_CPT_REVISION_ID_96XX_B0 = 1,
> @@ -161,7 +163,9 @@ int __roc_api roc_cpt_dev_configure(struct roc_cpt *roc_cpt, int nb_lf);
> void __roc_api roc_cpt_dev_clear(struct roc_cpt *roc_cpt);
> int __roc_api roc_cpt_lf_init(struct roc_cpt *roc_cpt, struct roc_cpt_lf *lf);
> void __roc_api roc_cpt_lf_fini(struct roc_cpt_lf *lf);
> -int __roc_api roc_cpt_lf_ctx_flush(struct roc_cpt_lf *lf, uint64_t cptr);
> +int __roc_api roc_cpt_lf_ctx_flush(struct roc_cpt_lf *lf, void *cptr,
> + bool inval);
> +int __roc_api roc_cpt_lf_ctx_reload(struct roc_cpt_lf *lf, void *cptr);
> int __roc_api roc_cpt_inline_ipsec_cfg(struct dev *dev, uint8_t slot,
> struct roc_nix *nix);
> int __roc_api roc_cpt_inline_ipsec_inb_cfg(struct roc_cpt *roc_cpt,
> @@ -174,5 +178,7 @@ int __roc_api roc_cpt_lmtline_init(struct roc_cpt *roc_cpt,
> struct roc_cpt_lmtline *lmtline, int lf_id);
>
> void __roc_api roc_cpt_parse_hdr_dump(const struct cpt_parse_hdr_s *cpth);
> +int __roc_api roc_cpt_ctx_write(struct roc_cpt_lf *lf, void *sa_dptr,
> + void *sa_cptr, uint16_t sa_len);
>
> #endif /* _ROC_CPT_H_ */
> diff --git a/drivers/common/cnxk/roc_ie_ot.h b/drivers/common/cnxk/roc_ie_ot.h
> index e8415cf..5b61902 100644
> --- a/drivers/common/cnxk/roc_ie_ot.h
> +++ b/drivers/common/cnxk/roc_ie_ot.h
> @@ -12,6 +12,11 @@
> #define ROC_IE_OT_MAJOR_OP_PROCESS_OUTBOUND_IPSEC 0x28UL
> #define ROC_IE_OT_MAJOR_OP_PROCESS_INBOUND_IPSEC 0x29UL
>
> +#define ROC_IE_OT_MAJOR_OP_WRITE_SA 0x01UL
> +#define ROC_IE_OT_MINOR_OP_WRITE_SA 0x09UL
> +
> +#define ROC_IE_OT_CTX_ILEN 2
> +
> enum roc_ie_ot_ucc_ipsec {
> ROC_IE_OT_UCC_SUCCESS = 0x00,
> ROC_IE_OT_UCC_ERR_SA_INVAL = 0xb0,
> diff --git a/drivers/common/cnxk/roc_nix_inl.c b/drivers/common/cnxk/roc_nix_inl.c
> index 1d962e3..3955d9b 100644
> --- a/drivers/common/cnxk/roc_nix_inl.c
> +++ b/drivers/common/cnxk/roc_nix_inl.c
> @@ -23,7 +23,8 @@ nix_inl_inb_sa_tbl_setup(struct roc_nix *roc_nix)
> struct nix *nix = roc_nix_to_nix_priv(roc_nix);
> struct roc_nix_ipsec_cfg cfg;
> size_t inb_sa_sz;
> - int rc;
> + int rc, i;
> + void *sa;
>
> /* CN9K SA size is different */
> if (roc_model_is_cn9k())
> @@ -39,6 +40,12 @@ nix_inl_inb_sa_tbl_setup(struct roc_nix *roc_nix)
> plt_err("Failed to allocate memory for Inbound SA");
> return -ENOMEM;
> }
> + if (roc_model_is_cn10k()) {
> + for (i = 0; i < ipsec_in_max_spi; i++) {
> + sa = ((uint8_t *)nix->inb_sa_base) + (i * inb_sa_sz);
> + roc_nix_inl_inb_sa_init(sa);
> + }
> + }
>
> memset(&cfg, 0, sizeof(cfg));
> cfg.sa_size = inb_sa_sz;
> @@ -271,6 +278,7 @@ roc_nix_inl_outb_init(struct roc_nix *roc_nix)
> void *sa_base;
> size_t sa_sz;
> int i, j, rc;
> + void *sa;
>
> if (idev == NULL)
> return -ENOTSUP;
> @@ -368,6 +376,12 @@ roc_nix_inl_outb_init(struct roc_nix *roc_nix)
> plt_err("Outbound SA base alloc failed");
> goto lf_fini;
> }
> + if (roc_model_is_cn10k()) {
> + for (i = 0; i < roc_nix->ipsec_out_max_sa; i++) {
> + sa = ((uint8_t *)sa_base) + (i * sa_sz);
> + roc_nix_inl_outb_sa_init(sa);
> + }
> + }
> nix->outb_sa_base = sa_base;
> nix->outb_sa_sz = sa_sz;
>
> @@ -717,6 +731,8 @@ roc_nix_inl_sa_sync(struct roc_nix *roc_nix, void *sa, bool inb,
> {
> struct nix *nix = roc_nix_to_nix_priv(roc_nix);
> struct roc_cpt_lf *outb_lf = nix->cpt_lf_base;
> + struct idev_cfg *idev = idev_get_cfg();
> + struct nix_inl_dev *inl_dev = NULL;
> union cpt_lf_ctx_reload reload;
> union cpt_lf_ctx_flush flush;
> uintptr_t rbase;
> @@ -727,13 +743,15 @@ roc_nix_inl_sa_sync(struct roc_nix *roc_nix, void *sa, bool inb,
> return 0;
> }
>
> - if (!inb && !outb_lf)
> - return -EINVAL;
> + if (inb && nix->inb_inl_dev) {
> + outb_lf = NULL;
> + if (idev)
> + inl_dev = idev->nix_inl_dev;
> + if (inl_dev)
> + outb_lf = &inl_dev->cpt_lf;
> + }
>
> - /* Performing op via outbound lf is enough
> - * when inline dev is not in use.
> - */
> - if (outb_lf && !nix->inb_inl_dev) {
> + if (outb_lf) {
> rbase = outb_lf->rbase;
>
> flush.u = 0;
> @@ -755,11 +773,81 @@ roc_nix_inl_sa_sync(struct roc_nix *roc_nix, void *sa, bool inb,
> }
> return 0;
> }
> + plt_err("Could not get CPT LF for SA sync");
> + return -ENOTSUP;
> +}
> +
> +int
> +roc_nix_inl_ctx_write(struct roc_nix *roc_nix, void *sa_dptr, void *sa_cptr,
> + bool inb, uint16_t sa_len)
> +{
> + struct nix *nix = roc_nix_to_nix_priv(roc_nix);
> + struct roc_cpt_lf *outb_lf = nix->cpt_lf_base;
> + struct idev_cfg *idev = idev_get_cfg();
> + struct nix_inl_dev *inl_dev = NULL;
> + union cpt_lf_ctx_flush flush;
> + uintptr_t rbase;
> + int rc;
> +
> + /* Nothing much to do on cn9k */
> + if (roc_model_is_cn9k()) {
> + plt_atomic_thread_fence(__ATOMIC_ACQ_REL);
> + return 0;
> + }
> +
> + if (inb && nix->inb_inl_dev) {
> + outb_lf = NULL;
> + if (idev)
> + inl_dev = idev->nix_inl_dev;
> + if (inl_dev && inl_dev->attach_cptlf)
> + outb_lf = &inl_dev->cpt_lf;
> + }
> +
> + if (outb_lf) {
> + rbase = outb_lf->rbase;
> + flush.u = 0;
> +
> + rc = roc_cpt_ctx_write(outb_lf, sa_dptr, sa_cptr, sa_len);
> + if (rc)
> + return rc;
> + /* Trigger CTX flush to write dirty data back to DRAM */
> + flush.s.cptr = ((uintptr_t)sa_cptr) >> 7;
> + plt_write64(flush.u, rbase + CPT_LF_CTX_FLUSH);
>
> + return 0;
> + }
> + plt_nix_dbg("Could not get CPT LF for CTX write");
> return -ENOTSUP;
> }
>
> void
> +roc_nix_inl_inb_sa_init(struct roc_ot_ipsec_inb_sa *sa)
> +{
> + size_t offset;
> +
> + memset(sa, 0, sizeof(struct roc_ot_ipsec_inb_sa));
> +
> + offset = offsetof(struct roc_ot_ipsec_inb_sa, ctx);
> + sa->w0.s.hw_ctx_off = offset / ROC_CTX_UNIT_8B;
> + sa->w0.s.ctx_push_size = sa->w0.s.hw_ctx_off + 1;
> + sa->w0.s.ctx_size = ROC_IE_OT_CTX_ILEN;
> + sa->w0.s.aop_valid = 1;
> +}
> +
> +void
> +roc_nix_inl_outb_sa_init(struct roc_ot_ipsec_outb_sa *sa)
> +{
> + size_t offset;
> +
> + memset(sa, 0, sizeof(struct roc_ot_ipsec_outb_sa));
> +
> + offset = offsetof(struct roc_ot_ipsec_outb_sa, ctx);
> + sa->w0.s.ctx_push_size = (offset / ROC_CTX_UNIT_8B);
> + sa->w0.s.ctx_size = ROC_IE_OT_CTX_ILEN;
> + sa->w0.s.aop_valid = 1;
> +}
> +
> +void
> roc_nix_inl_dev_lock(void)
> {
> struct idev_cfg *idev = idev_get_cfg();
> diff --git a/drivers/common/cnxk/roc_nix_inl.h b/drivers/common/cnxk/roc_nix_inl.h
> index ae5e022..abbeac6 100644
> --- a/drivers/common/cnxk/roc_nix_inl.h
> +++ b/drivers/common/cnxk/roc_nix_inl.h
> @@ -166,5 +166,9 @@ enum roc_nix_inl_sa_sync_op {
>
> int __roc_api roc_nix_inl_sa_sync(struct roc_nix *roc_nix, void *sa, bool inb,
> enum roc_nix_inl_sa_sync_op op);
> +int __roc_api roc_nix_inl_ctx_write(struct roc_nix *roc_nix, void *sa_dptr,
> + void *sa_cptr, bool inb, uint16_t sa_len);
> +void __roc_api roc_nix_inl_inb_sa_init(struct roc_ot_ipsec_inb_sa *sa);
> +void __roc_api roc_nix_inl_outb_sa_init(struct roc_ot_ipsec_outb_sa *sa);
>
> #endif /* _ROC_NIX_INL_H_ */
> diff --git a/drivers/common/cnxk/roc_nix_inl_dev.c b/drivers/common/cnxk/roc_nix_inl_dev.c
> index 495dd19..33a59f6 100644
> --- a/drivers/common/cnxk/roc_nix_inl_dev.c
> +++ b/drivers/common/cnxk/roc_nix_inl_dev.c
> @@ -334,7 +334,8 @@ nix_inl_nix_setup(struct nix_inl_dev *inl_dev)
> struct nix_lf_alloc_rsp *rsp;
> struct nix_lf_alloc_req *req;
> size_t inb_sa_sz;
> - int rc = -ENOSPC;
> + int i, rc = -ENOSPC;
> + void *sa;
>
> /* Alloc NIX LF needed for single RQ */
> req = mbox_alloc_msg_nix_lf_alloc(mbox);
> @@ -391,6 +392,13 @@ nix_inl_nix_setup(struct nix_inl_dev *inl_dev)
> goto unregister_irqs;
> }
>
> + if (roc_model_is_cn10k()) {
> + for (i = 0; i < ipsec_in_max_spi; i++) {
> + sa = ((uint8_t *)inl_dev->inb_sa_base) +
> + (i * inb_sa_sz);
> + roc_nix_inl_inb_sa_init(sa);
> + }
> + }
> /* Setup device specific inb SA table */
> rc = nix_inl_nix_ipsec_cfg(inl_dev, true);
> if (rc) {
> diff --git a/drivers/common/cnxk/version.map b/drivers/common/cnxk/version.map
> index bf47b33..c2333a5 100644
> --- a/drivers/common/cnxk/version.map
> +++ b/drivers/common/cnxk/version.map
> @@ -62,12 +62,14 @@ INTERNAL {
> roc_cpt_iq_disable;
> roc_cpt_iq_enable;
> roc_cpt_lf_ctx_flush;
> + roc_cpt_lf_ctx_reload;
> roc_cpt_lf_init;
> roc_cpt_lf_fini;
> roc_cpt_lfs_print;
> roc_cpt_lmtline_init;
> roc_cpt_parse_hdr_dump;
> roc_cpt_rxc_time_cfg;
> + roc_cpt_ctx_write;
> roc_error_msg_get;
> roc_hash_sha1_gen;
> roc_hash_sha256_gen;
> @@ -144,6 +146,9 @@ INTERNAL {
> roc_nix_inl_outb_sso_pffunc_get;
> roc_nix_inl_outb_is_enabled;
> roc_nix_inl_sa_sync;
> + roc_nix_inl_ctx_write;
> + roc_nix_inl_inb_sa_init;
> + roc_nix_inl_outb_sa_init;
> roc_nix_is_lbk;
> roc_nix_is_pf;
> roc_nix_is_sdp;
> --
> 2.8.4
>
prev parent reply other threads:[~2021-11-03 15:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 15:54 Nithin Dabilpuram
2021-11-02 15:54 ` [dpdk-dev] [PATCH 2/9] common/cnxk: add CPT CTX sync mailbox API Nithin Dabilpuram
2021-11-02 15:54 ` [dpdk-dev] [PATCH 3/9] common/cnxk: support flow control on LBK Nithin Dabilpuram
2021-11-02 15:54 ` [dpdk-dev] [PATCH 4/9] common/cnxk: enable tm to listen on Rx pause frames Nithin Dabilpuram
2021-11-02 15:54 ` [dpdk-dev] [PATCH 5/9] common/cnxk: enable bp on CPT with inline inbound Nithin Dabilpuram
2021-11-02 15:54 ` [dpdk-dev] [PATCH 6/9] common/cnxk: support changing drop re flag after lf alloc Nithin Dabilpuram
2021-11-02 15:54 ` [dpdk-dev] [PATCH 7/9] net/cnxk: write CPT CTX through microcode op Nithin Dabilpuram
2021-11-02 15:54 ` [dpdk-dev] [PATCH 8/9] net/cnxk: allow fc on lbk and enable tm bp on Rx pause Nithin Dabilpuram
2021-11-02 15:54 ` [dpdk-dev] [PATCH 9/9] event/cnxk: disable drop re on vector enable for cn10k a0 Nithin Dabilpuram
2021-11-03 15:09 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1MOeiA-C47zWCNh-s0HftBLg9--N8ZQCdSbs3Nt6=7Gqw@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=mdr@ashroe.eu \
--cc=ndabilpuram@marvell.com \
--cc=schalla@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).