From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A157F440E8; Mon, 27 May 2024 19:18:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7ADE7402D9; Mon, 27 May 2024 19:18:16 +0200 (CEST) Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by mails.dpdk.org (Postfix) with ESMTP id 540F9402D8 for ; Mon, 27 May 2024 19:18:14 +0200 (CEST) Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6ad881cce98so3094076d6.1 for ; Mon, 27 May 2024 10:18:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716830294; x=1717435094; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=p1VotEP9ZShA43/x7DCGBLudEMxPqZp2vY9+itvhbgs=; b=eedemll+sTUDn9d1deu0dynOkt7hTIELUOhp05yiIHO2zHTP09HoKDZBIZFCgnyAvI 7rDruo5rzvb2vQ9Rd7sTfLrKmZj+v/HC24Mf3yJJlrSImIihYSZ43yEA0m/ilxIVOQII uLeyPIzXN9Nz8KZ9DauSdZhRYfyaXxud7UqUtOURRuV5qJdpSjiBe757dof4F8S86xQ3 P7fWWlAv4zVsfSpnikeYvHzgtKeFwNCuUfCH40y8erL2wWOY5x4pFJOh7dIAPIOrqXdh 1ubj2TVHiUGBCGO2ItEXETwXqXmyLDWLB9uhvxCl2KN4JU9ZfNc4PA58K6AjImwurvV8 CciQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716830294; x=1717435094; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p1VotEP9ZShA43/x7DCGBLudEMxPqZp2vY9+itvhbgs=; b=MeJqOrkt1Ji8ZbQzCRV6dABygNAmqf37TK4K566oVR5Dbsyy5B7yqrTZj260xFhrbg b3A1gN6e30IMtEkLw1yJeesnwD3uycrqBnbA4EV1KHSrtPxSoo+utxemY/CwdDS/V3X7 8OcmbudIy85ATod7m564KkjX7YjN+QZ6ecqs4uo50Y/gLzOKRvp3tH1iLOSXmilyJC4/ XIsnK6RMTQ+WFiOgllCFPMR2Eh+6bsF+mNNjEQo1X41H4NeTtwmkA6VwqnUq+jTara+D jXKW28pWzzvknf4t0SxqCa3vOSIrLhMI4zOcbKC0DuHP1D5mSlRQIMPUMoQ1JyKXe8Qh yLdg== X-Forwarded-Encrypted: i=1; AJvYcCUs/+XHkqz0ejDK/aN11QORnozJidTrDp+K0WrOEZUULzaVgH33K5JZl4J94YEEsBccaZUg9n9bVxWuShc= X-Gm-Message-State: AOJu0Yzp/D5fkVlc+v9gZOk6Hlg01xsI/8pzaC+dc7WFYKRDJfIONW1a BZFz6zdaJAm1j/7+fmgq4g+Ei39uFiPcQBGBWRuM727QkV32kS0dqDfuVHl676rl5eXTasm5HuQ /zfSTrroQkZ97XeCioZV9bdoHE4c= X-Google-Smtp-Source: AGHT+IGF8wUeieJQFY0SZjoHYppyZ45pvijMf6Ghuos91dShNmNpaiZ57G6/8Loj3zReLR/rs4WYwOKC8o7/g3pKFQc= X-Received: by 2002:a05:6214:5c08:b0:6ab:9dd9:6f33 with SMTP id 6a1803df08f44-6abbbc18d28mr93472206d6.3.1716830293594; Mon, 27 May 2024 10:18:13 -0700 (PDT) MIME-Version: 1.0 References: <20231109183323.2880-1-mattias.ronnblom@ericsson.com> <20240524192437.183960-1-mattias.ronnblom@ericsson.com> <74e169b4-3b28-498d-9af1-c60e6aeb82fa@lysator.liu.se> In-Reply-To: <74e169b4-3b28-498d-9af1-c60e6aeb82fa@lysator.liu.se> From: Jerin Jacob Date: Mon, 27 May 2024 22:47:46 +0530 Message-ID: Subject: Re: [PATCH] event/dsw: support explicit release only mode To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Jerin Jacob , dev@dpdk.org, bruce.richardson@intel.com, Peter Nilsson J , =?UTF-8?B?U3ZhbnRlIErDpHJ2c3Ryw6V0?= , Heng Wang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, May 27, 2024 at 9:38=E2=80=AFPM Mattias R=C3=B6nnblom wrote: > > On 2024-05-27 17:35, Jerin Jacob wrote: > > On Sat, May 25, 2024 at 1:13=E2=80=AFAM Mattias R=C3=B6nnblom > > wrote: > >> > >> Add the RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE capability to the > >> DSW event device. > >> > >> This feature may be used by an EAL thread to pull more work from the > >> work scheduler, without giving up the option to forward events > >> originating from a previous dequeue batch. This in turn allows an EAL > >> thread to be productive while waiting for a hardware accelerator to > >> complete some operation. > >> > >> Prior to this change, DSW didn't make any distinction between > >> RTE_EVENT_OP_FORWARD and RTE_EVENT_OP_NEW type events, other than that > >> new events would be backpressured earlier. > >> > >> After this change, DSW tracks the number of released events (i.e., > >> events of type RTE_EVENT_OP_FORWARD and RTE_EVENT_OP_RELASE) that has > >> been enqueued. > >> > >> For efficency reasons, DSW does not track the *identity* of individual > >> events. This in turn implies that a certain stage in the flow > >> migration process, DSW must wait for all pending releases (on the > >> migration source port, only) to be received from the application, to > >> assure that no event pertaining to any of the to-be-migrated flows are > >> being processed. > >> > >> With this change, DSW starts making a distinction between forward and > >> new type events for credit allocation purposes. Only RTE_EVENT_OP_NEW > >> events needs credits. All events marked as RTE_EVENT_OP_FORWARD must > >> have a corresponding dequeued event from a previous dequeue batch. > >> > >> Flow migration for flows on RTE_SCHED_TYPE_PARALLEL queues remains > >> unaffected by this change. > >> > >> A side-effect of the tweaked DSW migration logic is that the migration > >> latency is reduced, regardless if implicit relase is enabled or not. > >> > >> Signed-off-by: Mattias R=C3=B6nnblom > > > > > > 1) Update releases for PMD specific section for this new feature > > Should the release note update be in the same patch, or a separate? Same patch. > > > 2) Fix CI issue as applicable > > > > https://patches.dpdk.org/project/dpdk/patch/20240524192437.183960-1-mat= tias.ronnblom@ericsson.com/ > > http://mails.dpdk.org/archives/test-report/2024-May/672848.html > > https://github.com/ovsrobot/dpdk/actions/runs/9229147658